From 9a994aba7091ccd09dd1b1d85141b6a8a3bed4c9 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 21 May 2021 16:40:19 +0000 Subject: [PATCH] test: disable test that flakes in Chromium (#457) --- .../com/microsoft/playwright/TestNetworkRequest.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java b/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java index 42716a78..0b7555df 100644 --- a/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java +++ b/playwright/src/test/java/com/microsoft/playwright/TestNetworkRequest.java @@ -28,8 +28,7 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.stream.Collectors; -import static com.microsoft.playwright.Utils.attachFrame; -import static com.microsoft.playwright.Utils.mapOf; +import static com.microsoft.playwright.Utils.*; import static org.junit.jupiter.api.Assertions.*; public class TestNetworkRequest extends TestBase { @@ -102,8 +101,13 @@ public class TestNetworkRequest extends TestBase { assertTrue(response.request().headers().get("user-agent").contains("WebKit")); } + + static boolean isWebKitWindowsOrChromium() { + return (isWebKit() && getOS() == Utils.OS.WINDOWS) || isChromium(); + } + @Test - @DisabledIf(value="com.microsoft.playwright.TestBase#isWebKit", disabledReason="fail") + @DisabledIf(value="isWebKitWindowsOrChromium", disabledReason="Flaky, see https://github.com/microsoft/playwright/issues/6690") void shouldGetTheSameHeadersAsTheServer() throws ExecutionException, InterruptedException { Future serverRequest = server.futureRequest("/empty.html"); server.setRoute("/empty.html", exchange -> {