From 9f2b4820847c5748860e8eba5c632467d1c701f8 Mon Sep 17 00:00:00 2001
From: Yury Semikhatsky <yurys@chromium.org>
Date: Thu, 21 Oct 2021 23:40:17 -0700
Subject: [PATCH] chore: move common parts to parent pom, update module
 descriptions (#658)

---
 .github/workflows/test.yml |  4 ++--
 assertions/pom.xml         | 17 +++--------------
 driver-bundle/pom.xml      | 14 +-------------
 driver/pom.xml             | 17 +----------------
 playwright/pom.xml         | 10 ----------
 pom.xml                    | 17 ++++++++++++++---
 6 files changed, 21 insertions(+), 58 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 73a858c8..fb3c4fbd 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -36,7 +36,7 @@ jobs:
     - name: Build with Maven
       run: mvn -B package -D skipTests --no-transfer-progress
     - name: Run tests
-      run: mvn test --no-transfer-progress
+      run: mvn test --no-transfer-progress --fail-at-end
       env:
         BROWSER: ${{ matrix.browser }}
     - name: Test Spring Boot Starter
@@ -85,7 +85,7 @@ jobs:
       - name: Build with Maven
         run: mvn -B package -D skipTests --no-transfer-progress
       - name: Run tests
-        run: mvn test --no-transfer-progress
+        run: mvn test --no-transfer-progress --fail-at-end
         env:
           BROWSER: chromium
           BROWSER_CHANNEL: ${{ matrix.browser-channel }}
diff --git a/assertions/pom.xml b/assertions/pom.xml
index a0b16dee..529e0233 100644
--- a/assertions/pom.xml
+++ b/assertions/pom.xml
@@ -12,7 +12,7 @@
   <artifactId>assertions</artifactId>
   <name>Playwright - Assertions</name>
   <description>
-    This module provides AssertJ Matchers specific to Playwright.
+    This module provides Playwright assertions that will wait until the expected condition is met.
   </description>
 
   <build>
@@ -25,24 +25,13 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
         <configuration>
-          <source>8</source>
-          <failOnError>false</failOnError>
+          <subpackages>com.microsoft.playwright.assertions</subpackages>
+          <excludePackageNames>com.microsoft.playwright.impl</excludePackageNames>
         </configuration>
-        <executions>
-          <execution>
-            <id>attach-javadocs</id>
-            <goals>
-              <goal>jar</goal>
-            </goals>
-          </execution>
-        </executions>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
-        <configuration>
-          <redirectTestOutputToFile>true</redirectTestOutputToFile>
-        </configuration>
       </plugin>
     </plugins>
   </build>
diff --git a/driver-bundle/pom.xml b/driver-bundle/pom.xml
index 428b3159..5106b2fd 100644
--- a/driver-bundle/pom.xml
+++ b/driver-bundle/pom.xml
@@ -12,7 +12,7 @@
   <artifactId>driver-bundle</artifactId>
   <name>Playwright - Drivers For All Platforms</name>
   <description>
-    This module includes playwright-cli binary and related utilities for all supported platforms.
+    This module includes Playwright driver and related utilities for all supported platforms.
     It is intended to be used on the systems where Playwright driver is not preinstalled.
   </description>
 
@@ -28,18 +28,6 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
-        <configuration>
-          <source>8</source>
-          <failOnError>false</failOnError>
-        </configuration>
-        <executions>
-          <execution>
-            <id>attach-javadocs</id>
-            <goals>
-              <goal>jar</goal>
-            </goals>
-          </execution>
-        </executions>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
diff --git a/driver/pom.xml b/driver/pom.xml
index f253b570..9f5bea38 100644
--- a/driver/pom.xml
+++ b/driver/pom.xml
@@ -12,7 +12,7 @@
   <artifactId>driver</artifactId>
   <name>Playwright - Driver</name>
   <description>
-    This module provides API for discovery and launching of playwright-cli binary.
+    This module provides API for discovery and launching of Playwright driver.
   </description>
 
   <build>
@@ -24,25 +24,10 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-javadoc-plugin</artifactId>
-        <configuration>
-          <source>8</source>
-          <failOnError>false</failOnError>
-        </configuration>
-        <executions>
-          <execution>
-            <id>attach-javadocs</id>
-            <goals>
-              <goal>jar</goal>
-            </goals>
-          </execution>
-        </executions>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
-        <configuration>
-          <redirectTestOutputToFile>true</redirectTestOutputToFile>
-        </configuration>
       </plugin>
     </plugins>
   </build>
diff --git a/playwright/pom.xml b/playwright/pom.xml
index 0a123aac..9ed9bef7 100644
--- a/playwright/pom.xml
+++ b/playwright/pom.xml
@@ -31,17 +31,7 @@
         <configuration>
           <subpackages>com.microsoft.playwright</subpackages>
           <excludePackageNames>com.microsoft.playwright.impl</excludePackageNames>
-          <additionalOptions>--allow-script-in-comments</additionalOptions>
-          <failOnError>false</failOnError>
         </configuration>
-        <executions>
-          <execution>
-            <id>attach-javadocs</id>
-            <goals>
-              <goal>jar</goal>
-            </goals>
-          </execution>
-        </executions>
       </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
diff --git a/pom.xml b/pom.xml
index 8162e586..c79e1963 100644
--- a/pom.xml
+++ b/pom.xml
@@ -116,6 +116,18 @@
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-javadoc-plugin</artifactId>
           <version>3.2.0</version>
+          <configuration>
+            <additionalOptions>--allow-script-in-comments</additionalOptions>
+            <failOnError>false</failOnError>
+          </configuration>
+          <executions>
+            <execution>
+              <id>attach-javadocs</id>
+              <goals>
+                <goal>jar</goal>
+              </goals>
+            </execution>
+          </executions>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
@@ -131,9 +143,8 @@
                 junit.jupiter.execution.parallel.config.dynamic.factor=0.5
               </configurationParameters>
             </properties>
-            <failIfNoTests>
-              false
-            </failIfNoTests>
+            <failIfNoTests>false</failIfNoTests>
+            <redirectTestOutputToFile>true</redirectTestOutputToFile>
           </configuration>
         </plugin>
         <plugin>