From e3f2f6fa5b5c349f5a46d7286fd8c905d3ce1528 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 12 Jun 2026 14:09:31 -0700 Subject: [PATCH] fix(docker): assemble driver on the host for docker builds (#1930) --- utils/docker/Dockerfile.jammy | 1 - utils/docker/Dockerfile.noble | 1 - utils/docker/build.sh | 4 ++++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/utils/docker/Dockerfile.jammy b/utils/docker/Dockerfile.jammy index e66319a8..0f290946 100644 --- a/utils/docker/Dockerfile.jammy +++ b/utils/docker/Dockerfile.jammy @@ -44,7 +44,6 @@ RUN mkdir /ms-playwright && \ COPY . /tmp/pw-java RUN cd /tmp/pw-java && \ - ./scripts/download_driver.sh && \ mvn install -D skipTests --no-transfer-progress && \ DEBIAN_FRONTEND=noninteractive mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI \ -D exec.args="install-deps" -f playwright/pom.xml --no-transfer-progress && \ diff --git a/utils/docker/Dockerfile.noble b/utils/docker/Dockerfile.noble index e0173bd6..6b8b4bac 100644 --- a/utils/docker/Dockerfile.noble +++ b/utils/docker/Dockerfile.noble @@ -44,7 +44,6 @@ RUN mkdir /ms-playwright && \ COPY . /tmp/pw-java RUN cd /tmp/pw-java && \ - ./scripts/download_driver.sh && \ mvn install -D skipTests --no-transfer-progress && \ DEBIAN_FRONTEND=noninteractive mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI \ -D exec.args="install-deps" -f playwright/pom.xml --no-transfer-progress && \ diff --git a/utils/docker/build.sh b/utils/docker/build.sh index 074d22b1..ed265307 100755 --- a/utils/docker/build.sh +++ b/utils/docker/build.sh @@ -34,4 +34,8 @@ fi PW_TARGET_ARCH=$(echo $1 | cut -c3-) +# Assemble the driver on the host where npm is available; the Dockerfile picks +# it up via `COPY . /tmp/pw-java`. +../../scripts/download_driver.sh + docker build --platform "${PLATFORM}" --build-arg "PW_TARGET_ARCH=${PW_TARGET_ARCH}" -t "$3" -f "Dockerfile.$2" ../../