fix(dart/transform): Remove malfunctioning zone error handler

Remove `onError` zone callback which is consuming exceptions thrown by
the `Transformer`s and can cause `pub` to become unresponsive.

Closes #3368
This commit is contained in:
Tim Blasi
2015-07-30 00:07:19 +00:00
parent 7b834e02ec
commit 68a581a04c
9 changed files with 19 additions and 25 deletions
@@ -11,20 +11,11 @@ typedef _SimpleCallback();
final _key = #loggingZonedLoggerKey;
/// Executes {@link fn} inside a new {@link Zone} with its own logger.
dynamic initZoned(Transform t, _SimpleCallback fn, {String errorMessage: ''}) =>
setZoned(new BuildLogger(t), fn, errorMessage: errorMessage);
dynamic initZoned(Transform t, _SimpleCallback fn) =>
setZoned(new BuildLogger(t), fn);
dynamic setZoned(BuildLogger logger, _SimpleCallback fn,
{String errorMessage}) {
var onError;
if (errorMessage != null) {
onError = (e, stackTrace) {
logger.error('$errorMessage\n'
'Exception: $e\n'
'Stack Trace: $stackTrace');
};
}
return runZoned(fn, zoneValues: {_key: logger}, onError: onError);
dynamic setZoned(BuildLogger logger, _SimpleCallback fn) {
return runZoned(fn, zoneValues: {_key: logger});
}
/// The logger for the current {@link Zone}.