Kara Erickson
86104b82b8
refactor(core): rename ngInjectableDef to ɵprov ( #33151 )
...
Injectable defs are not considered public API, so the property
that contains them should be prefixed with Angular's marker
for "private" ('ɵ') to discourage apps from relying on def
APIs directly.
This commit adds the prefix and shortens the name from
ngInjectableDef to "prov" (for "provider", since injector defs
are known as "inj"). This is because property names cannot
be minified by Uglify without turning on property mangling
(which most apps have turned off) and are thus size-sensitive.
PR Close #33151
2019-10-16 16:36:19 -04:00
Carlos Ortiz García
9166baf709
refactor(core): Migrate TestBed.get to TestBed.inject ( #32382 )
...
This is cleanup/followup for PR #32200
PR Close #32382
2019-09-09 19:10:54 -04:00
Greg Magolan
a4a423a083
build: fix build failures with worker mode cache and @types/events ( #31325 )
...
Errors observed only in tests on CircleCI — was not reproducible locally.
```
ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
tsc_wrapped.exe failed: error executing command
cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
SET RUNFILES_MANIFEST_ONLY=1
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
Execution platform: @bazel_tools//platforms:host_platform
Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
d.ts
```
PR Close #31325
2019-07-01 14:16:43 -07:00
Alex Rickabaugh
26a85a82ff
Revert "build: fix build failures with worker mode cache and @types/events ( #31019 )" ( #31267 )
...
This reverts commit 6ba42f1da4 .
Reason: this causes failures in g3 with i18n extraction. See #31267 .
PR Close #31267
2019-06-25 14:36:00 -07:00
Greg Magolan
6ba42f1da4
build: fix build failures with worker mode cache and @types/events ( #31019 )
...
Errors observed only in tests on CircleCI — was not reproducible locally.
```
ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
tsc_wrapped.exe failed: error executing command
cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
SET RUNFILES_MANIFEST_ONLY=1
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
Execution platform: @bazel_tools//platforms:host_platform
Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
d.ts
```
PR Close #31019
2019-06-25 10:21:07 -07:00
Alex Eagle
b14537a004
fix(bazel): use //:tsconfig.json as the default for ng_module ( #29670 )
...
This matches the behavior of ts_library
PR Close #29670
2019-04-02 15:57:11 -07:00
Alan Agius
df354d1b34
fix(bazel): add missing binary path for api-extractor ( #29202 )
...
`api-extractor` binary is required for external consumers of `ng_module` that want to use the `bundle_dts` flag.
This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.
PR Close #29202
2019-03-12 10:49:49 -07:00
Greg Magolan
ea09430039
build: rules_nodejs 0.26.0 & use @npm instead of @ngdeps now that downstream angular build uses angular bundles ( #28871 )
...
PR Close #28871
2019-02-28 12:06:36 -08:00
Wassim Chegham
ce68b4d839
style: enforce buildifier lint on CI ( #28186 )
...
PR Close #28186
2019-02-26 16:57:41 -08:00
Greg Magolan
25aae64274
build(bazel): do not build rxjs from source under Bazel ( #28720 )
...
PR Close #28720
2019-02-19 16:28:14 -08:00
Kara Erickson
f2621dbb37
fix(core): remove createInjector() from public API ( #28509 )
...
createInjector() is an Ivy-only API that should not have
been exported as part of the public API. This commit removes
the export. It will be re-exported when Ivy is released.
PR Close #28509
2019-02-04 16:54:26 -05:00
Marc Laval
fa53150692
test(ivy): NodeInjector should know how to get itself (INJECTOR) ( #28009 )
...
PR Close #28009
2019-01-14 17:09:26 -08:00
Kara Erickson
6fff74e576
test(ivy): re-enable passing tests and misc cleanup ( #28093 )
...
PR Close #28093
2019-01-14 10:03:57 -08:00
Kara Erickson
062c7af4f3
test(ivy): replace resolved issue in compiler-cli test with new root cause ( #27709 )
...
PR Close #27709
2018-12-17 16:46:42 -08:00
Igor Minar
7fabe4429d
fix(ivy): add support for optional nullable injection tokens ( #27552 )
...
FW-778 #resolve
PR Close #27552
2018-12-12 13:04:29 -08:00
Alex Eagle
50687e11cf
build: fix type-check errors introduced during rules_ts 0.21 ( #27586 )
...
PR Close #27586
2018-12-10 16:33:41 -08:00
Ben Lesh
cd858323f2
feat(ivy): Forward refs now supported ( #27439 )
...
Adds deferred execution of scope setting for modules such that forward refs can be supported in ivy. Design docs can be found at https://docs.google.com/document/d/11KTbybis9rt0cZgMKd1wo_IKb6y1PMU-RoTDVLTXK4Y/edit#
PR Close #27439
2018-12-05 10:41:24 -08:00
Misko Hevery
f52600e261
test(ivy): add ability to find already passing tests ( #27449 )
...
PR Close #27449
2018-12-05 09:34:52 -08:00
Alex Rickabaugh
49537458ea
test(ivy): update //packages/compiler-cli tests for Ivy ( #27301 )
...
These tests are not relevant to Ivy:
//packages/compiler-cli/test/diagnostics:check_types
//packages/compiler-cli/test/diagnostics:expression_diagnostics
//packages/compiler-cli/test/transformers:test
//packages/compiler-cli/test:extract_i18n
The //packages/compiler-cli/test:ngtools_api test has 2 specs, one of
which passes and the other of which depends on ngtsc supporting lazy
routes. It's now disabled with fixmeIvy().
PR Close #27301
2018-11-29 21:31:35 -08:00
Igor Minar
78e3a4c97c
test(ivy): root-case //packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test:test ( #27278 )
...
PR Close #27278
2018-11-27 10:30:58 -08:00
Igor Minar
d35d164ece
test(ivy): add fixme to a failing testbed test ( #27278 )
...
PR Close #27278
2018-11-27 10:30:58 -08:00
Igor Minar
f7ba4b2ff9
fix(ivy): remove obsolete ng_module code for global and jit mode ( #27278 )
...
These paths are no longer needed / used.
I had to disable one jit mode spec because it fails now that we actually run it.
I root caused the jit test failure as missing forwardRef support. See FW-645.
PR Close #27278
2018-11-27 10:30:58 -08:00
Olivier Combe
20729b3378
fix(ivy): deduplicate imported modules in r3_injector ( #27102 )
...
PR Close #27102
2018-11-19 09:20:39 -08:00
Misko Hevery
7d2a746090
build: remove ivy JIT mode ( #26863 )
...
PR Close #26863
2018-11-02 15:44:05 -07:00
Igor Minar
40bbfbf961
test(ivy): fix or disable failing ivy tests ( #26735 )
...
These tests were previously not running on CI so they have always been broken,
or got broken just recently :-(.
test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags
PR Close #26735
2018-10-26 14:48:05 -04:00
Igor Minar
ee0b857172
build: rename the ivy compile mode 'local' to 'aot' ( #26686 )
...
PR Close #26686
2018-10-23 14:14:49 -07:00
Igor Minar
4237c34c78
test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags ( #26471 )
...
We are close enough to blacklist a few test targets, rather than whitelist targets to run...
Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.
This is the updated overview of ivy related bazel tags:
- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local
PR Close #26471
2018-10-23 08:57:42 -07:00
Greg Magolan
631998b2df
build: idiomatic install of @angular/bazel npm package ( #26258 ) ( #26488 )
...
PR Close #26488
2018-10-19 20:59:29 -07:00
Greg Magolan
1f3331f5e6
build(bazel): use fine-grained npm deps ( #26111 ) ( #26488 )
...
PR Close #26488
2018-10-19 20:59:29 -07:00
Greg Magolan
b99d7ed5bf
build(bazel): update to rules_typescript 0.17.0 & rules_nodejs 0.13.4 ( #25920 )
...
PR Close #25920
2018-09-18 13:05:38 -07:00