Greg Magolan
5f0d5e9ccf
build: update to nodejs rules 0.34.0 and bazel 0.28.1 ( #31824 )
...
nodejs rules 0.34.0 now includes protractor_web_test_suite rule (via new @bazel/protractor rule) so we switch to that location for that rule in this PR so that /packages/bazel/src/protractor can be removed in a future PR
this PR also brings in node toolchain support which was released in nodejs rules 0.33.0. this is a prerequisite for RBE for mac & windows users
bazel schematics also updated with the same. @bazel/bazel 0.28.1 npm package includes transitive dep on hide-bazel-files so we're able to remove an explicit dep on that as well.
PR Close #31824
2019-07-26 15:01:25 -07:00
Greg Magolan
a4a423a083
build: fix build failures with worker mode cache and @types/events ( #31325 )
...
Errors observed only in tests on CircleCI — was not reproducible locally.
```
ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
tsc_wrapped.exe failed: error executing command
cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
SET RUNFILES_MANIFEST_ONLY=1
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
Execution platform: @bazel_tools//platforms:host_platform
Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
d.ts
```
PR Close #31325
2019-07-01 14:16:43 -07:00
Greg Magolan
63bdfca580
build(bazel): cleanup entry_point target ( #31325 )
...
PR Close #31325
2019-07-01 14:16:42 -07:00
Alex Rickabaugh
2c07820636
Revert "build(bazel): cleanup entry_point target ( #31019 )" ( #31267 )
...
This reverts commit cd617b15e8#31267 .
PR Close #31267
2019-06-25 14:36:00 -07:00
Alex Rickabaugh
26a85a82ff
Revert "build: fix build failures with worker mode cache and @types/events ( #31019 )" ( #31267 )
...
This reverts commit 6ba42f1da4#31267 .
PR Close #31267
2019-06-25 14:36:00 -07:00
Greg Magolan
6ba42f1da4
build: fix build failures with worker mode cache and @types/events ( #31019 )
...
Errors observed only in tests on CircleCI — was not reproducible locally.
```
ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
(cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
exec env - \
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
PATH=/bin:/usr/bin:/usr/local/bin \
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
Execution platform: //tools:rbe_ubuntu1604-angular
Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
tsc_wrapped.exe failed: error executing command
cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
SET RUNFILES_MANIFEST_ONLY=1
bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
Execution platform: @bazel_tools//platforms:host_platform
Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
d.ts
```
PR Close #31019
2019-06-25 10:21:07 -07:00
Greg Magolan
cd617b15e8
build(bazel): cleanup entry_point target ( #31019 )
...
PR Close #31019
2019-06-25 10:21:07 -07:00
Alex Eagle
ef0b2cc74d
build: convert entry_point to label ( #30627 )
...
PR Close #30627
2019-06-11 00:03:11 +00:00
Alex Rickabaugh
84dd2679a9
fix(core): require 'static' flag on queries in typings ( #30639 )
...
This commit makes the static flag on @ViewChild and @ContentChild required.
BREAKING CHANGE:
In Angular version 8, it's required that all @ViewChild and @ContentChild
queries have a 'static' flag specifying whether the query is 'static' or
'dynamic'. The compiler previously sorted queries automatically, but in
8.0 developers are required to explicitly specify which behavior is wanted.
This is a temporary requirement as part of a migration; see
https://angular.io/guide/static-query-migration for more details.
@ViewChildren and @ContentChildren queries are always dynamic, and so are
unaffected.
PR Close #30639
2019-05-24 16:55:00 -04:00
Alan
1660b34e2d
test: fix several bazel compiler-cli tests in windows ( #30189 )
...
```
//packages/compiler-cli/integrationtest:integrationtest
//packages/compiler-cli/test/compliance:compliance
```
Partially addresses #29785
PR Close #30189
2019-05-07 10:21:36 -07:00
Alex Eagle
b14537a004
fix(bazel): use //:tsconfig.json as the default for ng_module ( #29670 )
...
This matches the behavior of ts_library
PR Close #29670
2019-04-02 15:57:11 -07:00
Alan Agius
df354d1b34
fix(bazel): add missing binary path for api-extractor ( #29202 )
...
`api-extractor` binary is required for external consumers of `ng_module` that want to use the `bundle_dts` flag.
This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.
PR Close #29202
2019-03-12 10:49:49 -07:00
Greg Magolan
ea09430039
build: rules_nodejs 0.26.0 & use @npm instead of @ngdeps now that downstream angular build uses angular bundles ( #28871 )
...
PR Close #28871
2019-02-28 12:06:36 -08:00
Wassim Chegham
ce68b4d839
style: enforce buildifier lint on CI ( #28186 )
...
PR Close #28186
2019-02-26 16:57:41 -08:00
Greg Magolan
25aae64274
build(bazel): do not build rxjs from source under Bazel ( #28720 )
...
PR Close #28720
2019-02-19 16:28:14 -08:00
Kara Erickson
f2621dbb37
fix(core): remove createInjector() from public API ( #28509 )
...
createInjector() is an Ivy-only API that should not have
been exported as part of the public API. This commit removes
the export. It will be re-exported when Ivy is released.
PR Close #28509
2019-02-04 16:54:26 -05:00
Alex Eagle
a227c528ca
feat(compiler-cli): expose ngtsc as a TscPlugin ( #28435 )
...
This lets us run ngtsc under the tsc_wrapped custom compiler (Used in Bazel)
It also allows others to simply wire ngtsc into an existing typescript compilation binary
PR Close #28435
2019-01-29 16:41:59 -08:00
Jason Aden
227f7e44d6
Revert "feat(compiler-cli): expose ngtsc as a TscPlugin" ( #28433 )
...
This reverts commit df2221c6476df1f2d2478b949702f3270c3a4565.
PR Close #28433
2019-01-29 11:29:48 -08:00
Alex Eagle
22f76df8f2
feat(compiler-cli): expose ngtsc as a TscPlugin ( #28431 )
...
This lets us run ngtsc under the tsc_wrapped custom compiler (Used in Bazel)
It also allows others to simply wire ngtsc into an existing typescript compilation binary
PR Close #28431
2019-01-29 09:44:58 -08:00
Paul Gschwendtner
8ced999e47
build: improve compiler-cli codegen output test ( #28191 )
...
* Improves the `compiler-cli/integrationtest` codegen output test slightly by using a more clear test description and by adding an assertion that ensures that decorators are downleveled.
PR Close #28191
2019-01-28 20:07:22 -08:00
Paul Gschwendtner
4c8d17ffd4
build: fix outdated ngtools compiler-cli test logic ( #28191 )
...
* Fixes that the test logic for `ngtools` in the offline compiler test is no longer working due to being unmaintained for a long time
* Makes the path comparison logic platform agnostic, so that the tests can be also executed on Windows
PR Close #28191
2019-01-28 20:07:22 -08:00
Paul Gschwendtner
3e6a1f0bc4
build: fix outdated i18n compiler-cli test assertions ( #28191 )
...
PR Close #28191
2019-01-28 20:07:22 -08:00
Paul Gschwendtner
40d64b6b58
build: run offline_compiler_test using bazel ( #28191 )
...
PR Close #28191
2019-01-28 20:07:22 -08:00
Marc Laval
fa53150692
test(ivy): NodeInjector should know how to get itself (INJECTOR) ( #28009 )
...
PR Close #28009
2019-01-14 17:09:26 -08:00
Kara Erickson
6fff74e576
test(ivy): re-enable passing tests and misc cleanup ( #28093 )
...
PR Close #28093
2019-01-14 10:03:57 -08:00
Kara Erickson
062c7af4f3
test(ivy): replace resolved issue in compiler-cli test with new root cause ( #27709 )
...
PR Close #27709
2018-12-17 16:46:42 -08:00
Igor Minar
7fabe4429d
fix(ivy): add support for optional nullable injection tokens ( #27552 )
...
FW-778 #resolve
PR Close #27552
2018-12-12 13:04:29 -08:00
Alex Eagle
50687e11cf
build: fix type-check errors introduced during rules_ts 0.21 ( #27586 )
...
PR Close #27586
2018-12-10 16:33:41 -08:00
Ben Lesh
cd858323f2
feat(ivy): Forward refs now supported ( #27439 )
...
Adds deferred execution of scope setting for modules such that forward refs can be supported in ivy. Design docs can be found at https://docs.google.com/document/d/11KTbybis9rt0cZgMKd1wo_IKb6y1PMU-RoTDVLTXK4Y/edit#
PR Close #27439
2018-12-05 10:41:24 -08:00
Misko Hevery
f52600e261
test(ivy): add ability to find already passing tests ( #27449 )
...
PR Close #27449
2018-12-05 09:34:52 -08:00
Greg Magolan
Alex Rickabaugh
Alex Eagle
Alan
Wassim Chegham
Kara Erickson
Jason Aden
Paul Gschwendtner
Marc Laval
Igor Minar
Alex Eagle
Ben Lesh
Misko Hevery