Martin Probst
c7e48350d3
These wrappers are not natively understood by ts2dart. Removing them will improve Dart2JS compilation due to fewer megamorphic calls to List functions. It also makes Angular code more succinct and improves type safety in Angular due to better type inference of the Array component type. This change exposed several bugs in Angular.
63 lines
2.4 KiB
TypeScript
63 lines
2.4 KiB
TypeScript
import {List, ListWrapper, StringMap} from 'angular2/src/facade/collection';
|
|
import {bind, Binding, OpaqueToken} from 'angular2/di';
|
|
|
|
import {Validator} from '../validator';
|
|
import {Statistic} from '../statistic';
|
|
import {MeasureValues} from '../measure_values';
|
|
|
|
/**
|
|
* A validator that checks the regression slope of a specific metric.
|
|
* Waits for the regression slope to be >=0.
|
|
*/
|
|
export class RegressionSlopeValidator extends Validator {
|
|
// TODO(tbosch): use static values when our transpiler supports them
|
|
static get SAMPLE_SIZE(): OpaqueToken { return _SAMPLE_SIZE; }
|
|
// TODO(tbosch): use static values when our transpiler supports them
|
|
static get METRIC(): OpaqueToken { return _METRIC; }
|
|
// TODO(tbosch): use static values when our transpiler supports them
|
|
static get BINDINGS(): List<Binding> { return _BINDINGS; }
|
|
|
|
_sampleSize: number;
|
|
_metric: string;
|
|
|
|
constructor(sampleSize, metric) {
|
|
super();
|
|
this._sampleSize = sampleSize;
|
|
this._metric = metric;
|
|
}
|
|
|
|
describe(): StringMap<string, any> {
|
|
return {'sampleSize': this._sampleSize, 'regressionSlopeMetric': this._metric};
|
|
}
|
|
|
|
validate(completeSample: List<MeasureValues>): List<MeasureValues> {
|
|
if (completeSample.length >= this._sampleSize) {
|
|
var latestSample = ListWrapper.slice(completeSample, completeSample.length - this._sampleSize,
|
|
completeSample.length);
|
|
var xValues = [];
|
|
var yValues = [];
|
|
for (var i = 0; i < latestSample.length; i++) {
|
|
// For now, we only use the array index as x value.
|
|
// TODO(tbosch): think about whether we should use time here instead
|
|
xValues.push(i);
|
|
yValues.push(latestSample[i].values[this._metric]);
|
|
}
|
|
var regressionSlope = Statistic.calculateRegressionSlope(
|
|
xValues, Statistic.calculateMean(xValues), yValues, Statistic.calculateMean(yValues));
|
|
return regressionSlope >= 0 ? latestSample : null;
|
|
} else {
|
|
return null;
|
|
}
|
|
}
|
|
}
|
|
|
|
var _SAMPLE_SIZE = new OpaqueToken('RegressionSlopeValidator.sampleSize');
|
|
var _METRIC = new OpaqueToken('RegressionSlopeValidator.metric');
|
|
var _BINDINGS = [
|
|
bind(RegressionSlopeValidator)
|
|
.toFactory((sampleSize, metric) => new RegressionSlopeValidator(sampleSize, metric),
|
|
[_SAMPLE_SIZE, _METRIC]),
|
|
bind(_SAMPLE_SIZE).toValue(10),
|
|
bind(_METRIC).toValue('scriptTime')
|
|
];
|