Adrien Delorme
f329cb5b93
simplify code
2020-10-29 12:18:41 +01:00
Adrien Delorme
b058de072a
move packer/builder/amazon/common.IsAWSErr to builder/amazon/common/awserrors.Matches
...
to avoid cyclic dependency issues
2020-10-29 12:02:41 +01:00
Adrien Delorme
8e355d0fe7
Move ssm code to its own ssm package and make it singlethreaded
2020-10-29 11:57:29 +01:00
Rémy Léone
db96c5c9ae
Fix
2020-10-29 11:21:31 +01:00
Rémy Léone
3413fc5c46
Fix
2020-10-29 11:19:18 +01:00
Rémy Léone
adb74ba15d
Fix
2020-10-29 11:09:04 +01:00
Megan Marsh
69312458c4
Merge pull request #10111 from hashicorp/azr_selectable_temp_keygen_type_gcp
...
GCP: Allow to select algo when generating temporary SSH keypair
2020-10-28 11:25:50 -07:00
Rémy Léone
288e29b1e0
scaleway: use the SDK functions to load profile from file and env
2020-10-28 17:52:34 +01:00
Wilken Rivera
646b973bd3
Remove logic to retry a connection that reuses an existing SSM Session
...
After testing it was found that once an session is terminated via an
instance restart, console termination, or SSM agent restart. Any active
session will essentially be terminated and unusable. So knowing that it
is always best to start a new session and let the old one timeout get
terminated.
2020-10-28 06:36:23 -04:00
Wilken Rivera
dff9cde775
Remove waitgroups
2020-10-28 06:36:23 -04:00
Wilken Rivera
eb11009e2a
Check for closed channels as opposed to using a separate closeRetry channel
2020-10-28 06:36:23 -04:00
Megan Marsh
fb3d357e84
fix step_shutdown when a null communicator is used ( #10178 )
2020-10-28 11:14:03 +01:00
sylviamoss
aa73cc7d7e
add close chan to avoid unwanted retries
2020-10-27 16:32:20 -04:00
sylviamoss
1f62249097
add retry terminated session chan
2020-10-27 16:32:20 -04:00
sylviamoss
8e3f3e514c
improve logs
2020-10-27 16:32:20 -04:00
sylviamoss
b2c7897f58
add WaitGroup to avoid data race
2020-10-27 16:32:20 -04:00
sylviamoss
1c2b469acd
add retry channel to ssm driver
2020-10-27 16:32:19 -04:00
Megan Marsh
8f3a115c5a
Merge pull request #10173 from hashicorp/azr-fix-hcl2-gcp-image_encryption_key
...
Fix GCP HCL image_encryption_key fields and use the same casing in JSON and HCL2
2020-10-27 10:56:26 -07:00
Megan Marsh
dc38fadeeb
Merge pull request #10155 from hashicorp/logging_for_10042
...
builder/vsphere: Don't try to delete a cd file from the remote datastore if the upload of the cd failed
2020-10-27 10:54:07 -07:00
Megan Marsh
8adbba6904
switch to guard clause format
2020-10-27 10:37:03 -07:00
Adrien Delorme
ef32147a4a
Fix GCP HCL image_encryption_key fields and use the same casing in JSON and HCL2
...
this closes #9997
2020-10-27 15:46:45 +01:00
Megan Marsh
c4866504e1
respect the destroy flag in content library config ( #10165 )
...
* respect the destroy flag in content library config
* Make vsphere-clone respect delete_vm state tag; use a common delete func to prevent future drift
2020-10-27 09:07:08 -04:00
Adrien Delorme
4bc16455b4
HCL2: add a packer block with a required_version input setting ( #10149 )
...
* add the possibility to set the packer.required_version field; to make sure the template file works with that version of Packer
* add tests
* add documentation on packer.required_version
Example:
packer {
required_version = ">= 1.2.0, < 2.0.0"
}
2020-10-27 10:03:36 +01:00
Wilken Rivera
73e842fab6
update CHANGELOG
2020-10-26 14:00:17 -04:00
Adrien Delorme
bab29060fe
regen hcl after master merge
2020-10-26 15:48:10 +01:00
Adrien Delorme
f5e037e8b4
Merge remote-tracking branch 'origin/master' into azr_selectable_temp_keygen_type_gcp
2020-10-26 15:47:29 +01:00
Adrien Delorme
b4f68767a3
make default key type RSA instead of DSA
2020-10-26 15:45:06 +01:00
73370570f4
Fix Proxmox builder unhandled buildvar type ( #10154 )
...
* Fix Proxmox builder unhandled buildvar type #10139
Co-authored-by: Calle Pettersson <[email protected] >
Co-authored-by: Adrien Delorme <[email protected] >
2020-10-26 15:11:09 +01:00
Megan Marsh
25f4e24772
Merge pull request #10150 from nshalman/nshalman/tag-snapshots
...
amazon/ebssurrogate: apply snapshot tags right when taking snapshot
2020-10-23 15:57:18 -07:00
Megan Marsh
7646ecf8c6
fix tests
2020-10-23 15:35:37 -07:00
Megan Marsh
8821114e97
Merge pull request #10162 from hashicorp/td-makefile-test-targets
...
makefile: Disable test caching explicitly for go test
2020-10-23 15:22:20 -07:00
Megan Marsh
4862b2c0f0
Merge pull request #10163 from hashicorp/fix-azure_arm-manageddisk-deletion-regression
...
builder/azure_arm: Fix build failures due to the deletion of attached managed disks
2020-10-23 15:19:30 -07:00
Wilken Rivera
791a69e78f
Merge pull request #10166 from hashicorp/fix_master
...
fix fixer deprecated options conflict
2020-10-23 17:09:16 -04:00
Megan Marsh
645eff58d1
fix fixer deprecated options conflict
2020-10-23 14:00:12 -07:00
Megan Marsh
fc619dc977
Merge pull request #9626 from featheredtoast/add-proxmox-vm-clone
...
builder/proxmox FEATURE: split Proxmox into proxmox-iso and proxmox-clone
2020-10-23 13:36:45 -07:00
Megan Marsh
b6424354c3
Merge pull request #9964 from netapp-jgriffit/hashicorp/packer#9924
...
Hashicorp/packer#9924
2020-10-23 12:44:55 -07:00
Megan Marsh
56c7a9cda5
rebase
2020-10-23 11:47:20 -07:00
netapp-jgriffit and Sylvia Moss
15467aa868
Update builder/vsphere/common/step_shutdown.go
...
Co-authored-by: Sylvia Moss <[email protected] >
2020-10-23 11:41:03 -07:00
James Griffith
185f3d9d48
vsphere clone config not yet using warnings, leaving code commented out
2020-10-23 11:41:03 -07:00
James Griffith
c8ad66f419
update to docs as suggested
2020-10-23 11:41:03 -07:00
James Griffith
c86a48fbc9
syntax change
2020-10-23 11:41:03 -07:00
James Griffith
f86f7c4464
Another instance using Prepare() needed an update
2020-10-23 11:41:03 -07:00
James Griffith
09edada93d
moved the warning into Prepare() and updated the invocation
2020-10-23 11:41:03 -07:00
James Griffith
572de129d7
update documentation
2020-10-23 11:41:03 -07:00
James Griffith
1048cdbcc4
check for no communicator and provide messaging to user
2020-10-23 11:41:03 -07:00
James Griffith
2ecf5cc9aa
Communicator is not needed unless shutdown_command is populated
2020-10-23 11:41:03 -07:00
James Griffith
6b39b1eed6
StepShutdown should still occur if Comm.Type is none
2020-10-23 11:41:03 -07:00
James Griffith
65ff092fd4
hashicorp/packer#9924
2020-10-23 11:41:03 -07:00
Megan Marsh
19bd997f11
add directory existence check
2020-10-23 11:06:25 -07:00
Wilken Rivera
a1d69bfe91
Fix liniting issues
2020-10-23 13:52:05 -04:00