As part of the work to displace everything related to HCP from scattered
places around the Packer code, we move it all to an hcp package.
This in turn reduces the amount of code that the commands have to
integrate, and leaves the HCP details to its own enclave.
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.Setenv
Signed-off-by: Eng Zer Jun <[email protected]>
This change sets a region on the test datasource config to fix intermittent InvalidAMIID.NotFound errors.
Closes https://github.com/hashicorp/packer-internal-issues/issues/14
Failing results before change
```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:40:05 Found region us-west-1
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
pluginacc.go:143: Error running plugin acceptance tests: Bad exit code. Logfile: packer_log_amazon-ami_basic_datasource_test.txt
Logs can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/packer_log_amazon-ami_basic_datasource_test.txt
and the acceptance test template can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/amazon-ami_basic_datasource_test.pkr.hcl
--- FAIL: TestAccInitAndBuildBasicAmazonAmiDatasource (9.87s)
FAIL
FAIL github.com/hashicorp/packer/acctest/plugin 10.326s
```
Passing results after change
```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:47:28 Found region us-west-1
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccInitAndBuildBasicAmazonAmiDatasource (223.32s)
PASS
```
* Update plugin directory check for ci
On CIRCLECI the default plugin direction is under `$HOME/.config/packer`
this changes updates the acctest just a bit to check if we are running
in a CIRCLECI env.
* Apply same logic to cleanup step
* Upgrade plugins to latest working versions
* Update accetest to work with new AMIHelper
* More updates
* More plugin updates
* bump MANY plugins at once !
* up docker plugin && go mod tidy
* up vmware plugin to v1.0.0
* Bump packer-plugin-azure to latest
* Update tencentcloud plugin
* Update packer-plugin-oneandone
Co-authored-by: Adrien Delorme <[email protected]>
Lucas Bajolet
Eng Zer Jun
sylviamoss