Adrien Delorme
7ec39ebb4e
TestStringSlice_Set: check error even if none is returned
2020-03-12 18:01:20 +01:00
Megan Marsh
17f59c4ddc
fix regex and actually test the check function
2020-03-12 10:00:56 -07:00
Moss
6c06a2a048
Fix format
2020-03-12 17:59:34 +01:00
Moss
ebdc694b25
Remove template.json
2020-03-12 17:58:11 +01:00
Moss
a3740bb9be
Interpolate shell inline config
2020-03-12 17:54:31 +01:00
Megan Marsh and Adrien Delorme
ad5495ac8f
Update packer/core.go
...
Co-Authored-By: Adrien Delorme <[email protected] >
2020-03-12 09:50:02 -07:00
Megan Marsh
4bd7b14096
Merge pull request #8732 from jhawk28/reorder_cdrom_drive
...
add the remote iso first so that it is first in boot order
2020-03-12 09:35:12 -07:00
Adrien Delorme
710ebdcef5
add more test for var files
2020-03-12 17:08:53 +01:00
Joshua Foster
8eac9f9634
add boot order documentation based on feedback
2020-03-12 11:29:20 -04:00
Joshua Foster
49bd57ee12
add the remote iso first so that it is first in boot order
2020-03-12 11:29:19 -04:00
Adrien Delorme
6b48feb817
kvflag: add TestStringSlice_Set
2020-03-12 16:28:23 +01:00
Adrien Delorme
c8300b620a
allow to use hcl files as var files in HCL mode
...
fix #8781
2020-03-12 15:41:40 +01:00
Wilken Rivera
7b705545d9
docs: Various doc clean-ups to fix code block formatting and syntax highlighting ( #8868 )
2020-03-12 15:05:08 +01:00
zac
79f1fab836
hcl2template/types: add spaces in error messages. ( #8881 )
2020-03-12 13:40:25 +01:00
Sylvia Moss
fa4b9ae958
Add Codecov configuration ( #8862 )
2020-03-12 10:36:10 +01:00
Mike Brancato
6a141c7695
add generated documentation
2020-03-11 21:52:36 -04:00
Mike Brancato
ebb161ae41
Fix config documentation
2020-03-11 21:43:37 -04:00
Mike Brancato
892622987c
Add KeyVault parameter and fix whitespace
2020-03-11 21:13:10 -04:00
Mike Brancato
0f09638f7a
Add HCL2 spec for KeyVault SKU
2020-03-11 20:48:34 -04:00
Mike Brancato
3c6b248bd5
Fix formatting
2020-03-11 20:45:44 -04:00
Mike Brancato
926e3ac2e4
Add support for configurable KeyVault SKU
2020-03-11 20:33:57 -04:00
Paul Cichonski (pcichons)
c3d793255e
Do not test if NIC is reachable when ssh bastion is required
...
Relates to https://github.com/hashicorp/packer/issues/8866
2020-03-11 19:27:48 -04:00
Megan Marsh
051155270f
add test for fixed behavior
2020-03-11 12:48:35 -07:00
Megan Marsh
52f03de0f0
adding tests
2020-03-11 10:49:45 -07:00
Megan Marsh
063dd5c133
fix interpolation when env vars interpolate before user vars
2020-03-11 09:55:40 -07:00
Wilken Rivera
b9f1b3c8d4
Fix gosimple S1005 linting issue ( #8870 )
...
Results before change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1005
fix/fixer_comm_config.go:48:4: S1005: should write `sshHostPortMinRaw := builders["ssh_host_port_min"]` instead of `sshHostPortMinRaw, _ := builders["ssh_host_port_min"]` (gosimple)
fix/fixer_comm_config.go:64:4: S1005: should write `sshHostPortMaxRaw := builders["ssh_host_port_max"]` instead of `sshHostPortMaxRaw, _ := builders["ssh_host_port_max"]` (gosimple)
fix/fixer_comm_config.go:81:4: S1005: should write `sshSkipNatMappingRaw := builders["ssh_skip_nat_mapping"]` instead of `sshSkipNatMappingRaw, _ := builders["ssh_skip_nat_mapping"]` (gosimple)
packer/artifact_mock.go:47:2: S1005: should write `value := a.StateValues[name]` instead of `value, _ := a.StateValues[name]` (gosimple)
packer/artifact_test.go:31:2: S1005: should write `value := a.state[name]` instead of `value, _ := a.state[name]` (gosimple)
```
Results after change
```
```
2020-03-11 10:30:08 +01:00
Wilken Rivera
66ad6f3483
builders: Fix gosimple S1007 linting issue ( #8871 )
...
Results before change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007
builder/alicloud/ecs/image_config.go:208:9: S1007: should use raw string
post-processor/vsphere-template/step_mark_as_template.go:130:8: S1007: shape twice (gosimple)
builder/azure/arm/config.go:58:27: S1007: should use raw string (`...`)
builder/azure/arm/config.go:59:27: S1007: should use raw string (`...`)
builder/qemu/driver.go:192:15: S1007: should use raw string (`...`)
```
Results after change
```
⇶ golangci-lint run ./... --disable-all --enable=gosimple | grep 1007
```
2020-03-11 10:29:22 +01:00
r_takaishi
4bb4f7617f
need white spaces
2020-03-11 11:04:59 +09:00
r_takaishi
0230c078e0
write docs
2020-03-11 10:53:59 +09:00
r_takaishi
34bb0429d0
keyboard-interactive used when ssh_bastion_host is true.
2020-03-11 10:37:57 +09:00