Lars Lehtonen
3571c585bb
builder/googlecompute: fix dropped error ( #8385 )
2019-11-19 11:41:39 +01:00
Megan Marsh
6c704f7046
Revert "fix template imports"
...
This reverts commit 0e70e0e5a4
2019-11-04 14:29:00 -08:00
Megan Marsh
517834d528
Revert "Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name""
...
This reverts commit 44f91c9afc
2019-11-04 14:28:40 -08:00
Adrien Delorme
819329228a
Change back to make sure all durations are a time.Duration
...
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:
* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
2019-10-31 16:12:07 +01:00
Adrien Delorme
bf3d9841c6
Force durations to be passed a strings
...
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
2019-10-31 11:47:19 +01:00
Adrien Delorme
078ba7c8c3
commit old code generation tool
...
for history
2019-10-15 12:56:42 +02:00
Adrien Delorme
17c069baa5
builder.google:
...
* make CustomerEncryptionKey our own type so that it can be hcl2 generated
* make Account setting unexported so that it doesn't temper with HCL2 generation ( the field is set a bit later after processing )
2019-10-15 12:56:41 +02:00
Megan Marsh
0e70e0e5a4
fix template imports
2019-10-14 13:22:06 -07:00
Megan Marsh
44f91c9afc
Revert "remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name"
...
This reverts commit 0026792d2f
2019-10-14 13:08:15 -07:00
Adrien Delorme
d4600a7716
fix go imports
2019-10-04 11:19:45 +02:00
Megan Marsh
0026792d2f
remove clean_ami_name and clean_image_name; complete the deprecation for these functions in favor of clean_resource_name
2019-10-03 15:49:01 -07:00
Lars Lehtonen
ad860bf1a8
builder: remove deprecated context usage
2019-09-30 11:33:53 -07:00
Megan Marsh
3c14c50aba
Allow user to real oauth token from properly configured Vault instance
2019-09-23 13:26:03 -07:00
Adrien Delorme
3fe9d52e3f
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-09-20 11:15:44 +02:00
Megan Marsh
35357616e0
Merge pull request #8112 from milescrabill/packer-googlecompute-validate-imagename
...
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s
2019-09-17 10:00:33 -07:00
Miles Crabill
2bff60bac8
address review feedback
2019-09-16 13:50:43 -07:00
Miles Crabill
328baced05
add some test cases for image names
2019-09-16 10:18:22 -07:00
Miles Crabill
c11a444f77
googlecompute: fail fast when image name is invalid, replace unusable characters w/ -'s
2019-09-16 10:10:41 -07:00
Megan Marsh
a6e263adb6
don't fall for nil pointer dereference in account file
2019-09-13 16:37:19 -07:00
Adrien Delorme
2db109d55b
Merge branch 'master' into scrape_doc_to_builder_struct_config
2019-08-23 17:37:53 +02:00
Megan Marsh
fcef7e2d85
this timeout regularly flakes on Travis, I suspect because the instances running the tests are brutally underpowered. Increase the fudge factor.
2019-08-21 16:36:42 -07:00
Adrien Delorme
4cb7c30987
Merge remote-tracking branch 'origin/master' into scrape_doc_to_builder_struct_config
2019-08-21 16:44:23 +02:00
Mason, Elliot
ee484f2dd9
Updated public gcp cloud images
2019-07-31 11:38:35 -05:00
Megan Marsh
7c93a5c51e
code changed recently so that sometimes the conf is nil.
2019-07-29 13:19:43 -07:00
Megan Marsh
a87ce366b3
Merge pull request #7835 from hashicorp/google_oauth
...
replace some bespoke google auth code with code from golang's oauth2 …
2019-07-08 09:48:27 -07:00
Megan Marsh
617fd18255
supply complete dummy data for googlecompute tests
2019-07-03 15:58:08 -07:00
Megan Marsh
0dfb3cc56f
replace some bespoke google auth code with code from golang's oauth2 library
2019-07-03 14:27:33 -07:00
Megan Marsh
c03c3f4410
replace duplicate commHost functions with a single communicator helper that checks for ssh_host and does a statebag lookup for a given key
2019-07-03 13:30:29 -07:00
Megan Marsh
eb8c74bf85
allow ssh_host config option to override host logic for all builders
2019-07-02 13:56:28 -07:00
Megan Marsh
ad8a88e366
allow ssh_host to override the host ip gathered from the instance for GCP builder
2019-07-02 13:01:41 -07:00
Lars Lehtonen
Megan Marsh
Adrien Delorme
Miles Crabill
Mason, Elliot