The Azure example uses an inline PowerShell script to wait for sysprep to complete. While waiting, it prints out the current setup state *if the state is **not** complete*, otherwise it breaks and shuts down.
This logging behavior can be confusing because the last message logged says that sysprep is not completed. To clarify things, move the log statement ahead of the "if" check so the result of each polling operation is logged.
Data disk is an important feature for instances and images, this
patch implements the basic functionality of it. More work needs
to be done to make it friendly to users. Docs has pointed out
current limitation.
Also update dependencies because this feature requires new code in
tencentcloud go sdk.
Instance tags are useful, our customer asks us to support it in packer as
well, to enable them to identify the purpose of the instance, even the
instance runs in a very short time.
Tencent Cloud key pair cannot be removed if it is in a image, so
when user doesn't specify any log in method, such as ssh_password,
temporary key pair will be created and used, which eventually will
always fail.
This patch detach temporary key pair before creating image, so in
cleanup step, it can be deleted correctly.
Note that if user specifies a private key pair, we do not detach it,
because user might want to use it when creating new instances from this
image.
Adam Dobrawy
mingsheng.su
Megan Marsh
Li Kexian
Paul Meyer
Etienne Deneuve
Matt Kotsenas
xiaohan.liang
Jesse Mazzella
ZhiQiang Fan
Amrita Dutta
chhaj5236