Fixes the following vet reports:
post-processor/vagrant-cloud/client.go:81: arg resp for printf verb %s of wrong type: *net/http.Response
post-processor/vagrant-cloud/client.go:99: arg resp for printf verb %s of wrong type: *net/http.Response
post-processor/vagrant-cloud/client.go:131: arg resp for printf verb %s of wrong type: *net/http.Response
post-processor/vagrant-cloud/client.go:156: arg resp for printf verb %s of wrong type: *net/http.Response
post-processor/vagrant-cloud/client.go:175: arg resp for printf verb %s of wrong type: *net/http.Response
When a packer json contains an atlas postprocessor, and `packer validate` runned locally
in case of the missing ATLAS_TOKEN env var, the following error message is displayed:
* Error initializing client: authentication failed
It wasn't clear which plugin produced this message, so the amazon-ebs builder was the suspect
Close temporary file created in test before trying to remove it.
Fixes test failure on Windows, which cannot remove the file unless
it has been closed.
A few weeks ago ... the version.number changed from an integer to a
semver based string.
I guess version.number and version.version are equals now. So
version.version can be used.
This commit should fix#1735
I got thrown for a loop since the username is uri-escaped but the password was not.
I got thrown for another couple of loops due to the multiple levels of interpretation involved:
1) JSON syntax requires backslashes to be slash-escaped. Some vCenter deployments use windows domain-style usernames DOMAIN\user
2) the OVFTOOL docs specify that "all special characters" be uri-encoded when part of the user name or password
3) different shell interpretations on windows/linux
I'd say escape both or neither.