Commit Graph
79 Commits
Author SHA1 Message Date
Megan Marsh 645eff58d1 fix fixer deprecated options conflict 2020-10-23 14:00:12 -07:00
Megan Marsh fc619dc977 Merge pull request #9626 from featheredtoast/add-proxmox-vm-clone
builder/proxmox FEATURE: split Proxmox into proxmox-iso and proxmox-clone
2020-10-23 13:36:45 -07:00
Megan Marsh c0ce8a9414 rework fixer deprecation code so we know what plugins they relate to 2020-10-21 15:28:59 -07:00
Jeff Wong 0f12414126 Merge branch 'master' into add-proxmox-vm-clone 2020-10-12 10:48:15 -07:00
Jeff Wong a35eda70d8 Add proxmox fixer 2020-10-11 11:39:24 -07:00
Jeff Wong 93531b3ec5 [proxmox] Adds proxmox fixer and fixer test
Add fixer for proxmox to proxmox-iso. Updated gofmt.
2020-10-08 00:04:43 -07:00
Ricardo Rosales 809f38be3a [azure-chroot] Updating parameter exlude_from_latest to exclude_from_latest (#10034) 2020-10-07 11:08:33 +02:00
Sylvia Moss ce45a1990a Refactor communicator config for Qemu and add SkipNatMapping option (#9307) 2020-06-02 11:56:36 +02:00
Megan Marsh 9ee75bc41c add disk_size, disk_thin_provisioned, and disk_eagerly_scrub to the DeprecatedOptions field. 2020-05-29 09:45:36 -07:00
Megan MarshandWilken Rivera 9842e02aab Update fix/fixer_amazon_temporary_security_group_cidrs.go
Co-authored-by: Wilken Rivera <[email protected]>
2020-05-29 09:40:31 -07:00
Megan Marsh 21e9bef202 update fixer interface to return a list of deprecated options, if any 2020-05-29 09:40:31 -07:00
Megan Marsh ddf223b56b fix fixer 2020-05-28 16:41:00 -07:00
Megan Marsh 1edc931e7f actually run the fixer 2020-05-28 13:14:45 -07:00
Megan Marsh 3ad2f86cc2 fix network card fixer (#9311) 2020-05-28 11:30:21 +02:00
Adrien Delorme 0fa60c68fb Drop the iso_checksum_type & iso_checksum_url fields (#8437)
* Drop the iso_checksum_type & iso_checksum_url fields

In favor of simply using iso_checksum that will know what to do.

* fix after master merge

* Update builder_test.go

* Update builder_test.go

* Update builder_test.go

* Update builder_test.go

* Update builder_test.go

* remove checksum lowercasing tests

* Update builder_test.go

* Update builder_test.go

* better docs

* Update builder_test.go

* even better docs

* Update config.go

* Update builder_test.go

* Update step_create_vmx_test.go

* make generate

* better docs

* fix imports

* up tests

* Update _ISOConfig-required.html.md

* Update builder_test.go

* don't use sha1.Sum("none") as a caching path

* Update builder_test.go

* better docs

* Update iso_config_test.go

remove ISOChecksumType/ISOChecksumURL references

* Update step_download_test.go

* add iso_checksum_url and iso_checksum_type fixers + tests

* add concrete examples of checksum values

* add examples of checksumming from local file

* update go-getter dep

* up deps

* use new go-getter version

* up ESX5Driver.VerifyChecksum: use go-getter's checksumming

* ISOConfig.Prepare: get checksum there in case we need it as a string in ESX5Driver.VerifyChecksum

* Update iso_config.go

* get go-getter from v2 branch

* Update driver_esx5.go

add more comments

* Update driver_esx5.go

* show better error message when the checksum is invalid

* Update builder_test.go

put in a valid checksum to fix tests, checksum is md5("packer")

* Update builder_test.go

test invalid and valid checksum

* more test updating

* fix default md5 string to be a valid md5

* TestChecksumFileNameMixedCaseBug: use 'file:' prefix for file checksumming

* Update iso_config_test.go

* Update iso_config_test.go

* Update builder_test.go

* Update builder_test.go

* Update builder_test.go

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update go.mod

* Update go.mod

* Update CHANGELOG.md
2020-05-28 11:02:09 +02:00
jhawk28 820f353573 (vsphere-iso) remove deprecated network and disk fields (#9149)
* remove deprecated network and disk fields
2020-05-19 10:06:12 -04:00
Adrien Delorme 4ebcbad332 update consul and vault dependencies (#9205)
* update consul and vault dependencies

* update triton sign call accorting to https://github.com/joyent/triton-go/pull/135

* Delete readme.md

* put back github.com/mitchellh/reflectwalk to v1.0.0 and explain why

* fix/fixer_pp_docker_tag_tags.go: simplify deduplication loop and keep seen/stable order
2020-05-11 15:26:01 -04:00
Megan Marsh 16233371e6 fix unrelated broken flaky test 2020-05-08 15:14:29 -07:00
Megan Marsh 7c13cc5744 swap out tag for tags since it's a list
add fixer for docker tag to tags change
2020-05-07 13:24:25 -07:00
Wilken Rivera b9f1b3c8d4 Fix gosimple S1005 linting issue (#8870)
Results before change
```
⇶  golangci-lint run ./... --disable-all --enable=gosimple | grep 1005
fix/fixer_comm_config.go:48:4: S1005: should write `sshHostPortMinRaw := builders["ssh_host_port_min"]` instead of `sshHostPortMinRaw, _ := builders["ssh_host_port_min"]` (gosimple)
fix/fixer_comm_config.go:64:4: S1005: should write `sshHostPortMaxRaw := builders["ssh_host_port_max"]` instead of `sshHostPortMaxRaw, _ := builders["ssh_host_port_max"]` (gosimple)
fix/fixer_comm_config.go:81:4: S1005: should write `sshSkipNatMappingRaw := builders["ssh_skip_nat_mapping"]` instead of `sshSkipNatMappingRaw, _ := builders["ssh_skip_nat_mapping"]` (gosimple)
packer/artifact_mock.go:47:2: S1005: should write `value := a.StateValues[name]` instead of `value, _ := a.StateValues[name]` (gosimple)
packer/artifact_test.go:31:2: S1005: should write `value := a.state[name]` instead of `value, _ := a.state[name]` (gosimple)
```

Results after change
```
```
2020-03-11 10:30:08 +01:00
Wilken Rivera 9ec8b67392 Add golangci-lint to project (#8686)
* Add golangci-lint as linting tool

* Disable failing staticchecks to start; GitHub issue to handle coming soon

* Run `goimports -w` to repair all source files that have improperly
formatted imports

* makefile: Add ci-lint target to run on travis

This change adds a new make target for running golangci-lint on newly
added Go files only. This target is expected to run during Packer ci builds.

* .github/contributing: Add code linting instructions

* travis: Update job configuration to run parallel builds
2020-02-14 11:42:29 -05:00
nywilken d2a9e6b32e Format code with gofmt -s -w 2020-01-28 16:52:50 -05:00
Sylvia Moss d6a351b173 Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
Ricard Clau b2578ee0f9 Fix typo in Synopsis for galaxycommand fixer (#8573) 2020-01-07 11:05:35 +01:00
Kevin Gunn a7d32afe4e removed escape character check, updated synopsis string, change type to 'ansbile-local' only 2019-11-27 20:27:24 -05:00
Kevin Gunn 70aa0516de reset ansible-local documentation to include galaxy_command
fix spacing in fixer.go
2019-11-26 01:05:33 -05:00
Kevin Gunn 28d1037864 change galaxycommand to galaxy_command and add fixer 2019-11-26 00:57:17 -05:00
Victor Yap 9a961bb079 Implement fixer to convert qemu disk size type to string 2019-11-20 10:41:08 -06:00
Brendan Devenney 2b16b5cae4 Move fixer test to fix package
Signed-off-by: Brendan Devenney <[email protected]>
2019-07-24 18:04:17 +01:00
Brendan Devenney 75d8d7fce5 Update and futureproof fix command usage
* Dynamically generate the fixer documentation (in order) from
FixerOrder
* Update fixers which used linebreaks in their Synopsis

Signed-off-by: Brendan Devenney <[email protected]>
2019-07-24 17:18:07 +01:00