Megan Marsh
de7106c36b
Merge pull request #7696 from hashicorp/go_generate_from_makefile
...
run `go generate ./...` from makefile & CI test that it generates no diff
2019-06-03 15:01:21 -07:00
Megan Marsh
4bf75ac0f3
fix null file descriptor error
2019-05-30 15:34:18 -05:00
Adrien Delorme
abd6eda6c9
generate execution policy from makefile
...
* make generate now generates on `./...` instead of `.`
2019-05-27 14:52:04 +02:00
Adrien Delorme
478f80af83
remove unused func
2019-05-23 17:33:46 +02:00
Adrien Delorme
7005958155
execution policy: make everything more idiomatic
...
* make possible execution policy values lowercase
* prefix execution policies possibilities
2019-05-23 17:12:32 +02:00
Adrien Delorme
e62aba3788
allow to set ExecutionPolicy to none for powershell provisioner
...
this has the effect to not wrap the command, which will allow to know the exit status of a command in docker
2019-05-23 16:42:44 +02:00
Adrien Delorme
e96409954a
add execution policy type and use it to default the powershell cmd
2019-05-23 16:12:05 +02:00
Paul Meyer
814665fddd
Check error returned from retry.Config.Run()
2019-05-17 22:28:34 +00:00
Paul Meyer
ec14ab4875
Add unit test to find issue #7655
2019-05-17 22:27:19 +00:00
Adrien Delorme
d72040f4fa
move retry code into the common/retry pkg and make retry context aware
2019-04-09 17:46:38 +02:00
Adrien Delorme
f555e7a9f2
allow a provisioner to timeout
...
* I had to contextualise Communicator.Start and RemoteCmd.StartWithUi
NOTE: Communicator.Start starts a RemoteCmd but RemoteCmd.StartWithUi will run the cmd and wait for a return, so I renamed StartWithUi to RunWithUi so that the intent is clearer.
Ideally in the future RunWithUi will be named back to StartWithUi and the exit status or wait funcs of the command will allow to wait for a return. If you do so please read carrefully https://golang.org/pkg/os/exec/#Cmd.Stdout to avoid a deadlock
* cmd.ExitStatus to cmd.ExitStatus() is now blocking to avoid race conditions
* also had to simplify StartWithUi
2019-04-08 20:09:21 +02:00
Adrien Delorme
c7ce4d598e
change Provisioner to be passed a context for cancellation
2019-04-03 15:55:54 +02:00
Adrien Delorme
a77ce59e36
Update provisioner_test.go
...
remove unecessary test
2019-03-14 12:48:21 +01:00
Adrien Delorme
72e5ae9ddc
use ValidExitCode in provisioners windows-shell, powershell and shell
2019-03-14 12:47:22 +01:00
Adrien Delorme
30a65c858a
regroup shell provisioner params into a common struct
2019-03-14 11:57:54 +01:00
Adrien Delorme
9f7b4ffc17
Merge branch 'master' into pr/6950
2019-01-09 10:11:18 +01:00
Megan Marsh
70c6fcb824
Merge pull request #7078 from aspectcapital/issue-5478
...
Elevated support for puppet-* & chef-client provisioners
2018-12-14 19:06:46 -08:00
Adrien Delorme and Matthew Patton
b7222d1f56
Add tmp package that offers Dir & File funcs
...
this regroups the calls of tmp func calls into one package.
the tmp pkg allows to store tmp files under a common directory for easier managment
Squashed commit of the following:
commit 74b674c015
Merge: fc94b5714 66001525d
Author: Matthew Patton <[email protected] >
Date: Fri Nov 2 02:02:38 2018 -0400
Merge branch 'remove_TMPDIR_docs' of github.com:tb3088/packer into remove_TMPDIR_docs
commit fc94b57142
Author: Matthew Patton <[email protected] >
Date: Fri Nov 2 01:42:38 2018 -0400
update tests to honor configured temporary directory
commit 5a562359f4
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 18:52:38 2018 -0400
sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.
commit 9d5a4a0935
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 15:39:46 2018 -0400
insert URL to GoLang API for os.TempDir()
commit fbae4c2e05
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 07:41:29 2018 -0400
revise documentation to match code
commit 3590fae8bd
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 07:21:59 2018 -0400
refacter config_file. replace all hard-coded os.TempDir with wrapper
commit d5c5306a97
Author: Matthew Patton <[email protected] >
Date: Wed Oct 31 20:11:36 2018 -0400
close massive file overwrite hole with TempDir
commit 0a72297da8
Author: Matthew Patton <[email protected] >
Date: Wed Oct 31 01:06:00 2018 -0400
adjust var declaration scope
commit 20f68228b6
Author: Matthew Patton <[email protected] >
Date: Wed Oct 31 00:54:35 2018 -0400
use mktemp() equivalent to create temporary directory
commit c73ebe3d83
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 20:40:58 2018 -0400
remove extraneous variable declaration, fix FOR loop
commit 63549b8bd7
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 19:30:44 2018 -0400
match styistic convension with rest of docs
commit 9761010749
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 19:08:39 2018 -0400
revert dangling config file change
commit 95159afbc0
Author: Matthew Patton <[email protected] >
Date: Fri Dec 29 23:53:43 2017 -0500
replace invalid TMPDIR variable wth PACKER_TMP_DIR.
update ConfigTmpDir() to try common temporary paths first and
only write to configDir() as a last resort.
commit 66001525d7
Author: Matthew Patton <[email protected] >
Date: Fri Nov 2 01:42:38 2018 -0400
update tests to honor configured temporary directory
commit e9b6adefea
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 18:52:38 2018 -0400
sync straggler to refactor. implement tests at packer/configfile instead of buried in docker.
commit 852113ed07
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 15:39:46 2018 -0400
insert URL to GoLang API for os.TempDir()
commit 54add38d1d
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 07:41:29 2018 -0400
revise documentation to match code
commit 6b5b8f6d4e
Author: Matthew Patton <[email protected] >
Date: Thu Nov 1 07:21:59 2018 -0400
refacter config_file. replace all hard-coded os.TempDir with wrapper
commit c22092c601
Author: Matthew Patton <[email protected] >
Date: Wed Oct 31 20:11:36 2018 -0400
close massive file overwrite hole with TempDir
commit 7a73045091
Author: Matthew Patton <[email protected] >
Date: Wed Oct 31 01:06:00 2018 -0400
adjust var declaration scope
commit 0f2933adb6
Author: Matthew Patton <[email protected] >
Date: Wed Oct 31 00:54:35 2018 -0400
use mktemp() equivalent to create temporary directory
commit d74839ede0
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 20:40:58 2018 -0400
remove extraneous variable declaration, fix FOR loop
commit eb65416619
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 19:30:44 2018 -0400
match styistic convension with rest of docs
commit acaa2b31ed
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 19:08:39 2018 -0400
revert dangling config file change
commit e573fde668
Author: Matthew Patton <[email protected] >
Date: Fri Dec 29 23:53:43 2017 -0500
replace invalid TMPDIR variable wth PACKER_TMP_DIR.
update ConfigTmpDir() to try common temporary paths first and
only write to configDir() as a last resort.
commit 39a9874afc
Merge: 8a413cfe8 3315812c2
Author: Matthew Patton <[email protected] >
Date: Tue Oct 30 18:19:26 2018 -0400
Merge branch 'master' of https://github.com/hashicorp/packer into prestine
commit 8a413cfe83
Merge: e07491de5 4e14710a6
Author: Matthew Patton <[email protected] >
Date: Mon Oct 1 20:18:10 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit e07491de59
Merge: 42610a35d a1fa35dff
Author: Matthew Patton <[email protected] >
Date: Tue Aug 21 13:26:19 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 42610a35d5
Merge: 5298142da 0d63cf7bc
Author: Matthew Patton <[email protected] >
Date: Tue Jun 19 22:45:05 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 5298142da6
Merge: 7bb110bc7 9d9736552
Author: Matthew Patton <[email protected] >
Date: Mon Jun 11 15:10:09 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 7bb110bc74
Merge: a61c869ca 6189d66e7
Author: Matthew Patton <[email protected] >
Date: Wed May 9 23:41:22 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit a61c869ca7
Merge: 098101dd9 4be5f072c
Author: Matthew Patton <[email protected] >
Date: Fri May 4 10:13:04 2018 -0400
Merge remote-tracking branch 'upstream/master' into prestine
commit 098101dd99
Merge: fefaf0fa6 554b2b4a5
Author: Matthew Patton <[email protected] >
Date: Tue May 1 20:52:30 2018 -0400
Merge branch 'EOL-handling' into prestine
Co-Authored-By: Matthew Patton <[email protected] >
2018-12-12 16:35:57 +01:00
Matt Dainty
19bd28cd72
Fix/add tests
2018-12-07 16:23:03 +00:00
Matt Dainty
2e4b00f59d
Refactor powershell provisioner
...
Use the common elevated code instead.
2018-12-07 15:30:50 +00:00
Megan Marsh
e69391f28b
save users some bash scripting by exposing IP and port separately as well as together
2018-12-06 09:29:07 -08:00
Matt Dainty
412119c27e
Fix powershell provisioner tests
2018-11-09 14:26:21 +00:00
Matt Dainty
3b519acebc
Allow Powershell provisioner to use service accounts
...
Fixes #6104
2018-11-08 11:48:27 +00:00
Megan Marsh
1d1729a5ff
fix powershell tests to use new command
2018-10-12 09:54:27 -07:00
Megan Marsh
a81d18cdab
explicitly use set-variable to work around a bug some users saw where the command invocation would vail
2018-10-12 09:15:12 -07:00
Megan Marsh
a0edaf6c46
Going to revert this change for now, becuase of potential issues that arise from calling Prepare() twice
...
Revert "use statebag instead of SetSharedState for winRM password"
This reverts commit b35acbd879 .
2018-09-10 16:48:42 -07:00
Megan Marsh
b35acbd879
use statebag instead of SetSharedState for winRM password
2018-08-24 13:51:16 -07:00
Megan Marsh
ff6a039d5b
replace scrubconfig with packer.LogSecretFilter.Set
...
filter winrm password from logs
Add new root-level packer template option, sensitive-variables, to tell us what user variables to mark sensitive.
2018-08-20 15:35:55 -07:00
DanHam
485d565e32
Ensure comments are easily readable in a standard terminal
2018-06-15 00:49:15 +01:00
DanHam
e0bcba4913
Make the upload of env vars retryable in case of restarts
2018-06-15 00:09:50 +01:00
DanHam
b738f41efa
Remove tmp files created by provisioner/powershell tests
2018-04-30 20:38:03 +01:00
DanHam
b9ab2c8048
Remove script containing PowerShell inline commands from local tmp when done
2018-04-26 00:32:52 +01:00
DanHam
ccf687dac6
Fix tests
2018-04-24 11:10:35 +01:00
DanHam
5419375413
Change to CMD % style path is no longer required
2018-04-24 11:10:35 +01:00
DanHam
5b652316d9
Dollar's in env vars used in paths may cause problems for ssh
...
* Dollars are interpreted by *nix shells so paths using env vars such as
${env:SYSTEMROOT} will cause issues
2018-04-24 11:10:35 +01:00
DanHam
4e7feea184
Allow users to specify the location that the env vars file is uploaded to
...
Previously the location the file was uploaded to was set internally and
used ${env:SYSTEMROOT}/Temp as the destination folder.
By default, in order to inject the required environment variables, the file
is 'dot sourced' by the 'execute_command' using the {{ .Vars }} variable.
Unfortunately the inclusion of the dollar in the path caused issues for
users connecting over ssh as the (typically bash) shell running the execute
command would try and interpret the dollar sign.
The change allows users to specify the location the file is uploaded to,
thereby allowing the user to specify a custom 'execute_command' that
escapes any dollar signs that could be present in the path.
If not set the upload path now defaults to using C:/Windows/Temp as the
upload folder.
2018-04-24 11:09:55 +01:00
Megan Marsh
3afb243f11
use build name to ensure that winrm password and other shared state is not overwritten if two builders need the password in the same packer run.
2018-04-16 13:41:17 -07:00
DanHam
ef4817d644
Fix vertical spacing
2018-03-23 14:01:30 +00:00
DanHam
34db6c4ab1
Remove temp debugging output
2018-03-23 12:45:49 +00:00
Megan Marsh
4e321b2dfa
don't need to use a receiver with this function
2018-03-22 15:55:24 -07:00
Megan Marsh
ce1ab1f021
fix winrm password
2018-03-15 09:44:22 -07:00
Megan Marsh
559719020c
use {{.WinRMPassword}} instead of some other weirdness
2018-03-14 17:19:17 -07:00
Megan Marsh
d689e6b4d3
allow users of AWS to use the dynamically-generated admin password which we use as the winRM password as an elevated password in the Powershell provisioner, as well as an environment variable in same provisoner.
2018-03-14 15:58:12 -07:00
Josh Soref
24b4c36fc9
spelling: function
2018-03-13 07:52:02 +00:00
Josh Soref
04d6bfc696
spelling: environment
2018-03-13 07:41:21 +00:00
Megan Marsh
f3a538db46
fix tests
2018-03-09 13:36:47 -08:00
Megan Marsh
3faf73b5f3
change backslashes to forward slashes in powershell provisioner; was breaking with cygwin
2018-03-09 09:29:29 -08:00
DanHam
2d830d5d43
Auto escape chars special to PowerShell in user supplied data
2018-02-08 12:03:19 +00:00
DanHam
aaf7102b9a
Tests for escape of chars special to PowerShell in user supplied data
2018-02-08 12:03:18 +00:00
DanHam
a7b118ed94
Fix tests post changes. Add test for upload func.
2018-02-08 12:03:18 +00:00