iSharkFly-Docs/Packer-Cn
2
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-10-24 07:02:14 -04:00
Code Issues Packages Projects Releases Wiki Activity
14,490 Commits 348 Branches 148 Tags
ebb161ae41ad46868d95410d23e89a88c8e0ee49
Commit Graph
60 Commits
Author SHA1 Message Date
Wilken Rivera b9f1b3c8d4 Fix gosimple S1005 linting issue (#8870) 
Results before change
```
⇶  golangci-lint run ./... --disable-all --enable=gosimple | grep 1005
fix/fixer_comm_config.go:48:4: S1005: should write `sshHostPortMinRaw := builders["ssh_host_port_min"]` instead of `sshHostPortMinRaw, _ := builders["ssh_host_port_min"]` (gosimple)
fix/fixer_comm_config.go:64:4: S1005: should write `sshHostPortMaxRaw := builders["ssh_host_port_max"]` instead of `sshHostPortMaxRaw, _ := builders["ssh_host_port_max"]` (gosimple)
fix/fixer_comm_config.go:81:4: S1005: should write `sshSkipNatMappingRaw := builders["ssh_skip_nat_mapping"]` instead of `sshSkipNatMappingRaw, _ := builders["ssh_skip_nat_mapping"]` (gosimple)
packer/artifact_mock.go:47:2: S1005: should write `value := a.StateValues[name]` instead of `value, _ := a.StateValues[name]` (gosimple)
packer/artifact_test.go:31:2: S1005: should write `value := a.state[name]` instead of `value, _ := a.state[name]` (gosimple)
```

Results after change
```
```
 2020-03-11 10:30:08 +01:00
Wilken Rivera 9ec8b67392 Add golangci-lint to project (#8686) 
* Add golangci-lint as linting tool

* Disable failing staticchecks to start; GitHub issue to handle coming soon

* Run `goimports -w` to repair all source files that have improperly
formatted imports

* makefile: Add ci-lint target to run on travis

This change adds a new make target for running golangci-lint on newly
added Go files only. This target is expected to run during Packer ci builds.

* .github/contributing: Add code linting instructions

* travis: Update job configuration to run parallel builds
 2020-02-14 11:42:29 -05:00
nywilken d2a9e6b32e Format code with gofmt -s -w 2020-01-28 16:52:50 -05:00
Sylvia Moss d6a351b173 Rename communicator config variables and remove deprecated code (#8584) 2020-01-09 08:37:30 -08:00
Ricard Clau b2578ee0f9 Fix typo in Synopsis for galaxycommand fixer (#8573) 2020-01-07 11:05:35 +01:00
Kevin Gunn a7d32afe4e removed escape character check, updated synopsis string, change type to 'ansbile-local' only 2019-11-27 20:27:24 -05:00
Kevin Gunn 70aa0516de reset ansible-local documentation to include galaxy_command 
fix spacing in fixer.go
 2019-11-26 01:05:33 -05:00
Kevin Gunn 28d1037864 change galaxycommand to galaxy_command and add fixer 2019-11-26 00:57:17 -05:00
Victor Yap 9a961bb079 Implement fixer to convert qemu disk size type to string 2019-11-20 10:41:08 -06:00
Brendan Devenney 2b16b5cae4 Move fixer test to fix package 
Signed-off-by: Brendan Devenney <[email protected]>
 2019-07-24 18:04:17 +01:00
Brendan Devenney 75d8d7fce5 Update and futureproof fix command usage 
* Dynamically generate the fixer documentation (in order) from
FixerOrder
* Update fixers which used linebreaks in their Synopsis

Signed-off-by: Brendan Devenney <[email protected]>
 2019-07-24 17:18:07 +01:00
Brendan Devenney 556492fb0d Add fixers erroneously removed by e8f04c3 
Signed-off-by: Brendan Devenney <[email protected]>
 2019-07-24 16:28:08 +01:00
Megan Marsh c979cad579 add a fixer and update docs for spot_price_auto_product 2019-07-01 13:01:41 -07:00
Megan Marsh 3e72e65a6c Merge pull request #7456 from hashicorp/do_5770 
introduce the clean_resource_name to clean image/var names
 2019-04-05 09:12:20 -07:00
Adrien Delorme a08d9dec9b add a Fixer that replaces the "clean_(image|ami)_name" template calls with "clean_resource_name" 2019-04-05 15:30:41 +02:00
Megan Marsh 17c14770a7 Merge pull request #7450 from AkshatM/rename_security_group_cidr_to_security_group_cidrs 
Rename and change `temporary_security_group_source_cidr`  to accept a list of strings (for Amazon builders).
 2019-04-02 10:54:31 -07:00
Akshat Mahajan 22504200cc Fix typographical errors in the fixers 2019-04-01 23:42:31 -07:00
Akshat Mahajan f07e4214cc Addresses issues #5384, #5494: Rename and change temporary_security_group_source_cidr 
to accept a list of strings (for Amazon builders).

Per this change, `temporary_security_group_source_cidr` in the configuration:

1. Will be renamed to `temporary_security_group_source_cidrs`.
2. Will accept a list of CIDRs.
3. Will have its documentation updated to reflect this change.
4. Will have a fixer attached for newer templates to avail of.
 2019-03-30 15:47:03 -07:00
Megan Marsh 2b57b10284 write fixer 2019-03-29 15:30:00 -07:00
Megan Marsh 424a6a3a7e Merge pull request #6983 from hashicorp/revert-6979-revert-6925-organization_renaming 
DONT MERGE YET: Revert "Revert "Rename attribute api_access_key to organization_id""
 2019-02-28 15:30:25 -08:00
Don Kuntz 279fb7a632 gofix 2019-02-25 14:41:26 -06:00
Don Kuntz b0589c9643 Append underlying error to output when FixerAmazonPrivateIP cannot parse the value of ssh_private_ip 2019-02-25 14:20:14 -06:00
Don Kuntz 04de86d211 Add test for non-boolean values in ssh_private_ip for FixerAmazonPrivateIP 2019-02-25 14:19:13 -06:00
Don Kuntz e4faa98b6f cleanup: remove continue statement after a return statement, because it's unreachable 2019-02-22 10:38:27 -06:00
Don Kuntz e251adb37e Make the amazon-private-ip fixer errors more visible 
At present, when using the packer fix command on a template that has
"ssh_private_ip" set to anything but a boolean value, the fixer will
fail, and appear to fail silently, simply returning a non-zero status
code without any message.

To determine what happened, users have to know to set PACKER_LOG=1 to
make the log message visible.

So far as I can tell, this is the only instance of log.Fatalf being
called, and based on the surrounding code the better solution would be
to return an error, which will then be visible to users of packer fix
without having to look in the logs.
 2019-02-22 10:26:55 -06:00
Megan Marsh be0959004a Revert "Revert "Rename attribute api_access_key to organization_id"" 2018-11-09 08:47:22 -08:00
Megan Marsh c1c929164f Revert "Rename attribute api_access_key to organization_id" 2018-11-08 16:34:23 -08:00
Rémy Léone e54d2e3591 Rename attribute api_access_key to organization 2018-11-08 13:45:32 +01:00
Matthew Hooker 8a7d43dd44 bug fix and add test 2018-09-06 12:19:31 -07:00
Matthew Hooker 42910a5f8c fix docker email fixer 
Fixing post-processors requires some smart parsing of the template.
Let's turn that logic into a helper and use it everywhere.
 2018-09-06 12:19:31 -07:00