Lars Lehtonen
a3ca0bc2aa
packer/rpc: remove unused cancelCalled field from testBuild{}
2019-11-04 12:59:55 -08:00
Lars Lehtonen
699614b500
packer/rpc: fix dropped error
2019-11-04 12:58:16 -08:00
Lars Lehtonen
67afbe6fb7
packer: remove bool constant comparisons
2019-11-04 12:54:52 -08:00
Lars Lehtonen
703f071b4a
packer: remove unused test variable
2019-11-04 12:53:16 -08:00
Lars Lehtonen
a709867dee
packer: remove unused testComponentFinder()
2019-11-04 12:50:58 -08:00
Adrien Delorme
819329228a
Change back to make sure all durations are a time.Duration
...
It is simply the best/simplest solution and trying to prevent users from passing and integer here would be like opening a can of worms. Because:
* we cannot make mapstructure validate our duration string ( with an UnmarshalJSON func etc.)
* we cannot make mapstructure spit a string instead of a duration and packer will decode-encode-decode config.
* the hcl2 generated code asks for a string, so this will be enforced by default.
2019-10-31 16:12:07 +01:00
Adrien Delorme
bf3d9841c6
Force durations to be passed a strings
...
Before this commit it was possible to set a duration using an integer or a float. Go's time.Duration is an int64 internally an mapstructure will take advantage of this and load the number as a int64 but `1` means one ns which is unexpected/confusing. To avoid confusion and enforce readability this forces users to pass a string with a unit for a duration; ex "56s".
2019-10-31 11:47:19 +01:00
Adrien Delorme
a8b2918d0e
remote duplicate gob.Register(new(map[string]interface{}))
...
otherwise this panics
2019-10-15 12:56:42 +02:00
Megan Marsh
0683bc409b
add test for error-cleanup provisioner, and fix tests by fixing null builder to use an actual none communicator instead of skipping communicator generation altogether
2019-09-25 13:39:09 -07:00
Megan Marsh
5bd8fee708
Creates a final "cleanup" provisioner to run if an error occurs during a provisioning step, allowing users to perform any custom cleanup tasks that must happen on the VM before the VM is shut down and destroyed.
2019-09-24 16:08:15 -07:00
Adrien Delorme
3b8f3c5a8b
remove any reference to Push
2019-09-16 16:38:17 +02:00
Lars Lehtonen
f62bc25f18
packer/rpc: Fix tests that swallowed errors in goroutines
2019-09-11 05:22:01 -07:00
Megan Marsh
a82a3ccaa6
need to scrub sensitive variables first, to make sure we don't fail for comma-containing sensitive info
2019-08-15 16:16:11 -07:00
Megan Marsh
ce0f11a651
Merge pull request #7912 from hashicorp/set_config_dir
...
Set config dir
2019-08-13 16:33:00 -07:00
Megan Marsh
5d4d5a21bf
check env for a PACKER_CONFIG_DIR before defaulting to homedir for config
2019-07-25 13:06:41 -07:00
Christian Muehlhaeuser
216afbaa8b
Fixed various typos
...
Just a bunch of nit-picky typo fixes.
2019-07-25 06:49:51 +02:00
Megan Marsh
e54b1cedd9
text/template turns out to swallow custom error types.
2019-07-08 15:39:46 -07:00
Megan Marsh
2bbc3d50d7
better error handling when using interpolate funcs; don't swallow func errors
2019-07-08 13:49:14 -07:00
Adrien Delorme
c9a22b6380
Merge pull request #7745 from hashicorp/investigate_crash
...
small cleanups
2019-06-14 10:09:32 +02:00
Megan Marsh
88e5a21170
make sure machine readable logs print what's come through the UI into the logs
2019-06-13 10:51:44 -07:00
Megan Marsh
a907adb4ab
Merge pull request #7743 from hashicorp/fix_7728
...
filter machine readable UI
2019-06-12 13:00:26 -07:00
Megan Marsh
df977926ba
filter machine readable UI
2019-06-12 09:50:27 -07:00
Adrien Delorme
f097deab3b
Merge pull request #7739 from hashicorp/fix_7728
...
apply logSecretFilter to output from ui.Say
2019-06-12 11:01:25 +02:00
Adrien Delorme
2eef6a1492
Merge pull request #7726 from hashicorp/packer-interpolate
...
Packer console
2019-06-12 11:00:11 +02:00
Megan Marsh
1e5866bd2a
apply logSecretFilter to output from ui.Say
2019-06-11 14:04:36 -07:00
Adrien Delorme
ddb4d77dc8
Update packer/core.go
...
remove commented log line
2019-06-11 11:09:22 +02:00
Megan Marsh
ca99cbd2d2
remove loglines
2019-06-10 11:34:57 -07:00
Megan Marsh
1a9adc29b3
fixing interpolation
...
fix sensitive_vars test which never worked but somehow was passing before this change.
2019-06-10 11:30:52 -07:00
Megan Marsh
b8ac1a800d
implement a packer console analogous to the terraform console
2019-06-05 16:35:22 -07:00
Adrien Delorme
ce15617d05
TestPausedProvisionerProvision_waits: don't fail when we spend too much time.
2019-05-24 18:21:53 +02:00
Lars Lehtonen
Adrien Delorme
Megan Marsh
Christian Muehlhaeuser
Adrien Delorme