mirror of
https://github.com/hashicorp/packer.git
synced 2026-09-25 01:04:00 -04:00
Wilken Rivera
b6f02d3f77
When obtaining image metadata for a HCP Packer build, Packer core will use mapstructure to decode the image metadata and validate that is has all of the required data set. Before this change Packer core would fail if there is extra metadata fields in the image metadata that Packer is not aware. This change removes the restriction of erroring on unused metadata fields. Packer should only care about the fields it knows and ignore the rest. In the future, we will add new fields to the SDK but plugins may begin sending that data sooner.
87 lines
2.9 KiB
Go
87 lines
2.9 KiB
Go
package packer
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"log"
|
|
|
|
"github.com/hashicorp/hcl/v2/hcldec"
|
|
"github.com/hashicorp/hcp-sdk-go/clients/cloud-packer-service/preview/2021-04-30/models"
|
|
packersdk "github.com/hashicorp/packer-plugin-sdk/packer"
|
|
registryimage "github.com/hashicorp/packer-plugin-sdk/packer/registry/image"
|
|
packerregistry "github.com/hashicorp/packer/internal/registry"
|
|
"github.com/mitchellh/mapstructure"
|
|
)
|
|
|
|
type RegistryPostProcessor struct {
|
|
BuilderType string
|
|
ArtifactMetadataPublisher *packerregistry.Bucket
|
|
packersdk.PostProcessor
|
|
}
|
|
|
|
func (p *RegistryPostProcessor) ConfigSpec() hcldec.ObjectSpec {
|
|
if p.PostProcessor == nil {
|
|
return nil
|
|
}
|
|
|
|
return p.PostProcessor.ConfigSpec()
|
|
}
|
|
|
|
func (p *RegistryPostProcessor) Configure(raws ...interface{}) error {
|
|
if p.PostProcessor == nil {
|
|
return nil
|
|
}
|
|
|
|
return p.PostProcessor.Configure(raws...)
|
|
}
|
|
|
|
func (p *RegistryPostProcessor) PostProcess(ctx context.Context, ui packersdk.Ui, source packersdk.Artifact) (packersdk.Artifact, bool, bool, error) {
|
|
// This is a bit of a hack for now to denote that this pp should just update the state of a build in the Packer registry.
|
|
// TODO create an actual post-processor that we can embed here that will do the updating and printing.
|
|
if p.PostProcessor == nil {
|
|
if parErr := p.ArtifactMetadataPublisher.UpdateBuildStatus(ctx, p.BuilderType, models.HashicorpCloudPackerBuildStatusDONE); parErr != nil {
|
|
err := fmt.Errorf("[TRACE] failed to update Packer registry with image artifacts for %q: %s", p.BuilderType, parErr)
|
|
return nil, false, true, err
|
|
}
|
|
|
|
r := &RegistryArtifact{
|
|
BuildName: p.BuilderType,
|
|
BucketSlug: p.ArtifactMetadataPublisher.Slug,
|
|
IterationID: p.ArtifactMetadataPublisher.Iteration.ID,
|
|
}
|
|
|
|
return r, true, false, nil
|
|
}
|
|
|
|
source, keep, override, err := p.PostProcessor.PostProcess(ctx, ui, source)
|
|
if err != nil {
|
|
if parErr := p.ArtifactMetadataPublisher.UpdateBuildStatus(ctx, p.BuilderType, models.HashicorpCloudPackerBuildStatusFAILED); parErr != nil {
|
|
log.Printf("[TRACE] failed to update Packer registry with image artifacts for %q: %s", p.BuilderType, parErr)
|
|
}
|
|
return source, false, false, err
|
|
}
|
|
|
|
var images []registryimage.Image
|
|
decoder, err := mapstructure.NewDecoder(&mapstructure.DecoderConfig{
|
|
Result: &images,
|
|
WeaklyTypedInput: true,
|
|
ErrorUnused: false,
|
|
})
|
|
if err != nil {
|
|
return source, false, false, fmt.Errorf("failed to create decoder for HCP Packer registry image: %w", err)
|
|
}
|
|
|
|
state := source.State(registryimage.ArtifactStateURI)
|
|
err = decoder.Decode(state)
|
|
if err != nil {
|
|
return source, false, false, fmt.Errorf("failed to obtain HCP Packer registry image from post-processor artifact: %w", err)
|
|
}
|
|
err = p.ArtifactMetadataPublisher.UpdateImageForBuild(p.BuilderType, images...)
|
|
|
|
if err != nil {
|
|
return source, keep, override, fmt.Errorf("[TRACE] failed to add image artifact for %q: %s", p.BuilderType, err)
|
|
}
|
|
|
|
return source, keep, override, nil
|
|
}
|