mirror of
https://github.com/hashicorp/packer.git
synced 2026-09-18 22:11:39 -04:00
* hcl2template: pass user variable values to plugins as packer_user_variables (#13686) HCL2 builds do not send the packer_user_variables config key to the builder, provisioner and post-processor plugins. Legacy JSON builds send this key (through CoreBuild.packerConfig()). Without the key, the plugin SDK keeps interpolate.Context.UserVariables nil. Then the template function {{ user "name" }} fails with 'error calling user: test'. This failure occurs in each string that a plugin interpolates at run time, for example the contents of the vagrant post-processor's vagrantfile_template. Add the function PackerConfig.userVariableValues(). This function converts the input variable values to strings, equivalent to the legacy user variables. The core sends the map at each plugin handoff point: builder, provisioner, post-processor, and enforced provisioner. The map does not contain the sensitive variables. A sensitive value goes to a plugin only if the template refers to it explicitly. The map does not contain values that are not primitive (lists, maps, objects). Legacy user variables were always strings. Co-authored-by: Claude Fable 5 <[email protected]> * Dependency upgrade (#13689) * go.mod version upgrade * actions upgrade * plugin-getter: install plugins from non-GitHub HTTP sources (#13691) Packer can only install plugins from github.com, with releases.hashicorp.com consulted first for HashiCorp-published plugins. This has been a long-standing gap for air-gapped and policy-restricted environments (#11164): the source address parser already accepts any hostname, but both existing getters reject non-github.com sources at install time. Add a remote plugin getter that installs plugins from the host named in a required_plugins source address. The host serves the directory structure of releases.hashicorp.com under the source's path: an index.json listing versions, and per version a SHA256SUMS file, the zips it lists, and - when the zip names carry no plugin protocol version - the version's manifest.json. A plugin published on releases.hashicorp.com is therefore mirrored as a verbatim copy of its tree, with every checksum file and signature upstream-authored. A plugin published as GitHub release assets is mirrored by copying each release's assets into a version directory, renaming their SHA256SUMS file to the unprefixed convention with content unchanged, and writing an index.json listing the versions. Both kinds of content can be served side by side by one host. Getter selection happens per source address: github.com sources keep the release and github getters unchanged, while any other host is served by the remote getter over HTTPS. Sources with three or more components are supported, up to the existing 16-component limit, so nested artifact-repository paths and hosts that embed the upstream origin in their path all resolve. Version discovery, constraint solving, checksum verification, and the binary naming rules match the existing getters. The installed filename is rebuilt from validated checksum-file fields and never taken from the server's response, checksum entries matching neither known naming shape are rejected rather than guessed at, and nothing the remote metadata supplies is used to fetch from another origin or path. index.json parsing is covered by fixtures captured from the live releases API, so a format change there fails tests rather than user installs. Closes #11164 * fix: update link to CONTRIBUTING.md for consistency with main branch * Merge pull request #13701 from hashicorp/sanya-hashicorp/fix-vuln Module Dependency update * build(deps): bump google.golang.org/grpc (#13704) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.83.1 to 1.83.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.83.1...v1.83.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.83.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [COMPLIANCE] Add/Update Copyright Headers (#13699) * [COMPLIANCE] Add/Update Copyright Headers * make generate update * make generate --------- Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com> Co-authored-by: sanya <[email protected]> Co-authored-by: Sanya <[email protected]> * Packer release 1.16.1 (#13705) * Module upgrade (#13707) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Erik Berg <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]> Co-authored-by: Benjamin Holmes <[email protected]> Co-authored-by: elomito <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
180 lines
3.9 KiB
Go
180 lines
3.9 KiB
Go
// Copyright IBM Corp. 2024, 2026
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package command
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"log"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/hashicorp/packer-plugin-sdk/template"
|
|
"github.com/hashicorp/packer/fix"
|
|
|
|
"github.com/posener/complete"
|
|
)
|
|
|
|
type FixCommand struct {
|
|
Meta
|
|
}
|
|
|
|
func (c *FixCommand) Run(args []string) int {
|
|
ctx, cleanup := handleTermInterrupt(c.Ui)
|
|
defer cleanup()
|
|
|
|
cfg, ret := c.ParseArgs(args)
|
|
if ret != 0 {
|
|
return ret
|
|
}
|
|
|
|
return c.RunContext(ctx, cfg)
|
|
}
|
|
|
|
func (c *FixCommand) ParseArgs(args []string) (*FixArgs, int) {
|
|
var cfg FixArgs
|
|
flags := c.Meta.FlagSet("fix")
|
|
flags.Usage = func() { c.Ui.Say(c.Help()) }
|
|
cfg.AddFlagSets(flags)
|
|
if err := flags.Parse(args); err != nil {
|
|
return &cfg, 1
|
|
}
|
|
|
|
args = flags.Args()
|
|
if len(args) != 1 {
|
|
flags.Usage()
|
|
return &cfg, 1
|
|
}
|
|
cfg.Path = args[0]
|
|
return &cfg, 0
|
|
}
|
|
|
|
func (c *FixCommand) RunContext(ctx context.Context, cla *FixArgs) int {
|
|
if hcl2, _ := isHCLLoaded(cla.Path); hcl2 {
|
|
c.Ui.Error("packer fix only works with JSON files for now.")
|
|
return 1
|
|
}
|
|
// Read the file for decoding
|
|
tplF, err := os.Open(cla.Path)
|
|
if err != nil {
|
|
c.Ui.Error(fmt.Sprintf("Error opening template: %s", err))
|
|
return 1
|
|
}
|
|
defer tplF.Close()
|
|
|
|
// Decode the JSON into a generic map structure
|
|
var templateData map[string]interface{}
|
|
decoder := json.NewDecoder(tplF)
|
|
if err := decoder.Decode(&templateData); err != nil {
|
|
c.Ui.Error(fmt.Sprintf("Error parsing template: %s", err))
|
|
return 1
|
|
}
|
|
|
|
// Close the file since we're done with that
|
|
tplF.Close()
|
|
|
|
input := templateData
|
|
for _, name := range fix.FixerOrder {
|
|
var err error
|
|
fixer, ok := fix.Fixers[name]
|
|
if !ok {
|
|
panic("fixer not found: " + name)
|
|
}
|
|
|
|
log.Printf("Running fixer: %s", name)
|
|
input, err = fixer.Fix(input)
|
|
if err != nil {
|
|
c.Ui.Error(fmt.Sprintf("Error fixing: %s", err))
|
|
return 1
|
|
}
|
|
}
|
|
|
|
var output bytes.Buffer
|
|
encoder := json.NewEncoder(&output)
|
|
if err := encoder.Encode(input); err != nil {
|
|
c.Ui.Error(fmt.Sprintf("Error encoding: %s", err))
|
|
return 1
|
|
}
|
|
|
|
var indented bytes.Buffer
|
|
if err := json.Indent(&indented, output.Bytes(), "", " "); err != nil {
|
|
c.Ui.Error(fmt.Sprintf("Error encoding: %s", err))
|
|
return 1
|
|
}
|
|
|
|
result := indented.String()
|
|
result = strings.Replace(result, `\u003c`, "<", -1)
|
|
result = strings.Replace(result, `\u003e`, ">", -1)
|
|
c.Ui.Say(result)
|
|
|
|
if cla.Validate == false {
|
|
return 0
|
|
}
|
|
|
|
// Attempt to parse and validate the template
|
|
tpl, err := template.Parse(strings.NewReader(result))
|
|
if err != nil {
|
|
c.Ui.Error(fmt.Sprintf(
|
|
"Error! Fixed template fails to parse: %s\n\n"+
|
|
"This is usually caused by an error in the input template.\n"+
|
|
"Please fix the error and try again.",
|
|
err))
|
|
return 1
|
|
}
|
|
if err := tpl.Validate(); err != nil {
|
|
c.Ui.Error(fmt.Sprintf(
|
|
"Error! Fixed template failed to validate: %s\n\n"+
|
|
"This is usually caused by an error in the input template.\n"+
|
|
"Please fix the error and try again.",
|
|
err))
|
|
return 1
|
|
}
|
|
|
|
return 0
|
|
}
|
|
|
|
func (*FixCommand) Help() string {
|
|
helpText := `
|
|
Usage: packer fix [options] TEMPLATE
|
|
|
|
Reads the JSON template and attempts to fix known backwards
|
|
incompatibilities. The fixed template will be outputted to standard out.
|
|
|
|
If the template cannot be fixed due to an error, the command will exit
|
|
with a non-zero exit status. Error messages will appear on standard error.
|
|
|
|
Fixes that are run (in order):
|
|
|
|
`
|
|
|
|
for _, name := range fix.FixerOrder {
|
|
helpText += fmt.Sprintf(
|
|
" %-27s%s\n", name, fix.Fixers[name].Synopsis())
|
|
}
|
|
|
|
helpText += `
|
|
Options:
|
|
|
|
-validate=true If true (default), validates the fixed template.
|
|
`
|
|
|
|
return strings.TrimSpace(helpText)
|
|
}
|
|
|
|
func (c *FixCommand) Synopsis() string {
|
|
return "fixes templates from old versions of packer"
|
|
}
|
|
|
|
func (c *FixCommand) AutocompleteArgs() complete.Predictor {
|
|
return complete.PredictNothing
|
|
}
|
|
|
|
func (c *FixCommand) AutocompleteFlags() complete.Flags {
|
|
return complete.Flags{
|
|
"-validate": complete.PredictNothing,
|
|
}
|
|
}
|