build: upgrade jasmine (and related typings) to latest version (#19904)
With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes #23952 Closes #24733 PR Close #19904
This commit is contained in:
committed by
Miško Hevery
parent
1e74ea9e60
commit
00c110b055
@@ -16,10 +16,9 @@ export class FeatureComponent {
|
||||
@NgModule({
|
||||
declarations: [FeatureComponent],
|
||||
imports: [RouterModule.forChild([
|
||||
{path: '', component: FeatureComponent}, {path: 'd', loadChildren: './default.module'} {
|
||||
path: 'e',
|
||||
loadChildren: 'feature/feature.module#FeatureModule'
|
||||
}
|
||||
{path: '', component: FeatureComponent},
|
||||
{path: 'd', loadChildren: './default.module'},
|
||||
{path: 'e', loadChildren: 'feature/feature.module#FeatureModule'},
|
||||
])]
|
||||
})
|
||||
export class Feature2Module {
|
||||
|
||||
Reference in New Issue
Block a user