build: upgrade jasmine (and related typings) to latest version (#19904)
With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes #23952 Closes #24733 PR Close #19904
This commit is contained in:
committed by
Miško Hevery
parent
1e74ea9e60
commit
00c110b055
@@ -23,7 +23,7 @@ export const proxy: ClassDecorator = (t: any) => t;
|
||||
const _global = <any>(typeof window === 'undefined' ? global : window);
|
||||
|
||||
export const afterEach: Function = _global.afterEach;
|
||||
export const expect: (actual: any) => jasmine.Matchers = _global.expect;
|
||||
export const expect: <T>(actual: T) => jasmine.Matchers<T> = _global.expect;
|
||||
|
||||
const jsmBeforeEach = _global.beforeEach;
|
||||
const jsmDescribe = _global.describe;
|
||||
|
||||
Reference in New Issue
Block a user