From 0e923324916ba3a3544dc35cf9fa4ff87a0f216e Mon Sep 17 00:00:00 2001 From: Brandon Date: Wed, 8 May 2019 09:45:40 -0500 Subject: [PATCH] refactor(common): update argument length in UrlCodec.areEqual method and AngularJSUrlCodec.areEqual methods (#30331) dgeni requires that method arguments be at least 2 characters long PR Close #30331 --- packages/common/upgrade/src/params.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/common/upgrade/src/params.ts b/packages/common/upgrade/src/params.ts index a357c17a51..612e15310a 100644 --- a/packages/common/upgrade/src/params.ts +++ b/packages/common/upgrade/src/params.ts @@ -25,7 +25,7 @@ export abstract class UrlCodec { abstract normalize(path: string, search: {[k: string]: unknown}, hash: string, baseUrl?: string): string; - abstract areEqual(a: string, b: string): boolean; + abstract areEqual(valA: string, valB: string): boolean; abstract parse(url: string, base?: string): { href: string, @@ -134,7 +134,7 @@ export class AngularJSUrlCodec implements UrlCodec { } } - areEqual(a: string, b: string) { return this.normalize(a) === this.normalize(b); } + areEqual(valA: string, valB: string) { return this.normalize(valA) === this.normalize(valB); } // https://github.com/angular/angular.js/blob/864c7f0/src/ng/urlUtils.js#L60 parse(url: string, base?: string) {