From 1aee5a79c6ec2a94d50f358ba77eaa2e86a4239a Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Tue, 27 Apr 2021 22:50:12 +0300 Subject: [PATCH] test(docs-infra): make it easier to identify the failing URL in `testFirebaseRedirection.spec.ts` (#41842) This commit includes the URL under test in the test description in `testFirebaseRedirection.spec.ts` to make it easier to identify the affected URL when a test fails. It also avoids unnecessarily creating multiple `FirebaseRedirector` instances by sharing instances between tests. PR Close #41842 --- .../unit/testFirebaseRedirection.spec.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/aio/tests/deployment/unit/testFirebaseRedirection.spec.ts b/aio/tests/deployment/unit/testFirebaseRedirection.spec.ts index d50f81f32d..9ac74675f2 100644 --- a/aio/tests/deployment/unit/testFirebaseRedirection.spec.ts +++ b/aio/tests/deployment/unit/testFirebaseRedirection.spec.ts @@ -2,20 +2,25 @@ import { getRedirector, loadLegacyUrls, loadLocalSitemapUrls, loadRedirects } fr describe('firebase.json redirect config', () => { describe('with sitemap urls', () => { + const redirector = getRedirector(); + loadLocalSitemapUrls().forEach(url => { - it('should not redirect any urls in the sitemap', () => { - expect(getRedirector().redirect(url)).toEqual(url); + it(`should not redirect sitemap URL '${url}'`, () => { + expect(redirector.redirect(url)).toEqual(url); }); }); }); describe('with legacy urls', () => { + const redirector = getRedirector(); + loadLegacyUrls().forEach(urlPair => { - it('should redirect the legacy urls', () => { - const redirector = getRedirector(); - expect(redirector.redirect(urlPair[0])).not.toEqual(urlPair[0]); + it(`should redirect legacy URL '${urlPair[0]}'`, () => { + const redirected = redirector.redirect(urlPair[0]); + + expect(redirected).not.toEqual(urlPair[0]); if (urlPair[1]) { - expect(redirector.redirect(urlPair[0])).toEqual(urlPair[1]); + expect(redirected).toEqual(urlPair[1]); } }); });