From 1e46b73463f8f05becb491a0295958dfcadd7dac Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Fri, 8 Jan 2021 12:18:31 -0800 Subject: [PATCH] ci: add new group to approve contributor list changes (#40368) This commit adds a new `docs-contributors` group (with Emma and Minko as members) which will be used as reviewers for PRs that update the list of contributors. PR Close #40368 --- .pullapprove.yml | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index fa8b5fef13..5d1fc8e0ee 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -209,6 +209,7 @@ groups: - pkozlowski-opensource # Pawel Kozlowski - Splaktar # Michael Prentice - StephenFluin # Stephen Fluin + - twerske # Emma Twersky # ========================================================= # Framework: Animations @@ -876,6 +877,25 @@ groups: - mhevery + # ========================================================= + # Docs: Contributors + # ========================================================= + docs-contributors: + <<: *defaults + conditions: + - *can-be-global-approved + - *can-be-global-docs-approved + - > + contains_any_globs(files, [ + 'aio/content/marketing/contributors.json', + 'aio/content/images/bios/**', + ]) + reviewers: + users: + - mgechev + - twerske + + # ========================================================= # Docs: Gettings Started & Tutorial # ========================================================= @@ -918,10 +938,9 @@ groups: - *can-be-global-approved - *can-be-global-docs-approved - > - contains_any_globs(files, [ + contains_any_globs(files.exclude("aio/content/marketing/contributors.json"), [ 'aio/content/guide/roadmap.md', 'aio/content/marketing/**', - 'aio/content/images/bios/**', 'aio/content/images/marketing/**', 'aio/content/file-not-found.md', 'aio/content/license.md',