From 458b2d7215eaf696fdabecd572ad172aeefccc80 Mon Sep 17 00:00:00 2001 From: Tobias Bosch Date: Tue, 6 Jan 2015 15:56:54 -0800 Subject: [PATCH] docs(bench press): add clarifying comment --- tools/benchpress/src/time_benchmark.es6 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/benchpress/src/time_benchmark.es6 b/tools/benchpress/src/time_benchmark.es6 index 7153bb6642..39b8e90d64 100644 --- a/tools/benchpress/src/time_benchmark.es6 +++ b/tools/benchpress/src/time_benchmark.es6 @@ -190,6 +190,10 @@ function sumTimelineRecords(records, startTimeStampId, endTimeStampId) { // we need to substract the time of child records // that have been added to the stats from this record. // E.g. for a script record that triggered a gc or reflow while executing. + + // Attention: If a gc happens during a script execution, the + // execution time of the script is usually slower than normal, + // even when we substract the gc time!! recordDuration = (record.endTime ? record.endTime - record.startTime : 0) - summedChildrenDuration;