chore(transformer): add a test that generated change detectors dont call notifyOnBinding for template variables
This commit is contained in:
committed by
Tobias Bosch
parent
b3a763a718
commit
4bdc91892a
@@ -24,27 +24,27 @@ export function main() {
|
||||
|
||||
if (!IS_DARTIUM) {
|
||||
describe('verification of properties', () => {
|
||||
|
||||
|
||||
it('should throw for unknown properties', () => {
|
||||
builder.bindElement(el('<div/>')).bindProperty('unknownProperty', emptyExpr());
|
||||
expect(() => builder.build())
|
||||
.toThrowError(
|
||||
`Can't bind to 'unknownProperty' since it isn't a know property of the 'div' element and there are no matching directives with a corresponding property`);
|
||||
});
|
||||
|
||||
|
||||
it('should allow unknown properties if a directive uses it', () => {
|
||||
var binder = builder.bindElement(el('<div/>'));
|
||||
binder.bindDirective(0).bindProperty('someDirProperty', emptyExpr(), 'directiveProperty');
|
||||
binder.bindProperty('directiveProperty', emptyExpr());
|
||||
expect(() => builder.build()).not.toThrow();
|
||||
});
|
||||
|
||||
|
||||
it('should allow unknown properties on custom elements', () => {
|
||||
var binder = builder.bindElement(el('<some-custom/>'));
|
||||
binder.bindProperty('unknownProperty', emptyExpr());
|
||||
expect(() => builder.build()).not.toThrow();
|
||||
});
|
||||
|
||||
|
||||
it('should throw for unknown properties on custom elements if there is an ng component', () => {
|
||||
var binder = builder.bindElement(el('<some-custom/>'));
|
||||
binder.bindProperty('unknownProperty', emptyExpr());
|
||||
@@ -53,8 +53,20 @@ export function main() {
|
||||
.toThrowError(
|
||||
`Can't bind to 'unknownProperty' since it isn't a know property of the 'some-custom' element and there are no matching directives with a corresponding property`);
|
||||
});
|
||||
|
||||
});
|
||||
|
||||
});
|
||||
} else {
|
||||
describe('verification of properties', () => {
|
||||
|
||||
// TODO(tbosch): This is just a temporary test that makes sure that the dart server and
|
||||
// dart browser is in sync. Change this to "not contains notifyBinding"
|
||||
// when https://github.com/angular/angular/issues/3019 is solved.
|
||||
it('should throw for unknown properties', () => {
|
||||
builder.bindElement(el('<div/>')).bindProperty('unknownProperty', emptyExpr());
|
||||
expect(() => builder.build()).not.toThrow();
|
||||
});
|
||||
|
||||
});
|
||||
}
|
||||
|
||||
describe('property normalization', () => {
|
||||
|
||||
Reference in New Issue
Block a user