From 53a0b26348f4f85b77dbebdf473c3f98960dfeb9 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Sat, 18 May 2019 00:20:47 +0300 Subject: [PATCH] docs: document the `PR action: review` label in `TRIAGE_AND_LABELS.md` (#30171) PR Close #30171 --- docs/TRIAGE_AND_LABELS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/TRIAGE_AND_LABELS.md b/docs/TRIAGE_AND_LABELS.md index 86f626c661..beea97c569 100644 --- a/docs/TRIAGE_AND_LABELS.md +++ b/docs/TRIAGE_AND_LABELS.md @@ -125,6 +125,9 @@ Every triaged PR must have a `PR action` label assigned to it: * `PR action: discuss`: Discussion is needed, to be led by the author. * _**Who adds it:** Typically the PR author._ * _**Who removes it:** Whoever added it._ +* `PR action: review` (optional): One or more reviews are pending. The label is optional, since the review status can be derived from GitHub's Reviewers interface. + * _**Who adds it:** Any team member. The caretaker can use it to differentiate PRs pending review from merge-ready PRs._ + * _**Who removes it:** Whoever added it or the reviewer adding the last missing review._ * `PR action: cleanup`: More work is needed from the author. * _**Who adds it:** The reviewer requesting changes to the PR._ * _**Who removes it:** Either the author (after implementing the requested changes) or the reviewer (after confirming the requested changes have been implemented)._