From 64f68206604851885224d476c0239121b5afac90 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Sun, 25 Nov 2018 14:15:37 +0000 Subject: [PATCH] refactor(ivy): ngcc - subclasses do not need to declare `protected` variables (#26906) These variables are already declared as protected in the super class, and so it is redundant to do it again in the subclasses. PR Close #26906 --- packages/compiler-cli/src/ngcc/src/rendering/esm5_renderer.ts | 4 ++-- packages/compiler-cli/src/ngcc/src/rendering/esm_renderer.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/compiler-cli/src/ngcc/src/rendering/esm5_renderer.ts b/packages/compiler-cli/src/ngcc/src/rendering/esm5_renderer.ts index 0cdf9b2bea..44e6ae2c49 100644 --- a/packages/compiler-cli/src/ngcc/src/rendering/esm5_renderer.ts +++ b/packages/compiler-cli/src/ngcc/src/rendering/esm5_renderer.ts @@ -14,8 +14,8 @@ import {EsmRenderer} from './esm_renderer'; export class Esm5Renderer extends EsmRenderer { constructor( - protected host: NgccReflectionHost, protected bundle: BundleInfo, - protected sourcePath: string, protected targetPath: string, transformDts: boolean) { + host: NgccReflectionHost, bundle: BundleInfo, sourcePath: string, targetPath: string, + transformDts: boolean) { super(host, bundle, sourcePath, targetPath, transformDts); } diff --git a/packages/compiler-cli/src/ngcc/src/rendering/esm_renderer.ts b/packages/compiler-cli/src/ngcc/src/rendering/esm_renderer.ts index 657665da21..fb9c527c8c 100644 --- a/packages/compiler-cli/src/ngcc/src/rendering/esm_renderer.ts +++ b/packages/compiler-cli/src/ngcc/src/rendering/esm_renderer.ts @@ -14,8 +14,8 @@ import {Renderer} from './renderer'; export class EsmRenderer extends Renderer { constructor( - protected host: NgccReflectionHost, protected bundle: BundleInfo, - protected sourcePath: string, protected targetPath: string, transformDts: boolean) { + host: NgccReflectionHost, bundle: BundleInfo, sourcePath: string, targetPath: string, + transformDts: boolean) { super(host, bundle, sourcePath, targetPath, transformDts); }