build: fix gulp setup not working with node v12 (#33348)

It looks like the gulp setup does not work with NodeJS v12. This
is because we still use gulp for a few tasks, but gulp v3 is not
compatible with NodeJS v12. We had a similar issue for NodeJS v12,
but worked around it by updating the `natives` module version.

To actually solve this in a more future-proof way, without
updating or removing Gulp (for now), we just overwrite the
`graceful-fs` version. The latest version of `graceful-fs`
does no longer depend on the `natives` package and therefore
works properly with NodeJS >= v10.

PR Close #33348
This commit is contained in:
Paul Gschwendtner
2019-10-23 12:49:49 +02:00
committed by Andrew Kushnir
parent f013515307
commit 66519de2dd
2 changed files with 6 additions and 28 deletions
+2 -2
View File
@@ -170,8 +170,8 @@
"vrsource-tslint-rules": "5.1.1",
"webpack": "1.12.9"
},
"// 4": "natives is needed for gulp to work with node >= 10.13, see #28213",
"// 4": "Overwrite graceful-fs to a version that does not rely on the 'natives' package. This fixes gulp for >= 10.13, more information: #28213",
"resolutions": {
"natives": "1.1.6"
"**/graceful-fs": "4.2.2"
}
}