From 7ca772060b9a52c6dc2cc96c266deb36a4a885c9 Mon Sep 17 00:00:00 2001
From: Alan Agius <alan.agius4@gmail.com>
Date: Tue, 3 Apr 2018 17:21:42 +0200
Subject: [PATCH] fix(common): `locales` are not being shipped (#23136)

Closes: #23140, #23103

PR Close #23136
---
 .../bazel/test/ng_package/common_package.spec.ts  | 15 +++++++++++++++
 packages/common/BUILD.bazel                       |  3 +++
 2 files changed, 18 insertions(+)

diff --git a/packages/bazel/test/ng_package/common_package.spec.ts b/packages/bazel/test/ng_package/common_package.spec.ts
index 26f0b7b84b..85b541f48f 100644
--- a/packages/bazel/test/ng_package/common_package.spec.ts
+++ b/packages/bazel/test/ng_package/common_package.spec.ts
@@ -13,6 +13,21 @@ import * as shx from 'shelljs';
 shx.cd(path.join(process.env['TEST_SRCDIR'], 'angular', 'packages', 'common', 'npm_package'));
 
 describe('@angular/common ng_package', () => {
+  it('should have the locales files', () => {
+    it('/locales', () => {
+      const files = shx.ls('-R', 'locales').stdout.split('\n');
+      expect(files.some(n => n.endsWith('.d.ts'))).toBe(true, `.d.ts files don't exist`);
+      expect(files.some(n => n.endsWith('.js'))).toBe(true, `.js files don't exist`);
+      expect(files.some(n => n.endsWith('.js.map'))).toBe(true, `.js.map files don't exist`);
+    });
+    it('/locales/extra', () => {
+      const files = shx.ls('-R', 'locales/extra').stdout.split('\n');
+      expect(files.some(n => n.endsWith('.d.ts'))).toBe(true, `.d.ts files don't exist`);
+      expect(files.some(n => n.endsWith('.js'))).toBe(true, `.js files don't exist`);
+      expect(files.some(n => n.endsWith('.js.map'))).toBe(true, `.js.map files don't exist`);
+    });
+  });
+
   it('should have right bundle files', () => {
     expect(shx.ls('-R', 'bundles').stdout.split('\n').filter(n => !!n).sort()).toEqual([
       'common-http-testing.umd.js',
diff --git a/packages/common/BUILD.bazel b/packages/common/BUILD.bazel
index 48bb22512c..7e78d4bce3 100644
--- a/packages/common/BUILD.bazel
+++ b/packages/common/BUILD.bazel
@@ -25,6 +25,9 @@ ng_package(
         "//packages/common/http/testing:package.json",
         "//packages/common/testing:package.json",
     ],
+    data = [
+        "//packages/common/locales",
+    ],
     entry_point = "packages/common/index.js",
     tags = ["release-with-framework"],
     deps = [