From 7ce0fc7d47384cd94675ce58d8aaaec7f9e76508 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Thu, 9 Jun 2016 11:04:15 -0700 Subject: [PATCH] refactor: add types (#9116) --- .../common/test/directives/ng_class_spec.ts | 54 +++--- .../common/test/directives/ng_for_spec.ts | 52 +++--- .../common/test/directives/ng_if_spec.ts | 16 +- .../common/test/directives/ng_plural_spec.ts | 8 +- .../common/test/directives/ng_style_spec.ts | 10 +- .../common/test/directives/ng_switch_spec.ts | 8 +- .../directives/ng_template_outlet_spec.ts | 8 +- .../test/directives/non_bindable_spec.ts | 6 +- .../test/forms-deprecated/integration_spec.ts | 72 ++++---- .../test/forms-deprecated/model_spec.ts | 26 +-- .../common/test/forms/integration_spec.ts | 72 ++++---- .../@angular/common/test/forms/model_spec.ts | 26 +-- .../common/test/pipes/async_pipe_spec.ts | 20 +-- .../common/test/pipes/json_pipe_spec.ts | 2 +- .../common/test/pipes/slice_pipe_spec.ts | 2 +- .../test/directive_normalizer_spec.ts | 16 +- .../compiler/test/offline_compiler_spec.ts | 2 +- .../compiler/test/template_parser_spec.ts | 2 +- .../test/test_component_builder_spec.ts | 46 ++--- .../@angular/compiler/test/xhr_mock_spec.ts | 10 +- modules/@angular/compiler/testing/xhr_mock.ts | 4 +- .../core/test/application_ref_spec.ts | 6 +- .../core/test/debug/debug_node_spec.ts | 30 ++-- .../core/test/di/reflective_injector_spec.ts | 8 +- .../directive_lifecycle_integration_spec.ts | 2 +- .../core/test/facade/observable_spec.ts | 6 +- .../core/test/forward_ref_integration_spec.ts | 2 +- .../change_detection_integration_spec.ts | 11 +- .../linker/dynamic_component_loader_spec.ts | 16 +- .../core/test/linker/integration_spec.ts | 160 +++++++++--------- .../linker/projection_integration_spec.ts | 52 +++--- .../test/linker/query_integration_spec.ts | 74 ++++---- .../reflector_component_resolver_spec.ts | 6 +- .../linker/regression_integration_spec.ts | 18 +- .../linker/view_injector_integration_spec.ts | 2 +- .../@angular/core/test/metadata/di_spec.ts | 8 +- .../core/test/testability/testability_spec.ts | 22 +-- .../@angular/core/test/zone/ng_zone_spec.ts | 54 +++--- modules/@angular/facade/test/async_spec.ts | 16 +- .../http/test/backends/xhr_backend_spec.ts | 4 +- .../test/browser/bootstrap_spec.ts | 24 +-- .../test/testing_public_browser_spec.ts | 4 +- .../web_workers/shared/message_bus_spec.ts | 10 +- .../shared/service_message_broker_spec.ts | 4 +- .../worker/platform_location_spec.ts | 2 +- .../worker/renderer_integration_spec.ts | 14 +- .../test/xhr/xhr_cache_spec.ts | 4 +- .../test/xhr/xhr_impl_spec.ts | 4 +- .../test/directives/router_link_spec.ts | 8 +- .../test/integration/bootstrap_spec.ts | 14 +- .../integration/impl/async_route_spec_impl.ts | 62 +++---- .../integration/impl/aux_route_spec_impl.ts | 16 +- .../integration/impl/sync_route_spec_impl.ts | 44 ++--- .../test/integration/lifecycle_hook_spec.ts | 26 +-- .../test/integration/navigation_spec.ts | 26 +-- .../test/integration/redirect_route_spec.ts | 10 +- .../test/integration/router_link_spec.ts | 30 ++-- .../test/location/location_spec.ts | 2 +- .../test/route_config/route_config_spec.ts | 18 +- .../test/route_registry_spec.ts | 26 +-- .../router-deprecated/test/router_spec.ts | 24 +-- .../test/rules/rule_set_spec.ts | 20 +-- .../@angular/router/test/recognize_spec.ts | 24 +-- modules/@angular/upgrade/test/upgrade_spec.ts | 54 +++--- 64 files changed, 711 insertions(+), 718 deletions(-) diff --git a/modules/@angular/common/test/directives/ng_class_spec.ts b/modules/@angular/common/test/directives/ng_class_spec.ts index cf0ab73739..1545a43b1a 100644 --- a/modules/@angular/common/test/directives/ng_class_spec.ts +++ b/modules/@angular/common/test/directives/ng_class_spec.ts @@ -25,7 +25,7 @@ export function main() { describe('binding to CSS class list', () => { it('should clean up when the directive is destroyed', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) .createAsync(TestComponent) @@ -44,7 +44,7 @@ export function main() { describe('expressions evaluating to objects', () => { it('should add classes specified in an object literal', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -57,7 +57,7 @@ export function main() { it('should add classes specified in an object literal without change in class names', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -69,7 +69,7 @@ export function main() { })); it('should add and remove classes based on changes in object literal values', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -85,7 +85,7 @@ export function main() { })); it('should add and remove classes based on changes to the expression object', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -107,7 +107,7 @@ export function main() { })); it('should add and remove classes based on reference changes to the expression object', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -126,7 +126,7 @@ export function main() { })); it('should remove active classes when expression evaluates to null', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -146,7 +146,7 @@ export function main() { it('should allow multiple classes per expression', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -171,7 +171,7 @@ export function main() { })); it('should split by one or more spaces between classes', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -190,7 +190,7 @@ export function main() { describe('expressions evaluating to lists', () => { it('should add classes specified in a list literal', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -202,7 +202,7 @@ export function main() { })); it('should add and remove classes based on changes to the expression', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -225,7 +225,7 @@ export function main() { })); it('should add and remove classes when a reference changes', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -241,7 +241,7 @@ export function main() { })); it('should take initial classes into account when a reference changes', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -257,7 +257,7 @@ export function main() { })); it('should ignore empty or blank class names', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -272,7 +272,7 @@ export function main() { })); it('should trim blanks from class names', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -288,7 +288,7 @@ export function main() { it('should allow multiple classes per item in arrays', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -310,7 +310,7 @@ export function main() { describe('expressions evaluating to sets', () => { it('should add and remove classes if the set instance changed', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -333,7 +333,7 @@ export function main() { describe('expressions evaluating to string', () => { it('should add classes specified in a string literal', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -345,7 +345,7 @@ export function main() { })); it('should add and remove classes based on changes to the expression', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -365,7 +365,7 @@ export function main() { })); it('should remove active classes when switching from string to null', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -381,7 +381,7 @@ export function main() { })); it('should take initial classes into account when switching from string to null', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -397,7 +397,7 @@ export function main() { })); it('should ignore empty and blank strings', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -415,7 +415,7 @@ export function main() { describe('cooperation with other class-changing constructs', () => { it('should co-operate with the class attribute', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) @@ -435,7 +435,7 @@ export function main() { })); it('should co-operate with the interpolated class attribute', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -455,7 +455,7 @@ export function main() { })); it('should co-operate with the class attribute and binding to it', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = `
`; tcb.overrideTemplate(TestComponent, template) @@ -475,7 +475,7 @@ export function main() { })); it('should co-operate with the class attribute and class.name binding', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; @@ -498,7 +498,7 @@ export function main() { })); it('should co-operate with initial class and class attribute binding when binding changes', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
'; tcb.overrideTemplate(TestComponent, template) diff --git a/modules/@angular/common/test/directives/ng_for_spec.ts b/modules/@angular/common/test/directives/ng_for_spec.ts index 4b0f73e9c7..11963e4028 100644 --- a/modules/@angular/common/test/directives/ng_for_spec.ts +++ b/modules/@angular/common/test/directives/ng_for_spec.ts @@ -25,7 +25,7 @@ export function main() { '
{{item.toString()}};
'; it('should reflect initial elements', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -36,7 +36,7 @@ export function main() { })); it('should reflect added elements', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -51,7 +51,7 @@ export function main() { })); it('should reflect removed elements', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -66,7 +66,7 @@ export function main() { })); it('should reflect moved elements', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -82,7 +82,7 @@ export function main() { })); it('should reflect a mix of all changes (additions/removals/moves)', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -98,7 +98,7 @@ export function main() { })); it('should iterate over an array of objects', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = ''; tcb.overrideTemplate(TestComponent, template) @@ -128,7 +128,7 @@ export function main() { })); it('should gracefully handle nulls', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = ''; tcb.overrideTemplate(TestComponent, template) .createAsync(TestComponent) @@ -140,7 +140,7 @@ export function main() { })); it('should gracefully handle ref changing to null and back', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -160,7 +160,7 @@ export function main() { if (!IS_DART) { it('should throw on non-iterable ref and suggest using an array', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -177,7 +177,7 @@ export function main() { } it('should throw on ref changing to string', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -191,7 +191,7 @@ export function main() { })); it('should works with duplicates', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { tcb.overrideTemplate(TestComponent, TEMPLATE) .createAsync(TestComponent) .then((fixture) => { @@ -204,7 +204,7 @@ export function main() { })); it('should repeat over nested arrays', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '
' + '
' + '
' + @@ -231,7 +231,7 @@ export function main() { })); it('should repeat over nested arrays with no intermediate element', - inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: any /** TODO #9100 */) => { + inject([TestComponentBuilder, AsyncTestCompleter], (tcb: TestComponentBuilder, async: AsyncTestCompleter) => { var template = '