From b826e0c6362a149c01c3e2391d3597aef551b169 Mon Sep 17 00:00:00 2001 From: Tobias Bosch Date: Wed, 20 Sep 2017 10:00:01 -0700 Subject: [PATCH] =?UTF-8?q?refactor(compiler):=20don=E2=80=99t=20workaroun?= =?UTF-8?q?d=20a=20fixed=20tsickle=20bug=20(#19301)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR Close #19301 --- packages/bazel/src/ngc-wrapped/index.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/packages/bazel/src/ngc-wrapped/index.ts b/packages/bazel/src/ngc-wrapped/index.ts index 6d45e0c904..d1aa46c7df 100644 --- a/packages/bazel/src/ngc-wrapped/index.ts +++ b/packages/bazel/src/ngc-wrapped/index.ts @@ -103,7 +103,7 @@ export function compile( } }; - // Patch fileExists when resolving modules, so that ngc can ask TypeScript to + // Patch fileExists when resolving modules, so that CompilerHost can ask TypeScript to // resolve non-existing generated files that don't exist on disk, but are // synthetic and added to the `programWithStubs` based on real inputs. const generatedFileModuleResolverHost = Object.create(tsHost); @@ -143,12 +143,6 @@ export function compile( } return origBazelHostFileExist.call(bazelHost, fileName); }; - // TODO(tbosch): fix tsickle to still run regular transformers even - // if tsickle is not processing a file, and then remove this override, - // as this is only required to keep the ng transformer running, - // but produces e.g. too many externs. - bazelHost.shouldSkipTsickleProcessing = (fileName: string): boolean => - bazelOpts.compilationTargetSrc.indexOf(fileName) === -1 && !NGC_GEN_FILES.test(fileName); const ngHost = ng.createCompilerHost({options: compilerOpts, tsHost: bazelHost});