chore(transformers): remove reflector parameter from initReflector signature

Remove reflector parameter from initReflector method to simplify ng_deps for reflection
initialization. It wasn't used and was added for testability, but wasn't used. This
keeps the interface simplier.
This commit is contained in:
Ted Sander
2015-07-15 23:15:44 -07:00
parent a4915ad634
commit c701664e07
39 changed files with 108 additions and 74 deletions
@@ -72,8 +72,7 @@ Future<String> linkNgDeps(AssetReader reader, AssetId entryPoint) async {
importBuf.write('''
import '${linkedDepsMap[it.current]}' as i${i};
''');
declarationBuf
.write('i${i}.${SETUP_METHOD_NAME}(${REFLECTOR_VAR_NAME});');
declarationBuf.write('i${i}.${SETUP_METHOD_NAME}();');
++i;
}
}
@@ -94,6 +94,7 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
if (_wroteBaseLibImport) return;
_wroteBaseLibImport = true;
writer.print('''import '${path.basename(assetId.path)}';''');
writer.print("import '$_REFLECTOR_IMPORT' as $_REF_PREFIX;");
}
void _updateUsesNonLangLibs(UriBasedDirective directive) {
@@ -118,7 +119,7 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
void _openFunctionWrapper() {
_maybeWriteImport();
writer.print('var _visited = false;'
'void ${SETUP_METHOD_NAME}(${REFLECTOR_VAR_NAME}) {'
'void ${SETUP_METHOD_NAME}() {'
'if (_visited) return; _visited = true;');
}
@@ -256,6 +257,9 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
_foundNgInjectable = true;
// The receiver for cascaded calls.
writer.print(REFLECTOR_VAR_NAME);
writer.print('$_REF_PREFIX.$REFLECTOR_VAR_NAME');
}
}
const _REF_PREFIX = '_ngRef';
const _REFLECTOR_IMPORT = 'package:angular2/src/reflection/reflection.dart';
@@ -53,8 +53,7 @@ class Codegen {
var count = 0;
return importUris
.map((_) =>
'${prefix}${count++}.${SETUP_METHOD_NAME}(${reflectorExpression});')
.map((_) => '${prefix}${count++}.${SETUP_METHOD_NAME}();')
.join('');
}
}