From e721a5d258bfe7067ae5ec541e38c79eae9f8588 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Thu, 4 Feb 2021 14:39:32 -0800 Subject: [PATCH] fix(benchpress): update type castings for JSON.parse usage (#40710) Update usages of JSON.parse to be cast as specific types. PR Close #40710 --- packages/benchpress/src/webdriver/chrome_driver_extension.ts | 2 +- packages/benchpress/src/webdriver/ios_driver_extension.ts | 2 +- packages/benchpress/test/reporter/json_file_reporter_spec.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/benchpress/src/webdriver/chrome_driver_extension.ts b/packages/benchpress/src/webdriver/chrome_driver_extension.ts index 2297d8b5a6..ab9f29afb4 100644 --- a/packages/benchpress/src/webdriver/chrome_driver_extension.ts +++ b/packages/benchpress/src/webdriver/chrome_driver_extension.ts @@ -86,7 +86,7 @@ export class ChromeDriverExtension extends WebDriverExtension { .then((entries) => { const events: PerfLogEvent[] = []; entries.forEach((entry: any) => { - const message = JSON.parse(entry['message'])['message']; + const message = (JSON.parse(entry['message']) as {message: any})['message']; if (message['method'] === 'Tracing.dataCollected') { events.push(message['params']); } diff --git a/packages/benchpress/src/webdriver/ios_driver_extension.ts b/packages/benchpress/src/webdriver/ios_driver_extension.ts index f2bad64b33..df85000561 100644 --- a/packages/benchpress/src/webdriver/ios_driver_extension.ts +++ b/packages/benchpress/src/webdriver/ios_driver_extension.ts @@ -44,7 +44,7 @@ export class IOsDriverExtension extends WebDriverExtension { .then((entries) => { const records: any[] = []; entries.forEach((entry: any) => { - const message = JSON.parse(entry['message'])['message']; + const message = (JSON.parse(entry['message']) as {message: any})['message']; if (message['method'] === 'Timeline.eventRecorded') { records.push(message['params']['record']); } diff --git a/packages/benchpress/test/reporter/json_file_reporter_spec.ts b/packages/benchpress/test/reporter/json_file_reporter_spec.ts index d8621e7374..a7943a4a48 100644 --- a/packages/benchpress/test/reporter/json_file_reporter_spec.ts +++ b/packages/benchpress/test/reporter/json_file_reporter_spec.ts @@ -50,7 +50,7 @@ import {Injector, JsonFileReporter, MeasureValues, Options, SampleDescription} f [mv(0, 0, {'a': 3, 'b': 6}), mv(1, 1, {'a': 5, 'b': 9})]); const regExp = /somePath\/someId_\d+\.json/; expect(loggedFile['filename'].match(regExp) != null).toBe(true); - const parsedContent = JSON.parse(loggedFile['content']); + const parsedContent = JSON.parse(loggedFile['content']) as any; expect(parsedContent).toEqual({ 'description': { 'id': 'someId',