refactor: rename annotations to metadata
BREAKING CHANGE (maybe) Well as long as our customers use public API this should not be a breaking change, but we have changed import structure as well as internal names, so it could be breaking. import: angular2/annotations => angular2/metadata Classes: *Annotations => *Metadata renderer.DirectiveMetadata => renderer.RendererDirectiveMetadata renderer.ElementBinder => renderer.RendererElementBinder impl.Directive => impl.DirectiveMetadata impl.Component => impl.ComponentMetadata impl.View => impl.ViewMetadata Closes #3660
This commit is contained in:
committed by
Miško Hevery
parent
5e6317fecc
commit
ea6673947c
@@ -16,8 +16,6 @@ import {Component, View} from 'angular2/angular2';
|
||||
|
||||
import {isBlank} from 'angular2/src/facade/lang';
|
||||
|
||||
import * as viewImpl from 'angular2/src/core/annotations_impl/view';
|
||||
|
||||
export function main() {
|
||||
describe('MockViewResolver', () => {
|
||||
var viewResolver;
|
||||
@@ -32,7 +30,7 @@ export function main() {
|
||||
});
|
||||
|
||||
it('should allow overriding the @View', () => {
|
||||
viewResolver.setView(SomeComponent, new viewImpl.View({template: 'overridden template'}));
|
||||
viewResolver.setView(SomeComponent, new View({template: 'overridden template'}));
|
||||
var view = viewResolver.resolve(SomeComponent);
|
||||
expect(view.template).toEqual('overridden template');
|
||||
expect(isBlank(view.directives)).toBe(true);
|
||||
@@ -42,7 +40,7 @@ export function main() {
|
||||
it('should not allow overriding a view after it has been resolved', () => {
|
||||
viewResolver.resolve(SomeComponent);
|
||||
expect(() => {
|
||||
viewResolver.setView(SomeComponent, new viewImpl.View({template: 'overridden template'}));
|
||||
viewResolver.setView(SomeComponent, new View({template: 'overridden template'}));
|
||||
})
|
||||
.toThrowError(
|
||||
`The component ${stringify(SomeComponent)} has already been compiled, its configuration can not be changed`);
|
||||
@@ -58,7 +56,7 @@ export function main() {
|
||||
});
|
||||
|
||||
it('should allow overriding an overriden @View', () => {
|
||||
viewResolver.setView(SomeComponent, new viewImpl.View({template: 'overridden template'}));
|
||||
viewResolver.setView(SomeComponent, new View({template: 'overridden template'}));
|
||||
viewResolver.setInlineTemplate(SomeComponent, 'overridden template x 2');
|
||||
var view = viewResolver.resolve(SomeComponent);
|
||||
expect(view.template).toEqual('overridden template x 2');
|
||||
@@ -82,7 +80,7 @@ export function main() {
|
||||
});
|
||||
|
||||
it('should allow overriding a directive from an overriden @View', () => {
|
||||
viewResolver.setView(SomeComponent, new viewImpl.View({directives: [SomeOtherDirective]}));
|
||||
viewResolver.setView(SomeComponent, new View({directives: [SomeOtherDirective]}));
|
||||
viewResolver.overrideViewDirective(SomeComponent, SomeOtherDirective, SomeComponent);
|
||||
var view = viewResolver.resolve(SomeComponent);
|
||||
expect(view.directives.length).toEqual(1);
|
||||
|
||||
Reference in New Issue
Block a user