2 Commits

Author	SHA1	Message	Date
George Kalpakas	342678486d	test: fix typings for DoneFn (#25163) ... This also fixes CI tests, which were accidentally broken in #24663. PR Close #25163	2018-07-27 11:13:32 -07:00
George Kalpakas	00c110b055	build: upgrade jasmine (and related typings) to latest version (#19904) ... With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes #23952 Closes #24733 PR Close #19904	2018-07-06 13:48:02 -07:00