From 25638c9c788515b7c32d3407bf64fd01261c556a Mon Sep 17 00:00:00 2001 From: Wynn Date: Tue, 16 Apr 2024 08:30:45 +0800 Subject: [PATCH] improvement --- .../compareyesterday/CompareYesterdayUnitTest.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/core-java-modules/core-java-date-operations-4/src/test/java/com/baeldung/compareyesterday/CompareYesterdayUnitTest.java b/core-java-modules/core-java-date-operations-4/src/test/java/com/baeldung/compareyesterday/CompareYesterdayUnitTest.java index 75f63317a7..67a6e859c7 100644 --- a/core-java-modules/core-java-date-operations-4/src/test/java/com/baeldung/compareyesterday/CompareYesterdayUnitTest.java +++ b/core-java-modules/core-java-date-operations-4/src/test/java/com/baeldung/compareyesterday/CompareYesterdayUnitTest.java @@ -5,6 +5,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import java.time.Instant; import java.time.LocalDate; +import java.time.ZonedDateTime; import java.time.temporal.ChronoUnit; import java.util.Calendar; import java.util.Date; @@ -47,9 +48,8 @@ public class CompareYesterdayUnitTest { void givenYesterdayDate_whenCompareWithDateMilliseconds_returnTrue() { // Create a Date object representing yesterday Date expectedDate = new Date(System.currentTimeMillis() - (1000 * 60 * 60 * 24)); - long yesterdayMidnightMillis = Instant.now() - .minus(1, ChronoUnit.DAYS) - .toEpochMilli(); + ZonedDateTime yesterdayMidnight = ZonedDateTime.now().minusDays(1).truncatedTo(ChronoUnit.DAYS); + long yesterdayMidnightMillis = yesterdayMidnight.toInstant().toEpochMilli(); boolean isEqualToYesterday = expectedDate.getTime() >= yesterdayMidnightMillis && expectedDate.getTime() < yesterdayMidnightMillis + 86_400_000; assertTrue(isEqualToYesterday); @@ -59,9 +59,8 @@ public class CompareYesterdayUnitTest { void givenTodayDate_whenCompareWithDateMilliseconds_returnFalse() { // Create a Date object representing yesterday Date expectedDate = new Date(); - long yesterdayMidnightMillis = Instant.now() - .minus(1, ChronoUnit.DAYS) - .toEpochMilli(); + ZonedDateTime yesterdayMidnight = ZonedDateTime.now().minusDays(1).truncatedTo(ChronoUnit.DAYS); + long yesterdayMidnightMillis = yesterdayMidnight.toInstant().toEpochMilli(); boolean isEqualToYesterday = expectedDate.getTime() >= yesterdayMidnightMillis && expectedDate.getTime() < yesterdayMidnightMillis + 86_400_000; assertFalse(isEqualToYesterday);