From 282e9be3f8812b27eec9fb6a60f6a5fc3caffcaf Mon Sep 17 00:00:00 2001 From: Tyrell Flurry Date: Tue, 2 Jun 2020 16:09:16 -0400 Subject: [PATCH] BAEL-4088: code review comments addressed. --- spring-multipart-file/pom.xml | 7 +++++++ .../multipart/file/ConvertMultipartFileExample.java | 9 +++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/spring-multipart-file/pom.xml b/spring-multipart-file/pom.xml index 7caec98b94..d5096c9f00 100644 --- a/spring-multipart-file/pom.xml +++ b/spring-multipart-file/pom.xml @@ -17,6 +17,7 @@ 2.6 4.12 + 3.15.0 2.0.8 @@ -26,6 +27,12 @@ commons-io ${commons-io.version} + + org.assertj + assertj-core + ${org.assertj.assertj-core.version} + test + org.springframework spring-web diff --git a/spring-multipart-file/src/test/java/com/baeldung/multipart/file/ConvertMultipartFileExample.java b/spring-multipart-file/src/test/java/com/baeldung/multipart/file/ConvertMultipartFileExample.java index 23c603a756..180193b987 100644 --- a/spring-multipart-file/src/test/java/com/baeldung/multipart/file/ConvertMultipartFileExample.java +++ b/spring-multipart-file/src/test/java/com/baeldung/multipart/file/ConvertMultipartFileExample.java @@ -1,5 +1,7 @@ package com.baeldung.multipart.file; +import static org.assertj.core.api.Assertions.assertThat; + import java.io.File; import java.io.FileOutputStream; import java.io.IOException; @@ -7,7 +9,6 @@ import java.io.InputStream; import java.io.OutputStream; import org.apache.commons.io.FileUtils; -import org.junit.Assert; import org.junit.Test; import org.springframework.mock.web.MockMultipartFile; import org.springframework.web.multipart.MultipartFile; @@ -29,7 +30,7 @@ public class ConvertMultipartFileExample { os.write(multipartFile.getBytes()); } - Assert.assertEquals(FileUtils.readFileToString(new File("src/main/resources/targetFile.tmp"), "UTF-8"), "Hello World"); + assertThat(FileUtils.readFileToString(new File("src/main/resources/targetFile.tmp"), "UTF-8")).isEqualTo("Hello World"); } /** @@ -51,7 +52,7 @@ public class ConvertMultipartFileExample { outStream.write(buffer); } - Assert.assertEquals(FileUtils.readFileToString(new File("src/main/resources/targetFile.tmp"), "UTF-8"), "Hello World"); + assertThat(FileUtils.readFileToString(new File("src/main/resources/targetFile.tmp"), "UTF-8")).isEqualTo("Hello World"); } /** @@ -67,6 +68,6 @@ public class ConvertMultipartFileExample { multipartFile.transferTo(file); - Assert.assertEquals(FileUtils.readFileToString(new File("src/main/resources/targetFile.tmp"), "UTF-8"), "Hello World"); + assertThat(FileUtils.readFileToString(new File("src/main/resources/targetFile.tmp"), "UTF-8")).isEqualTo("Hello World"); } }