BAEL-3338: A Guide to AuthenticationManagerResolver in Spring Security

Fix indentation problems in code, do some renaming to sync article with code

spring-5-security/src/main/java/com/baeldung/authresolver/CustomWebSecurityConfigurer.java

@@ -1,12 +1,11 @@
 package com.baeldung.authresolver;
 
-import java.util.Arrays;
+import java.util.Collections;
 import javax.servlet.http.HttpServletRequest;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.security.authentication.AuthenticationManager;
 import org.springframework.security.authentication.AuthenticationManagerResolver;
 import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
-import org.springframework.security.config.annotation.authentication.builders.AuthenticationManagerBuilder;
 import org.springframework.security.config.annotation.web.builders.HttpSecurity;
 import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;
 import org.springframework.security.core.Authentication;
@@ -18,17 +17,18 @@ import org.springframework.security.web.authentication.www.BasicAuthenticationCo
 import org.springframework.security.web.authentication.www.BasicAuthenticationFilter;
 
 @Configuration
-public class AuthResolverWebSecurityConfigurer extends WebSecurityConfigurerAdapter {
+public class CustomWebSecurityConfigurer extends WebSecurityConfigurerAdapter {
 
     public AuthenticationConverter authenticationConverter() {
         return new BasicAuthenticationConverter();
     }
 
-    public AuthenticationManagerResolver<HttpServletRequest> authenticationManagerResolver() {
+    public AuthenticationManagerResolver<HttpServletRequest> resolver() {
         return request -> {
             if (request
               .getPathInfo()
-              .startsWith("/employee")) return employeesAuthenticationManager();
+              .startsWith("/employee"))
+                return employeesAuthenticationManager();
             return customersAuthenticationManager();
         };
     }
@@ -36,7 +36,11 @@ public class AuthResolverWebSecurityConfigurer extends WebSecurityConfigurerAdap
     public AuthenticationManager customersAuthenticationManager() {
         return authentication -> {
             if (isCustomer(authentication)) {
-                return new UsernamePasswordAuthenticationToken(authentication.getPrincipal(), authentication.getCredentials(), Arrays.asList(new SimpleGrantedAuthority("ROLE_USER")));
+                return new UsernamePasswordAuthenticationToken(
+                  authentication.getPrincipal(),
+                  authentication.getCredentials(),
+                  Collections.singletonList(new SimpleGrantedAuthority("ROLE_USER"))
+                );
             }
             throw new UsernameNotFoundException(authentication
               .getPrincipal()
@@ -44,31 +48,35 @@ public class AuthResolverWebSecurityConfigurer extends WebSecurityConfigurerAdap
         };
     }
 
-    public boolean isCustomer(Authentication authentication) {
+    private boolean isCustomer(Authentication authentication) {
         return (authentication
           .getPrincipal()
           .toString()
           .startsWith("customer"));
     }
 
-    public boolean isEmployee(Authentication authentication) {
+    private boolean isEmployee(Authentication authentication) {
         return (authentication
           .getPrincipal()
           .toString()
           .startsWith("employee"));
     }
 
-    public AuthenticationFilter authenticationFilter(AuthenticationManagerResolver<HttpServletRequest> resolver, AuthenticationConverter converter) {
-        AuthenticationFilter ret = new AuthenticationFilter(resolver, converter);
-        ret.setSuccessHandler((httpServletRequest, httpServletResponse, authentication) -> {
-        });
+    private AuthenticationFilter authenticationFilter() {
+        AuthenticationFilter ret = new AuthenticationFilter(
+          resolver(), authenticationConverter());
+        ret.setSuccessHandler((request, response, auth) -> {});
         return ret;
     }
 
-    public AuthenticationManager employeesAuthenticationManager() {
+    private AuthenticationManager employeesAuthenticationManager() {
         return authentication -> {
             if (isEmployee(authentication)) {
-                return new UsernamePasswordAuthenticationToken(authentication.getPrincipal(), authentication.getCredentials(), Arrays.asList(new SimpleGrantedAuthority("ROLE_USER")));
+                return new UsernamePasswordAuthenticationToken(
+                  authentication.getPrincipal(),
+                  authentication.getCredentials(),
+                  Collections.singletonList(new SimpleGrantedAuthority("ROLE_USER"))
+                );
             }
             throw new UsernameNotFoundException(authentication
               .getPrincipal()
@@ -77,16 +85,11 @@ public class AuthResolverWebSecurityConfigurer extends WebSecurityConfigurerAdap
     }
 
     @Override
-    protected void configure(HttpSecurity http) throws Exception {
-        http
-          .addFilterBefore(
-          authenticationFilter(
-            authenticationManagerResolver(), authenticationConverter()),
-          BasicAuthenticationFilter.class);
+    protected void configure(HttpSecurity http) {
+        http.addFilterBefore(
+          authenticationFilter(),
+          BasicAuthenticationFilter.class
+        );
     }
 
-    @Override
-    protected void configure(AuthenticationManagerBuilder auth) throws Exception {
-        super.configure(auth);
-    }
 }

spring-5-security/src/test/java/com/baeldung/authresolver/AuthResolverIntegrationTest.java

@@ -23,9 +23,11 @@ import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.
 @FixMethodOrder(MethodSorters.NAME_ASCENDING)
 public class AuthResolverIntegrationTest {
 
-    @Autowired private FilterChainProxy springSecurityFilterChain;
+    @Autowired
+    private FilterChainProxy springSecurityFilterChain;
 
-    @Autowired private WebApplicationContext wac;
+    @Autowired
+    private WebApplicationContext wac;
 
     private MockMvc mockMvc;