From 437efd7242b94e4a9570a2ef07e25698272905c0 Mon Sep 17 00:00:00 2001
From: Anshul Bansal <smartdiscover17@gmail.com>
Date: Wed, 10 Apr 2019 16:56:53 +0300
Subject: [PATCH] BAEL-2800_Copying_a_HashMap_in_Java

---
 .../com/baeldung/copyinghashmap/CopyHashMap.java | 16 ++++++++--------
 .../copyinghashmap/CopyHashMapUnitTest.java      |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/core-java-collections-map/src/main/java/com/baeldung/copyinghashmap/CopyHashMap.java b/core-java-collections-map/src/main/java/com/baeldung/copyinghashmap/CopyHashMap.java
index cd81f61b48..e1649f593c 100644
--- a/core-java-collections-map/src/main/java/com/baeldung/copyinghashmap/CopyHashMap.java
+++ b/core-java-collections-map/src/main/java/com/baeldung/copyinghashmap/CopyHashMap.java
@@ -19,29 +19,29 @@ public class CopyHashMap {
     }
 
     public static <String, Employee> HashMap<String, Employee> copyUsingPut(HashMap<String, Employee> originalMap) {
-        HashMap<String, Employee> copyMap = new HashMap<String, Employee>();
+        HashMap<String, Employee> shallowCopy = new HashMap<String, Employee>();
         Set<Entry<String, Employee>> entries = originalMap.entrySet();
         for(Map.Entry<String, Employee> mapEntry: entries) {
-            copyMap.put(mapEntry.getKey(), mapEntry.getValue());
+            shallowCopy.put(mapEntry.getKey(), mapEntry.getValue());
         }
         
-        return copyMap;
+        return shallowCopy;
     }
     
     public static <String, Employee> HashMap<String, Employee> copyUsingPutAll(HashMap<String, Employee> originalMap) {
-        HashMap<String, Employee> copyMap = new HashMap<String, Employee>();
-        copyMap.putAll(originalMap);
+        HashMap<String, Employee> shallowCopy = new HashMap<String, Employee>();
+        shallowCopy.putAll(originalMap);
         
-        return copyMap;
+        return shallowCopy;
     }
     
     public static <String, Employee> HashMap<String, Employee> copyUsingJava8Stream(HashMap<String, Employee> originalMap) {
         Set<Entry<String, Employee>> entries = originalMap.entrySet();
-        HashMap<String, Employee> copyMap = (HashMap<String, Employee>) entries
+        HashMap<String, Employee> shallowCopy = (HashMap<String, Employee>) entries
             .stream()
             .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
         
-        return copyMap;
+        return shallowCopy;
     }
     
     public static <String, Employee> HashMap<String, Employee> shallowCopy(HashMap<String, Employee> originalMap) {
diff --git a/core-java-collections-map/src/test/java/com/baeldung/copyinghashmap/CopyHashMapUnitTest.java b/core-java-collections-map/src/test/java/com/baeldung/copyinghashmap/CopyHashMapUnitTest.java
index c71e17e94e..400696d97a 100644
--- a/core-java-collections-map/src/test/java/com/baeldung/copyinghashmap/CopyHashMapUnitTest.java
+++ b/core-java-collections-map/src/test/java/com/baeldung/copyinghashmap/CopyHashMapUnitTest.java
@@ -68,9 +68,9 @@ public class CopyHashMapUnitTest {
             .put("emp1",emp1)
             .put("emp2",emp2)
             .build();
-        Map<String, Employee> mapCopy = ImmutableMap.copyOf(map);
+        Map<String, Employee> shallowCopy = ImmutableMap.copyOf(map);
         
-        assertThat(mapCopy).isSameAs(map);
+        assertThat(shallowCopy).isSameAs(map);
         
     }