From 4ba7ed5d80b6c4d58a0e0ac908b3f5686e1e6a64 Mon Sep 17 00:00:00 2001
From: danielmcnally285 <144589379+danielmcnally285@users.noreply.github.com>
Date: Fri, 29 Dec 2023 11:54:15 +0000
Subject: [PATCH 1/6] string to long primitive or long object unit tests
---
...ngToLongPrimitiveOrLongObjectUnitTest.java | 89 +++++++++++++++++++
1 file changed, 89 insertions(+)
create mode 100644 core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
diff --git a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
new file mode 100644
index 0000000000..50201c8e89
--- /dev/null
+++ b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
@@ -0,0 +1,89 @@
+package com.baeldung.stringtolong;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.apache.commons.lang3.math.NumberUtils;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import com.google.common.primitives.Longs;
+
+public class StringToLongPrimitiveOrLongObjectUnitTest {
+
+ @Test
+ public void givenString_whenUsingLongConstructor_thenObtainLongObject() {
+ Long l = new Long("123456");
+ assertThat(l).isEqualTo(123456L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingLongConstructor_thenNumberFormatExceptionThrown() {
+ Assertions.assertThrows(NumberFormatException.class, () -> new Long("Invalid String"));
+ }
+
+ @Test
+ public void givenString_whenUsingLongValueOf_thenObtainLongObject() {
+ Long l = Long.valueOf("123456");
+ assertThat(l).isEqualTo(123456L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingLongValueOf_thenNumberFormatExceptionThrown() {
+ Assertions.assertThrows(NumberFormatException.class, () -> Long.valueOf("Invalid String"));
+ }
+
+ @Test
+ public void givenString_whenUsingParseLong_thenObtainLongPrimitive() {
+ long l = Long.parseLong("123456");
+ assertThat(l).isEqualTo(123456L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingParseLong_thenNumberFormatExceptionThrown() {
+ Assertions.assertThrows(NumberFormatException.class, () -> Long.parseLong("Invalid String"));
+ }
+
+ @Test
+ public void givenHexadecimalString_whenUsingLongDecode_thenObtainLongObject() {
+ Long l = Long.decode("0x1e240");
+ assertThat(l).isEqualTo(123456L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingLongDecode_thenNumberFormatExceptionThrown() {
+ Assertions.assertThrows(NumberFormatException.class, () -> Long.decode("Invalid String"));
+ }
+
+ @Test
+ public void givenHexadecimalString_whenUsingApacheCommons_thenObtainLongObject() {
+ Long l = NumberUtils.createLong("0x1e240");
+ assertThat(l).isEqualTo(123456L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingApacheCommons_thenNumberFormatExceptionThrown() {
+ Assertions.assertThrows(NumberFormatException.class, () -> NumberUtils.createLong("Invalid String"));
+ }
+
+ @Test
+ public void givenString_whenUsingGuava_thenObtainLongObject() {
+ Long l = Longs.tryParse("123456");
+ assertThat(l).isEqualTo(123456L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingGuava_thenObtainNull() {
+ assertThat(Longs.tryParse("Invalid String")).isNull();
+ }
+
+ @Test
+ public void givenString_whenUsingParseUnsignedLong_thenObtainUnsignedLongObject() {
+ Long l = Long.parseUnsignedLong("9223372036854775808");
+ assertThat(Long.toUnsignedString(l)).isEqualTo("9223372036854775808");
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingParseUnsignedLong_thenNumberFormatExceptionThrown() {
+ Assertions.assertThrows(NumberFormatException.class, () -> Long.parseUnsignedLong("Invalid String"));
+ }
+}
\ No newline at end of file
From 0efd1c31069bf8b3e37e75438649ff44e1721c31 Mon Sep 17 00:00:00 2001
From: danielmcnally285 <144589379+danielmcnally285@users.noreply.github.com>
Date: Fri, 29 Dec 2023 12:57:12 +0000
Subject: [PATCH 2/6] Use 1234567 string for unit tests
---
...ngToLongPrimitiveOrLongObjectUnitTest.java | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
index 50201c8e89..50e184324c 100644
--- a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
+++ b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
@@ -12,8 +12,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingLongConstructor_thenObtainLongObject() {
- Long l = new Long("123456");
- assertThat(l).isEqualTo(123456L);
+ Long l = new Long("1234567");
+ assertThat(l).isEqualTo(1234567L);
}
@Test
@@ -23,8 +23,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingLongValueOf_thenObtainLongObject() {
- Long l = Long.valueOf("123456");
- assertThat(l).isEqualTo(123456L);
+ Long l = Long.valueOf("1234567");
+ assertThat(l).isEqualTo(1234567L);
}
@Test
@@ -34,8 +34,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingParseLong_thenObtainLongPrimitive() {
- long l = Long.parseLong("123456");
- assertThat(l).isEqualTo(123456L);
+ long l = Long.parseLong("1234567");
+ assertThat(l).isEqualTo(1234567L);
}
@Test
@@ -45,8 +45,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenHexadecimalString_whenUsingLongDecode_thenObtainLongObject() {
- Long l = Long.decode("0x1e240");
- assertThat(l).isEqualTo(123456L);
+ Long l = Long.decode("0x12d687");
+ assertThat(l).isEqualTo(1234567L);
}
@Test
@@ -56,8 +56,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenHexadecimalString_whenUsingApacheCommons_thenObtainLongObject() {
- Long l = NumberUtils.createLong("0x1e240");
- assertThat(l).isEqualTo(123456L);
+ Long l = NumberUtils.createLong("0x12d687");
+ assertThat(l).isEqualTo(1234567L);
}
@Test
@@ -67,8 +67,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingGuava_thenObtainLongObject() {
- Long l = Longs.tryParse("123456");
- assertThat(l).isEqualTo(123456L);
+ Long l = Longs.tryParse("1234567");
+ assertThat(l).isEqualTo(1234567L);
}
@Test
From 975db60d357704e684699b8a9ae8329c347fdfe6 Mon Sep 17 00:00:00 2001
From: danielmcnally285 <144589379+danielmcnally285@users.noreply.github.com>
Date: Fri, 29 Dec 2023 13:59:31 +0000
Subject: [PATCH 3/6] use 2147483648 as string for unit tests
---
...ngToLongPrimitiveOrLongObjectUnitTest.java | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
index 50e184324c..6db24ef2b3 100644
--- a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
+++ b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
@@ -12,8 +12,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingLongConstructor_thenObtainLongObject() {
- Long l = new Long("1234567");
- assertThat(l).isEqualTo(1234567L);
+ Long l = new Long("2147483648");
+ assertThat(l).isEqualTo(2147483648L);
}
@Test
@@ -23,8 +23,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingLongValueOf_thenObtainLongObject() {
- Long l = Long.valueOf("1234567");
- assertThat(l).isEqualTo(1234567L);
+ Long l = Long.valueOf("2147483648");
+ assertThat(l).isEqualTo(2147483648L);
}
@Test
@@ -34,8 +34,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingParseLong_thenObtainLongPrimitive() {
- long l = Long.parseLong("1234567");
- assertThat(l).isEqualTo(1234567L);
+ long l = Long.parseLong("2147483648");
+ assertThat(l).isEqualTo(2147483648L);
}
@Test
@@ -45,8 +45,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenHexadecimalString_whenUsingLongDecode_thenObtainLongObject() {
- Long l = Long.decode("0x12d687");
- assertThat(l).isEqualTo(1234567L);
+ Long l = Long.decode("0x80000000");
+ assertThat(l).isEqualTo(2147483648L);
}
@Test
@@ -56,8 +56,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenHexadecimalString_whenUsingApacheCommons_thenObtainLongObject() {
- Long l = NumberUtils.createLong("0x12d687");
- assertThat(l).isEqualTo(1234567L);
+ Long l = NumberUtils.createLong("0x80000000");
+ assertThat(l).isEqualTo(2147483648L);
}
@Test
@@ -67,8 +67,8 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
public void givenString_whenUsingGuava_thenObtainLongObject() {
- Long l = Longs.tryParse("1234567");
- assertThat(l).isEqualTo(1234567L);
+ Long l = Longs.tryParse("2147483648");
+ assertThat(l).isEqualTo(2147483648L);
}
@Test
From 90ebc6921c1487bbc97494e53113d16ec862e11a Mon Sep 17 00:00:00 2001
From: danielmcnally285 <144589379+danielmcnally285@users.noreply.github.com>
Date: Fri, 29 Dec 2023 14:58:56 +0000
Subject: [PATCH 4/6] rename unit test methods to be more precise
---
...ngToLongPrimitiveOrLongObjectUnitTest.java | 26 +++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
index 6db24ef2b3..99f0adf792 100644
--- a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
+++ b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
@@ -55,27 +55,16 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
}
@Test
- public void givenHexadecimalString_whenUsingApacheCommons_thenObtainLongObject() {
+ public void givenHexadecimalString_whenUsingApacheCommonsNumberUtils_thenObtainLongObject() {
Long l = NumberUtils.createLong("0x80000000");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingApacheCommons_thenNumberFormatExceptionThrown() {
+ public void givenInvalidString_whenUsingApacheCommonsNumberUtils_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> NumberUtils.createLong("Invalid String"));
}
- @Test
- public void givenString_whenUsingGuava_thenObtainLongObject() {
- Long l = Longs.tryParse("2147483648");
- assertThat(l).isEqualTo(2147483648L);
- }
-
- @Test
- public void givenInvalidString_whenUsingGuava_thenObtainNull() {
- assertThat(Longs.tryParse("Invalid String")).isNull();
- }
-
@Test
public void givenString_whenUsingParseUnsignedLong_thenObtainUnsignedLongObject() {
Long l = Long.parseUnsignedLong("9223372036854775808");
@@ -86,4 +75,15 @@ public class StringToLongPrimitiveOrLongObjectUnitTest {
public void givenInvalidString_whenUsingParseUnsignedLong_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> Long.parseUnsignedLong("Invalid String"));
}
+
+ @Test
+ public void givenString_whenUsingGuavaLongs_thenObtainLongObject() {
+ Long l = Longs.tryParse("2147483648");
+ assertThat(l).isEqualTo(2147483648L);
+ }
+
+ @Test
+ public void givenInvalidString_whenUsingGuavaLongs_thenObtainNull() {
+ assertThat(Longs.tryParse("Invalid String")).isNull();
+ }
}
\ No newline at end of file
From 36cbde1b9c14a02fb484c174903b7eba7a9b3aae Mon Sep 17 00:00:00 2001
From: danielmcnally285 <144589379+danielmcnally285@users.noreply.github.com>
Date: Sun, 31 Dec 2023 13:45:25 +0000
Subject: [PATCH 5/6] add relative path to core-java-modules
---
core-java-modules/pom.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/core-java-modules/pom.xml b/core-java-modules/pom.xml
index a661c11749..16d01dd1d3 100644
--- a/core-java-modules/pom.xml
+++ b/core-java-modules/pom.xml
@@ -12,6 +12,7 @@
com.baeldung
parent-modules
1.0.0-SNAPSHOT
+ ..
From 441d470b44173a4545d60ea94d8108bdb4ce81ae Mon Sep 17 00:00:00 2001
From: danielmcnally285 <144589379+danielmcnally285@users.noreply.github.com>
Date: Mon, 1 Jan 2024 17:43:08 +0000
Subject: [PATCH 6/6] remove public access modifier
---
...ngToLongPrimitiveOrLongObjectUnitTest.java | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
index 99f0adf792..e437529726 100644
--- a/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
+++ b/core-java-modules/core-java-string-conversions-3/src/test/java/com/baeldung/stringtolong/StringToLongPrimitiveOrLongObjectUnitTest.java
@@ -11,79 +11,79 @@ import com.google.common.primitives.Longs;
public class StringToLongPrimitiveOrLongObjectUnitTest {
@Test
- public void givenString_whenUsingLongConstructor_thenObtainLongObject() {
+ void givenString_whenUsingLongConstructor_thenObtainLongObject() {
Long l = new Long("2147483648");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingLongConstructor_thenNumberFormatExceptionThrown() {
+ void givenInvalidString_whenUsingLongConstructor_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> new Long("Invalid String"));
}
@Test
- public void givenString_whenUsingLongValueOf_thenObtainLongObject() {
+ void givenString_whenUsingLongValueOf_thenObtainLongObject() {
Long l = Long.valueOf("2147483648");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingLongValueOf_thenNumberFormatExceptionThrown() {
+ void givenInvalidString_whenUsingLongValueOf_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> Long.valueOf("Invalid String"));
}
@Test
- public void givenString_whenUsingParseLong_thenObtainLongPrimitive() {
+ void givenString_whenUsingParseLong_thenObtainLongPrimitive() {
long l = Long.parseLong("2147483648");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingParseLong_thenNumberFormatExceptionThrown() {
+ void givenInvalidString_whenUsingParseLong_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> Long.parseLong("Invalid String"));
}
@Test
- public void givenHexadecimalString_whenUsingLongDecode_thenObtainLongObject() {
+ void givenHexadecimalString_whenUsingLongDecode_thenObtainLongObject() {
Long l = Long.decode("0x80000000");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingLongDecode_thenNumberFormatExceptionThrown() {
+ void givenInvalidString_whenUsingLongDecode_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> Long.decode("Invalid String"));
}
@Test
- public void givenHexadecimalString_whenUsingApacheCommonsNumberUtils_thenObtainLongObject() {
+ void givenHexadecimalString_whenUsingApacheCommonsNumberUtils_thenObtainLongObject() {
Long l = NumberUtils.createLong("0x80000000");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingApacheCommonsNumberUtils_thenNumberFormatExceptionThrown() {
+ void givenInvalidString_whenUsingApacheCommonsNumberUtils_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> NumberUtils.createLong("Invalid String"));
}
@Test
- public void givenString_whenUsingParseUnsignedLong_thenObtainUnsignedLongObject() {
+ void givenString_whenUsingParseUnsignedLong_thenObtainUnsignedLongObject() {
Long l = Long.parseUnsignedLong("9223372036854775808");
assertThat(Long.toUnsignedString(l)).isEqualTo("9223372036854775808");
}
@Test
- public void givenInvalidString_whenUsingParseUnsignedLong_thenNumberFormatExceptionThrown() {
+ void givenInvalidString_whenUsingParseUnsignedLong_thenNumberFormatExceptionThrown() {
Assertions.assertThrows(NumberFormatException.class, () -> Long.parseUnsignedLong("Invalid String"));
}
@Test
- public void givenString_whenUsingGuavaLongs_thenObtainLongObject() {
+ void givenString_whenUsingGuavaLongs_thenObtainLongObject() {
Long l = Longs.tryParse("2147483648");
assertThat(l).isEqualTo(2147483648L);
}
@Test
- public void givenInvalidString_whenUsingGuavaLongs_thenObtainNull() {
+ void givenInvalidString_whenUsingGuavaLongs_thenObtainNull() {
assertThat(Longs.tryParse("Invalid String")).isNull();
}
}
\ No newline at end of file