From 65d6e0127fa31ae92f0aaa25a96ee9b6c4f2972e Mon Sep 17 00:00:00 2001
From: Graham Cox <graham@grahamcox.co.uk>
Date: Tue, 24 Oct 2017 12:51:14 +0100
Subject: [PATCH] Updated test names

---
 .../baeldung/kotlin/junit5/CalculatorTest5.kt | 20 +++++++++----------
 .../com/baeldung/kotlin/junit5/SimpleTest5.kt |  4 ++--
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/CalculatorTest5.kt b/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/CalculatorTest5.kt
index dd35805044..40cd9adc99 100644
--- a/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/CalculatorTest5.kt
+++ b/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/CalculatorTest5.kt
@@ -7,12 +7,12 @@ class CalculatorTest5 {
     private val calculator = Calculator()
 
     @Test
-    fun testAddition() {
+    fun whenAdding1and3_thenAnswerIs4() {
         Assertions.assertEquals(4, calculator.add(1, 3))
     }
 
     @Test
-    fun testDivideByZero() {
+    fun whenDividingBy0_thenErrorOccurs() {
         val exception = Assertions.assertThrows(DivideByZeroException::class.java) {
             calculator.divide(5, 0)
         }
@@ -21,7 +21,7 @@ class CalculatorTest5 {
     }
 
     @Test
-    fun testSquares() {
+    fun whenSquaringNumbers_thenCorrectAnswerGiven() {
         Assertions.assertAll(
                 Executable { Assertions.assertEquals(1, calculator.square(1)) },
                 Executable { Assertions.assertEquals(4, calculator.square(2)) },
@@ -31,9 +31,9 @@ class CalculatorTest5 {
 
     @TestFactory
     fun testSquaresFactory() = listOf(
-            DynamicTest.dynamicTest("1 squared") { Assertions.assertEquals(1,calculator.square(1))},
-            DynamicTest.dynamicTest("2 squared") { Assertions.assertEquals(4,calculator.square(2))},
-            DynamicTest.dynamicTest("3 squared") { Assertions.assertEquals(9,calculator.square(3))}
+            DynamicTest.dynamicTest("when I calculate 1^2 then I get 1") { Assertions.assertEquals(1,calculator.square(1))},
+            DynamicTest.dynamicTest("when I calculate 2^2 then I get 4") { Assertions.assertEquals(4,calculator.square(2))},
+            DynamicTest.dynamicTest("when I calculate 3^2 then I get 9") { Assertions.assertEquals(9,calculator.square(3))}
     )
 
     @TestFactory
@@ -44,7 +44,7 @@ class CalculatorTest5 {
             4 to 16,
             5 to 25)
             .map { (input, expected) ->
-                DynamicTest.dynamicTest("$input squared") {
+                DynamicTest.dynamicTest("when I calculate $input^2 then I get $expected") {
                     Assertions.assertEquals(expected, calculator.square(input))
                 }
             }
@@ -59,14 +59,14 @@ class CalculatorTest5 {
     @TestFactory
     fun testSquaresFactory3() = squaresTestData
             .map { (input, expected) ->
-                DynamicTest.dynamicTest("$input squared") {
+                DynamicTest.dynamicTest("when I calculate $input^2 then I get $expected") {
                     Assertions.assertEquals(expected, calculator.square(input))
                 }
             }
     @TestFactory
     fun testSquareRootsFactory3() = squaresTestData
             .map { (expected, input) ->
-                DynamicTest.dynamicTest("Square root of $input") {
+                DynamicTest.dynamicTest("I calculate the square root of $input then I get $expected") {
                     Assertions.assertEquals(expected.toDouble(), calculator.squareRoot(input))
                 }
             }
@@ -76,7 +76,7 @@ class CalculatorTest5 {
             Tag("logarithms")
     )
     @Test
-    fun testLogarithms() {
+    fun whenIcalculateLog2Of8_thenIget3() {
         Assertions.assertEquals(3.0, calculator.log(2, 8))
     }
 }
diff --git a/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/SimpleTest5.kt b/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/SimpleTest5.kt
index c04ab568f7..70d3fb90bf 100644
--- a/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/SimpleTest5.kt
+++ b/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/SimpleTest5.kt
@@ -6,14 +6,14 @@ import org.junit.jupiter.api.Test
 
 class SimpleTest5 {
     @Test
-    fun testEmpty() {
+    fun whenEmptyList_thenListIsEmpty() {
         val list = listOf<String>()
         Assertions.assertTrue(list::isEmpty)
     }
 
     @Test
     @Disabled
-    fun testMessage() {
+    fun when3equals4_thenTestFails() {
         Assertions.assertEquals(3, 4) {
             "Three does not equal four"
         }