JAVA-8637: addressing PR review comments.

This commit is contained in:
chaos2418
2021-11-23 09:14:57 +05:30
parent 58e6087b3d
commit 6ae07978cd
5 changed files with 7 additions and 12 deletions
@@ -25,8 +25,7 @@ public class SquareCalculatorUnitTest {
@Test
public void whenCalculatingSquareValueOnce_thenCacheDontHaveValues() {
for (int i = 10; i < 15; i++) {
assertFalse(cacheHelper.getSquareNumberCache()
.containsKey(i));
assertFalse(cacheHelper.getSquareNumberCache().containsKey(i));
LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i));
}
}
@@ -34,14 +33,12 @@ public class SquareCalculatorUnitTest {
@Test
public void whenCalculatingSquareValueAgain_thenCacheHasAllValues() {
for (int i = 10; i < 15; i++) {
assertFalse(cacheHelper.getSquareNumberCache()
.containsKey(i));
assertFalse(cacheHelper.getSquareNumberCache().containsKey(i));
LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i));
}
for (int i = 10; i < 15; i++) {
assertTrue(cacheHelper.getSquareNumberCache()
.containsKey(i));
assertTrue(cacheHelper.getSquareNumberCache().containsKey(i));
LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i) + "\n");
}
}