From 6dcdba8b3f0e7e04a539a0352bb2cf6d0b90ab04 Mon Sep 17 00:00:00 2001
From: "alexandru.borza" <alexandru.borza@tazz.ro>
Date: Fri, 24 Mar 2023 22:44:22 +0200
Subject: [PATCH] review

---
 .../timebaseduuid/JavaUUIDCreator.java        | 42 -------------------
 .../baeldung/timebaseduuid/UUIDCreator.java   | 41 ------------------
 .../timebaseduuid/UUIDCreatorBenchmark.java   |  2 +-
 3 files changed, 1 insertion(+), 84 deletions(-)
 delete mode 100644 core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/JavaUUIDCreator.java
 delete mode 100644 core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreator.java

diff --git a/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/JavaUUIDCreator.java b/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/JavaUUIDCreator.java
deleted file mode 100644
index 39308c8982..0000000000
--- a/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/JavaUUIDCreator.java
+++ /dev/null
@@ -1,42 +0,0 @@
-package com.baeldung.timebaseduuid;
-
-import com.fasterxml.uuid.Generators;
-import com.github.f4b6a3.uuid.UuidCreator;
-
-import java.util.UUID;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentMap;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicLong;
-
-public class JavaUUIDCreator {
-
-    public static void main(String[] args) throws InterruptedException {
-
-        int threadCount = 128;
-        int iterationCount = 100_000;
-        ConcurrentMap<UUID, Long> uuidMap = new ConcurrentHashMap<>();
-        AtomicLong collisionCount = new AtomicLong();
-        long startNanos = System.nanoTime();
-        CountDownLatch endLatch = new CountDownLatch(threadCount);
-
-        for (long i = 0; i < threadCount; i++) {
-            final long threadId = i;
-            new Thread(() -> {
-                for (long j = 0; j < iterationCount; j++) {
-                    UUID uuid = Generators.timeBasedGenerator().generate();
-                    Long existingUUID = uuidMap.put(uuid, (threadId * iterationCount) + j);
-                    if(existingUUID != null) {
-                        collisionCount.incrementAndGet();
-                    }
-                }
-                endLatch.countDown();
-            }).start();
-        }
-
-        endLatch.await();
-        System.out.println(threadCount * iterationCount + " UUIDs generated, " + collisionCount + " collisions in "
-                + TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos) + "ms");
-    }
-}
diff --git a/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreator.java b/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreator.java
deleted file mode 100644
index 8695a54bae..0000000000
--- a/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreator.java
+++ /dev/null
@@ -1,41 +0,0 @@
-package com.baeldung.timebaseduuid;
-
-import com.github.f4b6a3.uuid.UuidCreator;
-
-import java.util.UUID;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentMap;
-import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicLong;
-
-public class UUIDCreator {
-
-    public static void main(String[] args) throws InterruptedException {
-
-        int threadCount = 128;
-        int iterationCount = 100_000;
-        ConcurrentMap<UUID, Long> uuidMap = new ConcurrentHashMap<>();
-        AtomicLong collisionCount = new AtomicLong();
-        long startNanos = System.nanoTime();
-        CountDownLatch endLatch = new CountDownLatch(threadCount);
-
-        for (long i = 0; i < threadCount; i++) {
-            final long threadId = i;
-            new Thread(() -> {
-                for (long j = 0; j < iterationCount; j++) {
-                    UUID uuid = UuidCreator.getTimeBased();
-                    Long existingUUID = uuidMap.put(uuid, (threadId * iterationCount) + j);
-                    if(existingUUID != null) {
-                        collisionCount.incrementAndGet();
-                    }
-                }
-                endLatch.countDown();
-            }).start();
-        }
-
-        endLatch.await();
-        System.out.println(threadCount * iterationCount + " UUIDs generated, " + collisionCount + " collisions in "
-                + TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos) + "ms");
-    }
-}
diff --git a/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreatorBenchmark.java b/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreatorBenchmark.java
index d93cd73a25..952c6cdb54 100644
--- a/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreatorBenchmark.java
+++ b/core-java-modules/core-java-uuid/src/main/java/com/baeldung/timebaseduuid/UUIDCreatorBenchmark.java
@@ -22,7 +22,7 @@ public class UUIDCreatorBenchmark {
         CountDownLatch endLatch = new CountDownLatch(threadCount);
 
         for (long i = 0; i < threadCount; i++) {
-            long threadId = i;
+            final long threadId = i;
             new Thread(() -> {
                 for (long j = 0; j < iterationCount; j++) {
                     UUID uuid = UuidCreator.getTimeBased();