From 027cbaf9f99beca000ee3a3e9fe58f49e6c2f77d Mon Sep 17 00:00:00 2001 From: "press0@gmail.com" Date: Sat, 8 Oct 2022 21:41:57 -0500 Subject: [PATCH 1/5] simplify with comparingByValue() --- .../java/com/baeldung/map/mapmax/MapMax.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java index 8c33c857ee..99b57b398a 100644 --- a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java +++ b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java @@ -1,7 +1,11 @@ package com.baeldung.map.mapmax; -import java.util.*; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.Map; import java.util.Map.Entry; +import java.util.Optional; public class MapMax { @@ -34,15 +38,14 @@ public class MapMax { public > V maxUsingCollectionsMaxAndLambda(Map map) { - Entry maxEntry = Collections.max(map.entrySet(), (Entry e1, Entry e2) -> e1.getValue() - .compareTo(e2.getValue())); + Entry maxEntry = Collections.max(map.entrySet(), Entry.comparingByValue()); return maxEntry.getValue(); } public > V maxUsingCollectionsMaxAndMethodReference(Map map) { - Entry maxEntry = Collections.max(map.entrySet(), Comparator.comparing(Map.Entry::getValue)); + Entry maxEntry = Collections.max(map.entrySet(), Entry.comparingByValue()); return maxEntry.getValue(); } @@ -51,8 +54,7 @@ public class MapMax { Optional> maxEntry = map.entrySet() .stream() - .max((Entry e1, Entry e2) -> e1.getValue() - .compareTo(e2.getValue())); + .max(Entry.comparingByValue()); return maxEntry.get() .getValue(); @@ -62,7 +64,7 @@ public class MapMax { Optional> maxEntry = map.entrySet() .stream() - .max(Comparator.comparing(Map.Entry::getValue)); + .max(Entry.comparingByValue()); return maxEntry.get() .getValue(); From 1ad0c04839f6cf94154c359bd5f74b69ed45d711 Mon Sep 17 00:00:00 2001 From: "press0@gmail.com" Date: Sat, 8 Oct 2022 22:13:18 -0500 Subject: [PATCH 2/5] simplify with comparingByValue() --- .../src/main/java/com/baeldung/map/mapmax/MapMax.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java index 99b57b398a..11443865c7 100644 --- a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java +++ b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java @@ -1,7 +1,6 @@ package com.baeldung.map.mapmax; import java.util.Collections; -import java.util.Comparator; import java.util.HashMap; import java.util.Map; import java.util.Map.Entry; @@ -26,12 +25,7 @@ public class MapMax { public > V maxUsingCollectionsMax(Map map) { - Entry maxEntry = Collections.max(map.entrySet(), new Comparator>() { - public int compare(Entry e1, Entry e2) { - return e1.getValue() - .compareTo(e2.getValue()); - } - }); + Entry maxEntry = Collections.max(map.entrySet(), Entry.comparingByValue()); return maxEntry.getValue(); } @@ -72,7 +66,7 @@ public class MapMax { public static void main(String[] args) { - Map map = new HashMap(); + Map map = new HashMap<>(); map.put(1, 3); map.put(2, 4); From 5eab831bb568a895ce056a627079be30cda5e6a7 Mon Sep 17 00:00:00 2001 From: "press0@gmail.com" Date: Sat, 8 Oct 2022 22:30:21 -0500 Subject: [PATCH 3/5] . --- .../java/com/baeldung/map/mapmax/MapMax.java | 35 ++++++++++--------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java index 11443865c7..36b839ad5f 100644 --- a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java +++ b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java @@ -1,6 +1,7 @@ package com.baeldung.map.mapmax; import java.util.Collections; +import java.util.Comparator; import java.util.HashMap; import java.util.Map; import java.util.Map.Entry; @@ -25,48 +26,48 @@ public class MapMax { public > V maxUsingCollectionsMax(Map map) { - Entry maxEntry = Collections.max(map.entrySet(), Entry.comparingByValue()); - + Entry maxEntry = Collections.max(map.entrySet(), new Comparator>() { + public int compare(Entry e1, Entry e2) { + return e1.getValue() + .compareTo(e2.getValue()); + } + }); return maxEntry.getValue(); } public > V maxUsingCollectionsMaxAndLambda(Map map) { - - Entry maxEntry = Collections.max(map.entrySet(), Entry.comparingByValue()); - + Entry maxEntry = Collections.max(map.entrySet(), (Entry e1, Entry e2) -> e1.getValue() + .compareTo(e2.getValue())); return maxEntry.getValue(); } public > V maxUsingCollectionsMaxAndMethodReference(Map map) { - Entry maxEntry = Collections.max(map.entrySet(), Entry.comparingByValue()); + Entry maxEntry = Collections.max(map.entrySet(), Comparator.comparing(Map.Entry::getValue)); return maxEntry.getValue(); } public > V maxUsingStreamAndLambda(Map map) { - Optional> maxEntry = map.entrySet() - .stream() - .max(Entry.comparingByValue()); + .stream() + .max((Entry e1, Entry e2) -> e1.getValue() + .compareTo(e2.getValue())); - return maxEntry.get() - .getValue(); + return maxEntry.get().getValue(); } public > V maxUsingStreamAndMethodReference(Map map) { - Optional> maxEntry = map.entrySet() - .stream() - .max(Entry.comparingByValue()); - + .stream() + .max(Comparator.comparing(Map.Entry::getValue)); return maxEntry.get() - .getValue(); + .getValue(); } public static void main(String[] args) { - Map map = new HashMap<>(); + Map map = new HashMap(); map.put(1, 3); map.put(2, 4); From 57b666b08564ec71799ff5c1e7e8b8ea5fa31f70 Mon Sep 17 00:00:00 2001 From: "press0@gmail.com" Date: Tue, 8 Nov 2022 07:32:12 -0600 Subject: [PATCH 4/5] fix logger class ref --- .../RunnableCompletionCheckerWithThreadPoolExecutor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-java-modules/core-java-concurrency-2/src/main/java/com/baeldung/donerunnables/RunnableCompletionCheckerWithThreadPoolExecutor.java b/core-java-modules/core-java-concurrency-2/src/main/java/com/baeldung/donerunnables/RunnableCompletionCheckerWithThreadPoolExecutor.java index 17a13a1c19..aba75c5a3d 100644 --- a/core-java-modules/core-java-concurrency-2/src/main/java/com/baeldung/donerunnables/RunnableCompletionCheckerWithThreadPoolExecutor.java +++ b/core-java-modules/core-java-concurrency-2/src/main/java/com/baeldung/donerunnables/RunnableCompletionCheckerWithThreadPoolExecutor.java @@ -12,7 +12,7 @@ import org.slf4j.LoggerFactory; public class RunnableCompletionCheckerWithThreadPoolExecutor { - private static final Logger LOGGER = LoggerFactory.getLogger(RunnableCompletionCheckerWithCompletableFuture.class); + private static final Logger LOGGER = LoggerFactory.getLogger(RunnableCompletionCheckerWithThreadPoolExecutor.class); private static final int NUMBER_OF_RUNNABLES = 5; private static final int PAUSE_MILLIS = 1000; private static final int NUMBER_OF_THREADS = 5; From 7d1c17443b366fb57e18eb3a19dffe14af8ffc0c Mon Sep 17 00:00:00 2001 From: "press0@gmail.com" Date: Tue, 8 Nov 2022 07:49:28 -0600 Subject: [PATCH 5/5] revert MapMax --- .../java/com/baeldung/map/mapmax/MapMax.java | 29 ++++++++++--------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java index 36b839ad5f..8c33c857ee 100644 --- a/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java +++ b/core-java-modules/core-java-collections-maps-2/src/main/java/com/baeldung/map/mapmax/MapMax.java @@ -1,11 +1,7 @@ package com.baeldung.map.mapmax; -import java.util.Collections; -import java.util.Comparator; -import java.util.HashMap; -import java.util.Map; +import java.util.*; import java.util.Map.Entry; -import java.util.Optional; public class MapMax { @@ -29,15 +25,18 @@ public class MapMax { Entry maxEntry = Collections.max(map.entrySet(), new Comparator>() { public int compare(Entry e1, Entry e2) { return e1.getValue() - .compareTo(e2.getValue()); + .compareTo(e2.getValue()); } }); + return maxEntry.getValue(); } public > V maxUsingCollectionsMaxAndLambda(Map map) { + Entry maxEntry = Collections.max(map.entrySet(), (Entry e1, Entry e2) -> e1.getValue() - .compareTo(e2.getValue())); + .compareTo(e2.getValue())); + return maxEntry.getValue(); } @@ -49,20 +48,24 @@ public class MapMax { } public > V maxUsingStreamAndLambda(Map map) { + Optional> maxEntry = map.entrySet() - .stream() - .max((Entry e1, Entry e2) -> e1.getValue() + .stream() + .max((Entry e1, Entry e2) -> e1.getValue() .compareTo(e2.getValue())); - return maxEntry.get().getValue(); + return maxEntry.get() + .getValue(); } public > V maxUsingStreamAndMethodReference(Map map) { + Optional> maxEntry = map.entrySet() - .stream() - .max(Comparator.comparing(Map.Entry::getValue)); + .stream() + .max(Comparator.comparing(Map.Entry::getValue)); + return maxEntry.get() - .getValue(); + .getValue(); } public static void main(String[] args) {