From 8c3099d7123926eb137b73bb3b2b39dec480b05a Mon Sep 17 00:00:00 2001 From: Philippe Soares Date: Sun, 12 Jan 2020 17:31:59 -0500 Subject: [PATCH] Added comments on unit tests. --- .../java/com/baeldung/lock/FileLocksTest.java | 25 +++++++++++++------ 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/lock/FileLocksTest.java b/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/lock/FileLocksTest.java index 4d9fbadaca..ff20dd61b1 100644 --- a/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/lock/FileLocksTest.java +++ b/core-java-modules/core-java-nio-2/src/test/java/com/baeldung/lock/FileLocksTest.java @@ -26,7 +26,7 @@ class FileLocksTest { } /** - * Getting and exclusive lock from a RandomAccessFile + * Getting an exclusive lock from a RandomAccessFile * @throws IOException */ @Test @@ -48,6 +48,18 @@ class FileLocksTest { } + // Shared locks + + /** + * Getting a shared (read) lock on the entire file. + * Fails when getting the lock from a FileChannel obtained through a FileOutputStream. + */ + @Test + void givenAFileOutputStream_whenGetSharedLock_throwNonReadableChannelException() { + assertThrows(NonReadableChannelException.class, + () -> FileLocks.getReadLockFromOutputStream(0, 10)); + } + /** * Getting a shared (read) lock works fine when getting the lock from a FileChannel obtained through a FileInputStream. * @throws IOException @@ -60,13 +72,10 @@ class FileLocksTest { } - - @Test - void givenAFileOutputStream_whenGetSharedLock_throwNonReadableChannelException() { - assertThrows(NonReadableChannelException.class, - () -> FileLocks.getReadLockFromOutputStream(0, 10)); - } - + /** + * Getting a shared lock from a RandomAccessFile + * @throws IOException + */ @Test void givenARandomAccessFile_whenGetSharedLock_lock() throws IOException { FileLock lock = FileLocks.getReadLockFromRandomAccessFile(0, 10);