From b1df5621624982756fc8dc7ac3d20e1650d7b28f Mon Sep 17 00:00:00 2001 From: "ICKostiantyn.Ivanov" Date: Wed, 17 Jan 2024 11:14:14 +0100 Subject: [PATCH 1/4] BAEL-7453 - Convert byte[] to Byte[] and Vice Versa in Java --- ...ByteArrayToPrimitiveByteArrayUnitTest.java | 38 ++++++++++++++ ...PrimitiveByteArrayToByteArrayUnitTest.java | 49 +++++++++++++++++++ 2 files changed, 87 insertions(+) create mode 100644 core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java create mode 100644 core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java new file mode 100644 index 0000000000..89c4ae7da2 --- /dev/null +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java @@ -0,0 +1,38 @@ +package com.baeldung.array.conversions; + +import org.apache.commons.lang3.ArrayUtils; +import org.assertj.core.api.Assertions; +import org.junit.jupiter.api.Test; + +class ByteArrayToPrimitiveByteArrayUnitTest { + public static byte[] expectedArrayValues = {65, 66, 67, 68}; + public static Byte[] byteArray = {65, 66, 67, 68}; + + @Test + void givenByteArray_whenConvertingUsingByteValue_thenGiveExpectedResult() { + byte[] newByteArray = new byte[byteArray.length]; + for (int i = 0; i < byteArray.length; i++) { + newByteArray[i] = byteArray[i].byteValue(); + } + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } + + @Test + void givenByteArray_whenConvertingUsingUnboxing_thenGiveExpectedResult() { + byte[] newByteArray = new byte[byteArray.length]; + for (int i = 0; i < byteArray.length; i++) { + newByteArray[i] = byteArray[i]; + } + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } + + @Test + void givenByteArray_whenConvertingArrayUtils_thenGiveExpectedResult() { + byte[] newByteArray = ArrayUtils.toPrimitive(byteArray); + + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } +} diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java new file mode 100644 index 0000000000..06f8fc2fe4 --- /dev/null +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java @@ -0,0 +1,49 @@ +package com.baeldung.array.conversions; + +import java.util.Arrays; + +import org.apache.commons.lang3.ArrayUtils; +import org.assertj.core.api.Assertions; +import org.junit.jupiter.api.Test; + +class PrimitiveByteArrayToByteArrayUnitTest { + public static byte[] primitiveByteArray = {65, 66, 67, 68}; + public static Byte[] expectedArrayValues = {65, 66, 67, 68}; + + @Test + void givenPrimitiveByteArray_whenConvertingUsingByteValueOf_thenGiveExpectedResult() { + Byte[] newByteArray = new Byte[primitiveByteArray.length]; + for (int i = 0; i < primitiveByteArray.length; i++) { + newByteArray[i] = Byte.valueOf(primitiveByteArray[i]); + } + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } + + @Test + void givenPrimitiveByteArray_whenConvertingUsingAutoboxing_thenGiveExpectedResult() { + Byte[] newByteArray = new Byte[primitiveByteArray.length]; + for (int i = 0; i < primitiveByteArray.length; i++) { + newByteArray[i] = primitiveByteArray[i]; + } + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } + + @Test + void givenPrimitiveByteArray_whenConvertingUsingAutoboxingAndArraysSetAll_thenGiveExpectedResult() { + Byte[] newByteArray = new Byte[primitiveByteArray.length]; + Arrays.setAll(newByteArray, n -> primitiveByteArray[n]); + + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } + + @Test + void givenPrimitiveByteArray_whenConvertingUsingArrayUtils_thenGiveExpectedResult() { + Byte[] newByteArray = ArrayUtils.toObject(primitiveByteArray); + + Assertions.assertThat(newByteArray) + .containsExactly(expectedArrayValues); + } +} From bd1239c699d14050e5f3bca84138e775425a42ee Mon Sep 17 00:00:00 2001 From: "ICKostiantyn.Ivanov" Date: Wed, 17 Jan 2024 11:18:45 +0100 Subject: [PATCH 2/4] BAEL-7453 - Fix modifiers and naming for test classes fields --- ...ByteArrayToPrimitiveByteArrayUnitTest.java | 24 +++++++-------- ...PrimitiveByteArrayToByteArrayUnitTest.java | 30 +++++++++---------- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java index 89c4ae7da2..edad1026f1 100644 --- a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java @@ -5,34 +5,34 @@ import org.assertj.core.api.Assertions; import org.junit.jupiter.api.Test; class ByteArrayToPrimitiveByteArrayUnitTest { - public static byte[] expectedArrayValues = {65, 66, 67, 68}; - public static Byte[] byteArray = {65, 66, 67, 68}; + private static final byte[] EXPECTED_ARRAY_VALUES = {65, 66, 67, 68}; + private static final Byte[] BYTE_ARRAY = {65, 66, 67, 68}; @Test void givenByteArray_whenConvertingUsingByteValue_thenGiveExpectedResult() { - byte[] newByteArray = new byte[byteArray.length]; - for (int i = 0; i < byteArray.length; i++) { - newByteArray[i] = byteArray[i].byteValue(); + byte[] newByteArray = new byte[BYTE_ARRAY.length]; + for (int i = 0; i < BYTE_ARRAY.length; i++) { + newByteArray[i] = BYTE_ARRAY[i].byteValue(); } Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } @Test void givenByteArray_whenConvertingUsingUnboxing_thenGiveExpectedResult() { - byte[] newByteArray = new byte[byteArray.length]; - for (int i = 0; i < byteArray.length; i++) { - newByteArray[i] = byteArray[i]; + byte[] newByteArray = new byte[BYTE_ARRAY.length]; + for (int i = 0; i < BYTE_ARRAY.length; i++) { + newByteArray[i] = BYTE_ARRAY[i]; } Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } @Test void givenByteArray_whenConvertingArrayUtils_thenGiveExpectedResult() { - byte[] newByteArray = ArrayUtils.toPrimitive(byteArray); + byte[] newByteArray = ArrayUtils.toPrimitive(BYTE_ARRAY); Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } } diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java index 06f8fc2fe4..a04ff9583c 100644 --- a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java @@ -7,43 +7,43 @@ import org.assertj.core.api.Assertions; import org.junit.jupiter.api.Test; class PrimitiveByteArrayToByteArrayUnitTest { - public static byte[] primitiveByteArray = {65, 66, 67, 68}; - public static Byte[] expectedArrayValues = {65, 66, 67, 68}; + private static final byte[] PRIMITIVE_BYTE_ARRAY = {65, 66, 67, 68}; + private static final Byte[] EXPECTED_ARRAY_VALUES = {65, 66, 67, 68}; @Test void givenPrimitiveByteArray_whenConvertingUsingByteValueOf_thenGiveExpectedResult() { - Byte[] newByteArray = new Byte[primitiveByteArray.length]; - for (int i = 0; i < primitiveByteArray.length; i++) { - newByteArray[i] = Byte.valueOf(primitiveByteArray[i]); + Byte[] newByteArray = new Byte[PRIMITIVE_BYTE_ARRAY.length]; + for (int i = 0; i < PRIMITIVE_BYTE_ARRAY.length; i++) { + newByteArray[i] = Byte.valueOf(PRIMITIVE_BYTE_ARRAY[i]); } Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } @Test void givenPrimitiveByteArray_whenConvertingUsingAutoboxing_thenGiveExpectedResult() { - Byte[] newByteArray = new Byte[primitiveByteArray.length]; - for (int i = 0; i < primitiveByteArray.length; i++) { - newByteArray[i] = primitiveByteArray[i]; + Byte[] newByteArray = new Byte[PRIMITIVE_BYTE_ARRAY.length]; + for (int i = 0; i < PRIMITIVE_BYTE_ARRAY.length; i++) { + newByteArray[i] = PRIMITIVE_BYTE_ARRAY[i]; } Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } @Test void givenPrimitiveByteArray_whenConvertingUsingAutoboxingAndArraysSetAll_thenGiveExpectedResult() { - Byte[] newByteArray = new Byte[primitiveByteArray.length]; - Arrays.setAll(newByteArray, n -> primitiveByteArray[n]); + Byte[] newByteArray = new Byte[PRIMITIVE_BYTE_ARRAY.length]; + Arrays.setAll(newByteArray, n -> PRIMITIVE_BYTE_ARRAY[n]); Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } @Test void givenPrimitiveByteArray_whenConvertingUsingArrayUtils_thenGiveExpectedResult() { - Byte[] newByteArray = ArrayUtils.toObject(primitiveByteArray); + Byte[] newByteArray = ArrayUtils.toObject(PRIMITIVE_BYTE_ARRAY); Assertions.assertThat(newByteArray) - .containsExactly(expectedArrayValues); + .containsExactly(EXPECTED_ARRAY_VALUES); } } From d6f5abfe6a07f070a1c28af9bfab807acd6cc583 Mon Sep 17 00:00:00 2001 From: "ICKostiantyn.Ivanov" Date: Thu, 18 Jan 2024 14:09:06 +0100 Subject: [PATCH 3/4] BAEL-7453 - Add access modifiers to methods and classes. Add Assertions class static import --- ...ByteArrayToPrimitiveByteArrayUnitTest.java | 17 ++++++++------- ...PrimitiveByteArrayToByteArrayUnitTest.java | 21 ++++++++++--------- 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java index edad1026f1..859b54fbf6 100644 --- a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java @@ -1,38 +1,39 @@ package com.baeldung.array.conversions; +import static org.assertj.core.api.Assertions.assertThat; + import org.apache.commons.lang3.ArrayUtils; -import org.assertj.core.api.Assertions; import org.junit.jupiter.api.Test; -class ByteArrayToPrimitiveByteArrayUnitTest { +public class ByteArrayToPrimitiveByteArrayUnitTest { private static final byte[] EXPECTED_ARRAY_VALUES = {65, 66, 67, 68}; private static final Byte[] BYTE_ARRAY = {65, 66, 67, 68}; @Test - void givenByteArray_whenConvertingUsingByteValue_thenGiveExpectedResult() { + public void givenByteArray_whenConvertingUsingByteValue_thenGiveExpectedResult() { byte[] newByteArray = new byte[BYTE_ARRAY.length]; for (int i = 0; i < BYTE_ARRAY.length; i++) { newByteArray[i] = BYTE_ARRAY[i].byteValue(); } - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } @Test - void givenByteArray_whenConvertingUsingUnboxing_thenGiveExpectedResult() { + public void givenByteArray_whenConvertingUsingUnboxing_thenGiveExpectedResult() { byte[] newByteArray = new byte[BYTE_ARRAY.length]; for (int i = 0; i < BYTE_ARRAY.length; i++) { newByteArray[i] = BYTE_ARRAY[i]; } - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } @Test - void givenByteArray_whenConvertingArrayUtils_thenGiveExpectedResult() { + public void givenByteArray_whenConvertingArrayUtils_thenGiveExpectedResult() { byte[] newByteArray = ArrayUtils.toPrimitive(BYTE_ARRAY); - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } } diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java index a04ff9583c..40cf3aec34 100644 --- a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java @@ -1,49 +1,50 @@ package com.baeldung.array.conversions; +import static org.assertj.core.api.Assertions.assertThat; + import java.util.Arrays; import org.apache.commons.lang3.ArrayUtils; -import org.assertj.core.api.Assertions; import org.junit.jupiter.api.Test; -class PrimitiveByteArrayToByteArrayUnitTest { +public class PrimitiveByteArrayToByteArrayUnitTest { private static final byte[] PRIMITIVE_BYTE_ARRAY = {65, 66, 67, 68}; private static final Byte[] EXPECTED_ARRAY_VALUES = {65, 66, 67, 68}; @Test - void givenPrimitiveByteArray_whenConvertingUsingByteValueOf_thenGiveExpectedResult() { + public void givenPrimitiveByteArray_whenConvertingUsingByteValueOf_thenGiveExpectedResult() { Byte[] newByteArray = new Byte[PRIMITIVE_BYTE_ARRAY.length]; for (int i = 0; i < PRIMITIVE_BYTE_ARRAY.length; i++) { newByteArray[i] = Byte.valueOf(PRIMITIVE_BYTE_ARRAY[i]); } - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } @Test - void givenPrimitiveByteArray_whenConvertingUsingAutoboxing_thenGiveExpectedResult() { + public void givenPrimitiveByteArray_whenConvertingUsingAutoboxing_thenGiveExpectedResult() { Byte[] newByteArray = new Byte[PRIMITIVE_BYTE_ARRAY.length]; for (int i = 0; i < PRIMITIVE_BYTE_ARRAY.length; i++) { newByteArray[i] = PRIMITIVE_BYTE_ARRAY[i]; } - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } @Test - void givenPrimitiveByteArray_whenConvertingUsingAutoboxingAndArraysSetAll_thenGiveExpectedResult() { + public void givenPrimitiveByteArray_whenConvertingUsingAutoboxingAndArraysSetAll_thenGiveExpectedResult() { Byte[] newByteArray = new Byte[PRIMITIVE_BYTE_ARRAY.length]; Arrays.setAll(newByteArray, n -> PRIMITIVE_BYTE_ARRAY[n]); - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } @Test - void givenPrimitiveByteArray_whenConvertingUsingArrayUtils_thenGiveExpectedResult() { + public void givenPrimitiveByteArray_whenConvertingUsingArrayUtils_thenGiveExpectedResult() { Byte[] newByteArray = ArrayUtils.toObject(PRIMITIVE_BYTE_ARRAY); - Assertions.assertThat(newByteArray) + assertThat(newByteArray) .containsExactly(EXPECTED_ARRAY_VALUES); } } From d5eaf1d6cc4cdaff11d2759ae8d6b8d30a262375 Mon Sep 17 00:00:00 2001 From: "ICKostiantyn.Ivanov" Date: Fri, 19 Jan 2024 10:30:10 +0100 Subject: [PATCH 4/4] BAEL-7453 - Remove the linebreak in assertions --- .../ByteArrayToPrimitiveByteArrayUnitTest.java | 9 +++------ .../PrimitiveByteArrayToByteArrayUnitTest.java | 9 +++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java index 859b54fbf6..758fe74685 100644 --- a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/ByteArrayToPrimitiveByteArrayUnitTest.java @@ -15,8 +15,7 @@ public class ByteArrayToPrimitiveByteArrayUnitTest { for (int i = 0; i < BYTE_ARRAY.length; i++) { newByteArray[i] = BYTE_ARRAY[i].byteValue(); } - assertThat(newByteArray) - .containsExactly(EXPECTED_ARRAY_VALUES); + assertThat(newByteArray).containsExactly(EXPECTED_ARRAY_VALUES); } @Test @@ -25,15 +24,13 @@ public class ByteArrayToPrimitiveByteArrayUnitTest { for (int i = 0; i < BYTE_ARRAY.length; i++) { newByteArray[i] = BYTE_ARRAY[i]; } - assertThat(newByteArray) - .containsExactly(EXPECTED_ARRAY_VALUES); + assertThat(newByteArray).containsExactly(EXPECTED_ARRAY_VALUES); } @Test public void givenByteArray_whenConvertingArrayUtils_thenGiveExpectedResult() { byte[] newByteArray = ArrayUtils.toPrimitive(BYTE_ARRAY); - assertThat(newByteArray) - .containsExactly(EXPECTED_ARRAY_VALUES); + assertThat(newByteArray).containsExactly(EXPECTED_ARRAY_VALUES); } } diff --git a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java index 40cf3aec34..8c0bd4401c 100644 --- a/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java +++ b/core-java-modules/core-java-arrays-convert/src/test/java/com/baeldung/array/conversions/PrimitiveByteArrayToByteArrayUnitTest.java @@ -17,8 +17,7 @@ public class PrimitiveByteArrayToByteArrayUnitTest { for (int i = 0; i < PRIMITIVE_BYTE_ARRAY.length; i++) { newByteArray[i] = Byte.valueOf(PRIMITIVE_BYTE_ARRAY[i]); } - assertThat(newByteArray) - .containsExactly(EXPECTED_ARRAY_VALUES); + assertThat(newByteArray).containsExactly(EXPECTED_ARRAY_VALUES); } @Test @@ -27,8 +26,7 @@ public class PrimitiveByteArrayToByteArrayUnitTest { for (int i = 0; i < PRIMITIVE_BYTE_ARRAY.length; i++) { newByteArray[i] = PRIMITIVE_BYTE_ARRAY[i]; } - assertThat(newByteArray) - .containsExactly(EXPECTED_ARRAY_VALUES); + assertThat(newByteArray).containsExactly(EXPECTED_ARRAY_VALUES); } @Test @@ -44,7 +42,6 @@ public class PrimitiveByteArrayToByteArrayUnitTest { public void givenPrimitiveByteArray_whenConvertingUsingArrayUtils_thenGiveExpectedResult() { Byte[] newByteArray = ArrayUtils.toObject(PRIMITIVE_BYTE_ARRAY); - assertThat(newByteArray) - .containsExactly(EXPECTED_ARRAY_VALUES); + assertThat(newByteArray).containsExactly(EXPECTED_ARRAY_VALUES); } }