BAEL-5246: pom cleanup (#4620)

* BAEL-5246: round 1 of pom cleanup - upto "jersey" project

* BAEL-5246: Initial pass for pom cleanup - upto spring-cloud

* BAEL-5246: pom cleanup upto testing-modules/junit5

* BAEL-5246: pom cleanup - upto xstream

* BAEL-5246: pom cleanup - last round (before review)

pom.xml

@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+
     <groupId>com.baeldung</groupId>
     <artifactId>parent-modules</artifactId>
     <version>1.0.0-SNAPSHOT</version>
@@ -367,19 +368,19 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>${maven-compiler-plugin.version}</version>
                 <configuration>
-                    <source>1.8</source>
-                    <target>1.8</target>
+                    <source>${java.version}</source>
+                    <target>${java.version}</target>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-pmd-plugin</artifactId>
-                <version>3.8</version>
+                <version>${maven-pmd-plugin.version}</version>
 				<dependencies>
                     <dependency>
                         <groupId>org.baeldung.pmd</groupId>
                         <artifactId>custom-pmd</artifactId>
-                        <version>0.0.1</version>
+                        <version>${custom-pmd.version}</version>
                     </dependency>
                 </dependencies>
                 <configuration>
@@ -390,7 +391,7 @@
                     <linkXRef>true</linkXRef>
                     <includeTests>true</includeTests>
                     <sourceEncoding>UTF-8</sourceEncoding>
-                    <targetJdk>1.8</targetJdk>
+                    <targetJdk>${java.version}</targetJdk>
                     <rulesets>
                         <ruleset>${tutorialsproject.basedir}/baeldung-pmd-rules.xml</ruleset>
                     </rulesets>
@@ -410,7 +411,7 @@
             <plugin>
                 <groupId>org.commonjava.maven.plugins</groupId>
                 <artifactId>directory-maven-plugin</artifactId>
-                <version>0.3.1</version>
+                <version>${directory-maven-plugin.version}</version>
                 <executions>
                     <execution>
                         <id>directories</id>
@@ -431,13 +432,13 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-install-plugin</artifactId>
-                <version>2.5.1</version>
+                <version>${maven-install-plugin.version}</version>
                 <configuration>
                     <groupId>org.baeldung.pmd</groupId>
                     <artifactId>custom-pmd</artifactId>
-                    <version>0.0.1</version>
+                    <version>${custom-pmd.version}</version>
                     <packaging>jar</packaging>
-                    <file>${tutorialsproject.basedir}/custom-pmd-0.0.1.jar</file>
+                    <file>${tutorialsproject.basedir}/custom-pmd-${custom-pmd.version}.jar</file>
                     <generatePom>true</generatePom>
                 </configuration>
                 <executions>
@@ -451,15 +452,13 @@
                 </executions>
             </plugin>
         </plugins>
-
         <extensions>
             <extension>
                 <groupId>com.vackosar.gitflowincrementalbuilder</groupId>
                 <artifactId>gitflow-incremental-builder</artifactId>
-                <version>3.4</version>
+                <version>${gitflow-incremental-builder.version}</version>
             </extension>
         </extensions>
-
     </build>
 
     <profiles>
@@ -504,13 +503,14 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jxr-plugin</artifactId>
-                <version>2.3</version>
+                <version>${maven-jxr-plugin.version}</version>
             </plugin>
         </plugins>
     </reporting>
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <gib.referenceBranch>refs/heads/master</gib.referenceBranch>
         <gib.skipTestsForNotImpactedModules>true</gib.skipTestsForNotImpactedModules>
         <gib.failOnMissingGitDir>false</gib.failOnMissingGitDir>
@@ -546,5 +546,13 @@
         <jackson-databind.version>2.5.0</jackson-databind.version>
         <commons-fileupload.version>1.3</commons-fileupload.version>
         <junit.jupiter.version>5.0.2</junit.jupiter.version>
+        <directory-maven-plugin.version>0.3.1</directory-maven-plugin.version>
+        <maven-install-plugin.version>2.5.1</maven-install-plugin.version>
+        <custom-pmd.version>0.0.1</custom-pmd.version>
+        <gitflow-incremental-builder.version>3.4</gitflow-incremental-builder.version>
+        <maven-jxr-plugin.version>2.3</maven-jxr-plugin.version>
+        <!-- <maven-pmd-plugin.version>3.9.0</maven-pmd-plugin.version> -->
+        <maven-pmd-plugin.version>3.8</maven-pmd-plugin.version>
     </properties>
+
 </project>