incorporate review comments for BAEL-747 (#1603)

This commit is contained in:
Mohamed Sanaulla
2017-04-07 17:31:39 +03:00
committed by maibin
parent 69965db187
commit d87e0663fc
8 changed files with 26 additions and 20 deletions
@@ -2,10 +2,10 @@ package com.baeldung.algorithms.primechecker;
import java.math.BigInteger;
public class BigIntegerPrimeChecker implements PrimeChecker{
public class BigIntegerPrimeChecker implements PrimeChecker<Long>{
@Override
public boolean isPrime(int number) {
public boolean isPrime(Long number) {
BigInteger bigInt = BigInteger.valueOf(number);
return bigInt.isProbablePrime(100);
}
@@ -1,12 +1,15 @@
package com.baeldung.algorithms.primechecker;
import java.util.stream.IntStream;
import java.util.stream.LongStream;
public class BruteForcePrimeChecker implements PrimeChecker{
public class BruteForcePrimeChecker implements PrimeChecker<Integer>{
@Override
public boolean isPrime(int number) {
return IntStream.range(2, number).noneMatch(n -> (number % n == 0));
public boolean isPrime(Integer number) {
return number > 2 ? IntStream.range(2, number)
.noneMatch(n -> (number % n == 0)) : false;
}
@@ -1,13 +1,14 @@
package com.baeldung.algorithms.primechecker;
import java.util.stream.IntStream;
import java.util.stream.LongStream;
public class OptimisedPrimeChecker implements PrimeChecker{
public class OptimisedPrimeChecker implements PrimeChecker<Integer>{
@Override
public boolean isPrime(int number) {
return IntStream.range(2, (int)Math.sqrt(number) + 1)
.noneMatch(n -> (number % n == 0));
public boolean isPrime(Integer number) {
return number > 2 ? IntStream.rangeClosed(2, (int) Math.sqrt(number))
.noneMatch(n -> (number % n == 0)) : false;
}
@@ -1,6 +1,6 @@
package com.baeldung.algorithms.primechecker;
public interface PrimeChecker {
public interface PrimeChecker <T> {
public boolean isPrime( int number );
public boolean isPrime( T number );
}
@@ -2,10 +2,10 @@ package com.baeldung.algorithms.primechecker;
import org.apache.commons.math3.primes.Primes;
public class PrimesPrimeChecker implements PrimeChecker{
public class PrimesPrimeChecker implements PrimeChecker<Integer>{
@Override
public boolean isPrime(int number) {
public boolean isPrime(Integer number) {
return Primes.isPrime(number);
}