From ff29b0ca05d13a7645dbcfdb3a540f4513f0832b Mon Sep 17 00:00:00 2001 From: Stephen Braimah Date: Thu, 19 Jan 2017 09:43:34 +0000 Subject: [PATCH 1/3] BAEL-583: Added additional test case for parallel streams --- .../java8/Java8FindAnyFindFirstTest.java | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java b/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java index 7708d7e098..9fb2bee647 100644 --- a/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java +++ b/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java @@ -1,9 +1,6 @@ package com.baeldung.java8; -import org.assertj.core.condition.AnyOf; -import org.hamcrest.Matchers; -import org.junit.Assert; import org.junit.Test; import java.util.Arrays; @@ -22,10 +19,23 @@ public class Java8FindAnyFindFirstTest { Optional result = list.stream().findAny(); - assert result.isPresent(); + assertTrue(result.isPresent()); assertThat(result.get(), anyOf(is("A"), is("B"), is("C"), is("D"))); } + @Test + public void createParallelStream_whenFindAnyResultIsNotFirst_ThenCorrect() throws Exception { + List list = Arrays.asList(1,2,3,4,5); + Optional result = list + .stream() + .parallel() + .filter(num -> num<4) + .findAny(); + + assertTrue(result.isPresent()); + assertThat(result.get(),anyOf(is(1), is(2), is(3))); + } + @Test public void createStream_whenFindFirstResultIsPresent_thenCorrect() { @@ -33,7 +43,7 @@ public class Java8FindAnyFindFirstTest { Optional result = list.stream().findFirst(); - assert result.isPresent(); + assertTrue(result.isPresent()); assertThat(result.get(),is("A")); } } From 03902d250731ab61aad1493be72aeb13bc1c6181 Mon Sep 17 00:00:00 2001 From: Stephen Braimah Date: Thu, 19 Jan 2017 09:53:56 +0000 Subject: [PATCH 2/3] BAEL-583: Corrected naming for parallel stream test case --- .../test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java b/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java index 9fb2bee647..92898d9ba2 100644 --- a/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java +++ b/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java @@ -24,7 +24,7 @@ public class Java8FindAnyFindFirstTest { } @Test - public void createParallelStream_whenFindAnyResultIsNotFirst_ThenCorrect() throws Exception { + public void createParallelStream_whenFindAnyResultIsPresent_ThenCorrect() throws Exception { List list = Arrays.asList(1,2,3,4,5); Optional result = list .stream() From 62c59c82ceccfdb81ae627656145c320509a78d5 Mon Sep 17 00:00:00 2001 From: slavisa-baeldung Date: Sat, 21 Jan 2017 08:06:30 +0100 Subject: [PATCH 3/3] BAEL-583 - minor changes --- .../baeldung/java8/Java8FindAnyFindFirstTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java b/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java index d312a6206f..6a2b89963c 100644 --- a/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java +++ b/core-java/src/test/java/com/baeldung/java8/Java8FindAnyFindFirstTest.java @@ -17,7 +17,7 @@ public class Java8FindAnyFindFirstTest { @Test public void createStream_whenFindAnyResultIsPresent_thenCorrect() { - List list = Arrays.asList("A","B","C","D"); + List list = Arrays.asList("A", "B", "C", "D"); Optional result = list.stream().findAny(); @@ -26,26 +26,26 @@ public class Java8FindAnyFindFirstTest { } @Test - public void createParallelStream_whenFindAnyResultIsPresent_ThenCorrect() throws Exception { - List list = Arrays.asList(1,2,3,4,5); + public void createParallelStream_whenFindAnyResultIsPresent_thenCorrect() throws Exception { + List list = Arrays.asList(1, 2, 3, 4, 5); Optional result = list .stream() .parallel() - .filter(num -> num<4) + .filter(num -> num < 4) .findAny(); assertTrue(result.isPresent()); - assertThat(result.get(),anyOf(is(1), is(2), is(3))); + assertThat(result.get(), anyOf(is(1), is(2), is(3))); } @Test public void createStream_whenFindFirstResultIsPresent_thenCorrect() { - List list = Arrays.asList("A","B","C","D"); + List list = Arrays.asList("A", "B", "C", "D"); Optional result = list.stream().findFirst(); assertTrue(result.isPresent()); - assertThat(result.get(),is("A")); + assertThat(result.get(), is("A")); } }